Re: [PATCH] leds: cht-wcove: mark cht_wc_leds_brightness_get static

From: Hans de Goede <hdegoede@redhat.com>
To: Arnd Bergmann <arnd@kernel.org>, Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee@kernel.org>, Yauhen Kharuzhy <jekhor@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: cht-wcove: mark cht_wc_leds_brightness_get static
Date: Fri, 2 Jun 2023 14:59:48 +0200	[thread overview]
Message-ID: <880b5b02-3c4c-c104-2eab-22664f13a252@redhat.com> (raw)
In-Reply-To: <20230601213439.3398794-1-arnd@kernel.org>

Hi Arnd,

On 6/1/23 23:34, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This was apparently made global but is not called from anywhere else:
> 
> drivers/leds/leds-cht-wcove.c:144:21: error: no previous prototype for 'cht_wc_leds_brightness_get' [-Werror=missing-prototypes]
> 
> Fixes: 047da762b9a93 ("leds: Add Intel Cherry Trail Whiskey Cove PMIC LED driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thank you for the patch. This is a duplicate fix with these
2 earlier submissions of the same fix:

https://lore.kernel.org/linux-leds/20230525183317.129232-1-hdegoede@redhat.com/
https://lore.kernel.org/linux-leds/20230530234748.3641630-1-trix@redhat.com/

Regards,

Hans

> ---
>  drivers/leds/leds-cht-wcove.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-cht-wcove.c b/drivers/leds/leds-cht-wcove.c
> index 0cfebee989107..0a5c30e5ed5d4 100644
> --- a/drivers/leds/leds-cht-wcove.c
> +++ b/drivers/leds/leds-cht-wcove.c
> @@ -141,7 +141,7 @@ static int cht_wc_leds_brightness_set(struct led_classdev *cdev,
>  	return ret;
>  }
>  
> -enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
> +static enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
>  {
>  	struct cht_wc_led *led = container_of(cdev, struct cht_wc_led, cdev);
>  	unsigned int val;