From: Dan Murphy <dmurphy@ti.com>
To: "Guido Günther" <agx@sigxcpu.org>,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
"Pavel Machek" <pavel@ucw.cz>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] leds: lm3692x: Use flags from LM3692X_BRT_CTRL
Date: Wed, 18 Sep 2019 13:48:06 -0500 [thread overview]
Message-ID: <905f43fb-b75c-d0f2-8669-275e18241735@ti.com> (raw)
In-Reply-To: <d1347a31ab9f86c3d13ab8016606999d5c0497cd.1568772964.git.agx@sigxcpu.org>
Guido
On 9/17/19 9:19 PM, Guido Günther wrote:
> Use LM3692X_RAMP_EN instead of LM3692X_PWM_HYSTER_4LSB
> since the later is a flag for the PWM register. The
> actual register value remains unchanged.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
Reviewed-by: Dan Murphy <dmurphy@ti.com>
> ---
> drivers/leds/leds-lm3692x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c
> index d673f706385e..ecac586ca89c 100644
> --- a/drivers/leds/leds-lm3692x.c
> +++ b/drivers/leds/leds-lm3692x.c
> @@ -269,7 +269,7 @@ static int lm3692x_init(struct lm3692x_led *led)
> goto out;
>
> ret = regmap_write(led->regmap, LM3692X_BRT_CTRL,
> - LM3692X_BL_ADJ_POL | LM3692X_PWM_HYSTER_4LSB);
> + LM3692X_BL_ADJ_POL | LM3692X_RAMP_EN);
> if (ret)
> goto out;
>
next prev parent reply other threads:[~2019-09-18 18:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 2:19 [PATCH 0/5] leds: lm3692x: Probing and flag fixes Guido Günther
2019-09-18 2:19 ` [PATCH 1/5] leds: lm3692x: Print error value on dev_err Guido Günther
2019-09-18 18:23 ` Dan Murphy
2019-09-18 2:19 ` [PATCH 2/5] leds: lm3692x: Don't overwrite return value in error path Guido Günther
2019-09-18 18:33 ` Dan Murphy
2019-09-19 10:57 ` Pavel Machek
2019-09-18 2:19 ` [PATCH 3/5] leds: lm3692x: Handle failure to probe the regulator Guido Günther
2019-09-18 18:41 ` Dan Murphy
2019-09-18 2:19 ` [PATCH 4/5] leds: lm3692x: Use flags from LM3692X_BOOST_CTRL Guido Günther
2019-09-18 18:46 ` Dan Murphy
2019-09-18 2:19 ` [PATCH 5/5] leds: lm3692x: Use flags from LM3692X_BRT_CTRL Guido Günther
2019-09-18 18:48 ` Dan Murphy [this message]
2019-09-19 9:54 ` [PATCH 0/5] leds: lm3692x: Probing and flag fixes Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=905f43fb-b75c-d0f2-8669-275e18241735@ti.com \
--to=dmurphy@ti.com \
--cc=agx@sigxcpu.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).