* [PATCH] dt-bindings: leds: lm3630a: Fix the example compilation
@ 2019-10-31 13:48 Maxime Ripard
2019-11-05 15:41 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2019-10-31 13:48 UTC (permalink / raw)
To: Mark Rutland, Rob Herring, Frank Rowand, lee.jones,
daniel.thompson, jingoohan1, jacek.anaszewski, pavel, dmurphy
Cc: linux-leds, devicetree, Maxime Ripard, Andreas Kemnade
Commit ae92365cdd75 ("dt-bindings: backlight: lm3630a: Add enable-gpios to
describe HWEN pin") introduced in the example a GPIO flag that isn't
declared anywhere, resulting in a compilation breakage when running the
validation tools. Add the proper define.
Cc: Andreas Kemnade <andreas@kemnade.info>
Cc: Lee Jones <lee.jones@linaro.org>
Fixes: ae92365cdd75 ("dt-bindings: backlight: lm3630a: Add enable-gpios to describe HWEN pin")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
.../devicetree/bindings/leds/backlight/lm3630a-backlight.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
index c8470628fe02..72fc6f7ef90a 100644
--- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
+++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
@@ -93,6 +93,8 @@ additionalProperties: false
examples:
- |
+ #include <dt-bindings/gpio/gpio.h>
+
i2c {
#address-cells = <1>;
#size-cells = <0>;
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: leds: lm3630a: Fix the example compilation
2019-10-31 13:48 [PATCH] dt-bindings: leds: lm3630a: Fix the example compilation Maxime Ripard
@ 2019-11-05 15:41 ` Rob Herring
2019-11-11 9:56 ` Lee Jones
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2019-11-05 15:41 UTC (permalink / raw)
To: Maxime Ripard
Cc: Mark Rutland, Frank Rowand, Lee Jones, Daniel Thompson,
Jingoo Han, Jacek Anaszewski, Pavel Machek, Dan Murphy,
Linux LED Subsystem, devicetree, Andreas Kemnade
On Thu, Oct 31, 2019 at 8:48 AM Maxime Ripard <maxime@cerno.tech> wrote:
>
> Commit ae92365cdd75 ("dt-bindings: backlight: lm3630a: Add enable-gpios to
> describe HWEN pin") introduced in the example a GPIO flag that isn't
> declared anywhere, resulting in a compilation breakage when running the
> validation tools. Add the proper define.
>
> Cc: Andreas Kemnade <andreas@kemnade.info>
> Cc: Lee Jones <lee.jones@linaro.org>
> Fixes: ae92365cdd75 ("dt-bindings: backlight: lm3630a: Add enable-gpios to describe HWEN pin")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> .../devicetree/bindings/leds/backlight/lm3630a-backlight.yaml | 2 ++
> 1 file changed, 2 insertions(+)
Lee already applied a fix. Though it's not in linux-next yet.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: leds: lm3630a: Fix the example compilation
2019-11-05 15:41 ` Rob Herring
@ 2019-11-11 9:56 ` Lee Jones
0 siblings, 0 replies; 3+ messages in thread
From: Lee Jones @ 2019-11-11 9:56 UTC (permalink / raw)
To: Rob Herring
Cc: Maxime Ripard, Mark Rutland, Frank Rowand, Daniel Thompson,
Jingoo Han, Jacek Anaszewski, Pavel Machek, Dan Murphy,
Linux LED Subsystem, devicetree, Andreas Kemnade
On Tue, 05 Nov 2019, Rob Herring wrote:
> On Thu, Oct 31, 2019 at 8:48 AM Maxime Ripard <maxime@cerno.tech> wrote:
> >
> > Commit ae92365cdd75 ("dt-bindings: backlight: lm3630a: Add enable-gpios to
> > describe HWEN pin") introduced in the example a GPIO flag that isn't
> > declared anywhere, resulting in a compilation breakage when running the
> > validation tools. Add the proper define.
> >
> > Cc: Andreas Kemnade <andreas@kemnade.info>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Fixes: ae92365cdd75 ("dt-bindings: backlight: lm3630a: Add enable-gpios to describe HWEN pin")
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > ---
> > .../devicetree/bindings/leds/backlight/lm3630a-backlight.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Lee already applied a fix. Though it's not in linux-next yet.
It is now.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-11 9:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-31 13:48 [PATCH] dt-bindings: leds: lm3630a: Fix the example compilation Maxime Ripard
2019-11-05 15:41 ` Rob Herring
2019-11-11 9:56 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).