* Re: [PATCH 09/69] leds: lp5523: check return value of lp5xx_read and jump to cleanup code [not found] ` <20210503115736.2104747-10-gregkh@linuxfoundation.org> @ 2021-05-03 19:36 ` Jacek Anaszewski 2021-05-13 15:25 ` Greg Kroah-Hartman 0 siblings, 1 reply; 2+ messages in thread From: Jacek Anaszewski @ 2021-05-03 19:36 UTC (permalink / raw) To: Greg Kroah-Hartman, linux-kernel Cc: Phillip Potter, stable, Linux LED Subsystem, Pavel Machek On 5/3/21 1:56 PM, Greg Kroah-Hartman wrote: > From: Phillip Potter <phil@philpotter.co.uk> > > Check return value of lp5xx_read and if non-zero, jump to code at end of > the function, causing lp5523_stop_all_engines to be executed before > returning the error value up the call chain. This fixes the original > commit (248b57015f35) which was reverted due to the University of Minnesota > problems. > > Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Cc: stable <stable@vger.kernel.org> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/leds/leds-lp5523.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c > index 5036d7d5f3d4..b1590cb4a188 100644 > --- a/drivers/leds/leds-lp5523.c > +++ b/drivers/leds/leds-lp5523.c > @@ -305,7 +305,9 @@ static int lp5523_init_program_engine(struct lp55xx_chip *chip) > > /* Let the programs run for couple of ms and check the engine status */ > usleep_range(3000, 6000); > - lp55xx_read(chip, LP5523_REG_STATUS, &status); > + ret = lp55xx_read(chip, LP5523_REG_STATUS, &status); > + if (ret) > + goto out; > status &= LP5523_ENG_STATUS_MASK; > > if (status != LP5523_ENG_STATUS_MASK) { > Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> Cc: Pavel Machek <pavel@ucw.cz>, linux-leds@vger.kernel.org -- Best regards, Jacek Anaszewski ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 09/69] leds: lp5523: check return value of lp5xx_read and jump to cleanup code 2021-05-03 19:36 ` [PATCH 09/69] leds: lp5523: check return value of lp5xx_read and jump to cleanup code Jacek Anaszewski @ 2021-05-13 15:25 ` Greg Kroah-Hartman 0 siblings, 0 replies; 2+ messages in thread From: Greg Kroah-Hartman @ 2021-05-13 15:25 UTC (permalink / raw) To: Jacek Anaszewski Cc: linux-kernel, Phillip Potter, stable, Linux LED Subsystem, Pavel Machek On Mon, May 03, 2021 at 09:36:14PM +0200, Jacek Anaszewski wrote: > On 5/3/21 1:56 PM, Greg Kroah-Hartman wrote: > > From: Phillip Potter <phil@philpotter.co.uk> > > > > Check return value of lp5xx_read and if non-zero, jump to code at end of > > the function, causing lp5523_stop_all_engines to be executed before > > returning the error value up the call chain. This fixes the original > > commit (248b57015f35) which was reverted due to the University of Minnesota > > problems. > > > > Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com> > > Cc: stable <stable@vger.kernel.org> > > Signed-off-by: Phillip Potter <phil@philpotter.co.uk> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > drivers/leds/leds-lp5523.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c > > index 5036d7d5f3d4..b1590cb4a188 100644 > > --- a/drivers/leds/leds-lp5523.c > > +++ b/drivers/leds/leds-lp5523.c > > @@ -305,7 +305,9 @@ static int lp5523_init_program_engine(struct lp55xx_chip *chip) > > /* Let the programs run for couple of ms and check the engine status */ > > usleep_range(3000, 6000); > > - lp55xx_read(chip, LP5523_REG_STATUS, &status); > > + ret = lp55xx_read(chip, LP5523_REG_STATUS, &status); > > + if (ret) > > + goto out; > > status &= LP5523_ENG_STATUS_MASK; > > if (status != LP5523_ENG_STATUS_MASK) { > > > > Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> Thanks for the review! ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-13 15:25 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20210503115736.2104747-1-gregkh@linuxfoundation.org> [not found] ` <20210503115736.2104747-10-gregkh@linuxfoundation.org> 2021-05-03 19:36 ` [PATCH 09/69] leds: lp5523: check return value of lp5xx_read and jump to cleanup code Jacek Anaszewski 2021-05-13 15:25 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).