From: Julian Andres Klode <julian.klode@canonical.com>
To: Zdenek Kabelac <zkabelac@redhat.com>
Cc: LVM general discussion and development <linux-lvm@redhat.com>
Subject: Re: [linux-lvm] [PATCH] Detect systemd at run-time in 69-dm-lvm-metad.rules
Date: Tue, 30 Jul 2019 17:12:23 +0200 [thread overview]
Message-ID: <20190730151223.jfxvd2qwaf5jdjsm@jak-t480s> (raw)
In-Reply-To: <e14a2033-893a-0e0a-4e32-0a62883a9d25@redhat.com>
On Tue, Jul 30, 2019 at 05:02:44PM +0200, Zdenek Kabelac wrote:
> Dne 25. 07. 19 v 20:49 Julian Andres Klode napsal(a):
> > systems might have systemd as their normal init systems, but
> > might not be using it in their initramfs; or like Debian, support
> > different init systems.
> >
> > Detect whether we are running on systemd by checking for /run/systemd/system
> > and then change the behavior accordingly.
> >
>
>
> Wouldn't it be better to simply disable compiling/using lvmetad on such systems ?
I don't see how this has anything to do with lvmetad. There is no lvmetad
anymore.
> HEAD of 2.03 already dropped lvmetad anyway.
>
> Do you need any sort of autoactivation in ramdisk ?
Of course we need the PV to be scanned automatically so we can then find
the root partition. The root device finding is event-based, we have a tool
that listens to udev and waits for 30s for the device to appear, and relies
on the events being triggered correctly.
> There is probably higher complexity.
>
> pvscan was not moved into systemd service just for fun - there have been at
> least 2 major mandatory points why 'pvscan' with autoactivation MUST NOT be
> executed from udev rule directly (udev timeout)
>
> So the proposed patch must be NAC-ked as it is - as it probably causing way
> more troubles then it solves.
The alternative would be to disable the systemd integration entirely in
Debian and Ubuntu, as Debian requires support for non-systemd inits, and
Ubuntu requires event-based root device finding in initramfs. Surely that's
worse.
--
debian developer - deb.li/jak | jak-linux.org - free software dev
ubuntu core developer i speak de, en
next prev parent reply other threads:[~2019-07-30 15:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 18:49 [linux-lvm] [PATCH] Detect systemd at run-time in 69-dm-lvm-metad.rules Julian Andres Klode
2019-07-30 15:02 ` Zdenek Kabelac
2019-07-30 15:12 ` Julian Andres Klode [this message]
2019-07-31 9:21 ` Zdenek Kabelac
2019-07-31 9:33 ` Julian Andres Klode
2019-07-31 10:16 ` Zdenek Kabelac
2019-07-31 10:51 ` Gionatan Danti
2019-07-31 11:12 ` Zdenek Kabelac
2019-07-31 9:39 ` Julian Andres Klode
2019-07-31 10:22 ` Zdenek Kabelac
2019-07-31 10:41 ` Julian Andres Klode
2019-07-31 11:09 ` Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730151223.jfxvd2qwaf5jdjsm@jak-t480s \
--to=julian.klode@canonical.com \
--cc=linux-lvm@redhat.com \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).