* Re: [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions [not found] ` <20181012163433.GA223066@joelaf.mtv.corp.google.com> @ 2018-10-12 16:38 ` Julia Lawall 2018-10-12 16:46 ` Joel Fernandes 0 siblings, 1 reply; 2+ messages in thread From: Julia Lawall @ 2018-10-12 16:38 UTC (permalink / raw) To: Joel Fernandes Cc: linux-mips, linux-m68k, Rich Felker, linux-ia64, linux-sh, Peter Zijlstra, Catalin Marinas, Dave Hansen, Will Deacon, Michal Hocko, linux-mm, lokeshgidra, sparclinux, linux-riscv, elfring, Jonas Bonn, linux-s390, dancol, Yoshinori Sato, Max Filippov, linux-hexagon, Helge Deller, maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT, hughd, James E.J. Bottomley, kasan-dev, Anton Ivanov > I wrote something like this as below but it failed to compile, Julia any > suggestions on how to express this? > > @pte_alloc_func_proto depends on patch exists@ > type T1, T2, T3, T4; > identifier fn =~ > "^(__pte_alloc|pte_alloc_one|pte_alloc|__pte_alloc_kernel|pte_alloc_one_kernel)$"; > @@ > > ( > - T3 fn(T1, T2); > + T3 fn(T1); > | > - T3 fn(T1, T2, T4); > + T3 fn(T1, T2); > ) What goes wrong? It seems fine to me. julia ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions 2018-10-12 16:38 ` [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions Julia Lawall @ 2018-10-12 16:46 ` Joel Fernandes 0 siblings, 0 replies; 2+ messages in thread From: Joel Fernandes @ 2018-10-12 16:46 UTC (permalink / raw) To: Julia Lawall Cc: linux-mips, linux-m68k, Rich Felker, linux-ia64, linux-sh, Peter Zijlstra, Catalin Marinas, Dave Hansen, Will Deacon, Michal Hocko, linux-mm, lokeshgidra, sparclinux, linux-riscv, elfring, Jonas Bonn, linux-s390, dancol, Yoshinori Sato, Max Filippov, linux-hexagon, Helge Deller, maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT, hughd, James E.J. Bottomley, kasan-dev, Anton Ivanov On Fri, Oct 12, 2018 at 06:38:57PM +0200, Julia Lawall wrote: > > I wrote something like this as below but it failed to compile, Julia any > > suggestions on how to express this? > > > > @pte_alloc_func_proto depends on patch exists@ > > type T1, T2, T3, T4; > > identifier fn =~ > > "^(__pte_alloc|pte_alloc_one|pte_alloc|__pte_alloc_kernel|pte_alloc_one_kernel)$"; > > @@ > > > > ( > > - T3 fn(T1, T2); > > + T3 fn(T1); > > | > > - T3 fn(T1, T2, T4); > > + T3 fn(T1, T2); > > ) > > What goes wrong? It seems fine to me. Weird it seems working now. I could swear 5 minutes ago it wasn't and I did give a unique rule name. Don't know what I missed. Anyway, thank you for all the quick responses and the help! - Joel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-12 16:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20181012013756.11285-1-joel@joelfernandes.org>
[not found] ` <594fc952-5e87-3162-b2f9-963479d16eb3@kot-begemot.co.uk>
[not found] ` <20181012163433.GA223066@joelaf.mtv.corp.google.com>
2018-10-12 16:38 ` [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions Julia Lawall
2018-10-12 16:46 ` Joel Fernandes
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).