From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Michael Schmitz <schmitzmic@gmail.com>
Cc: "Linux/m68k" <linux-m68k@vger.kernel.org>,
linux-ide@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Michael Schmitz <schmitz@debian.org>
Subject: Re: [PATCH] ide: falconide: convert to platform driver
Date: Tue, 5 Nov 2019 19:46:44 +0100 [thread overview]
Message-ID: <CAMuHMdVBpMJ6E9N1=YG6VPNJifexdbM9=PWAkjyLwdz9b5n0YQ@mail.gmail.com> (raw)
In-Reply-To: <CAOmrzkKLosq7LdXS6BuvHSARPXCXPiasW1zGywY3+hoys4NxoA@mail.gmail.com>
Hi Michael,
On Tue, Nov 5, 2019 at 7:31 PM Michael Schmitz <schmitzmic@gmail.com> wrote:
> On Tue, Nov 5, 2019 at 9:11 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Tue, Nov 5, 2019 at 7:38 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
> > > With the introduction of a platform device for the Atari Falcon IDE
> > > interface, the old Falcon IDE driver no longer loads (resource already
> > > claimed by the platform device).
> > >
> > > Convert falconide driver to use the same platform device that is used
> > > by pata_falcon also.
> > >
> > > Tested (as built-in driver) on my Atari Falcon.
> > >
> > > Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
> > > --- a/drivers/ide/falconide.c
> > > +++ b/drivers/ide/falconide.c
> > > @@ -23,6 +24,7 @@
> > > #include <asm/ide.h>
> > >
> > > #define DRV_NAME "falconide"
> > > +#define DRV_VERSION "0.1.0"
> >
> > Does anyone care about that version?
>
> Not likely.
>
> > Will it ever be updated?
>
> You ask me? You're still listed as driver author!
Yeah, I wrote a "it compiles, so it must work" driver in the IDE framework,
based on a driver in an even older framework. I never ran it on hardware ;-)
> > > @@ -169,10 +177,21 @@ static int __init falconide_init(void)
>
> Should I remove the __init here? Doesn't hurt in the built-in use
> case, what about use as a module?
Should be fine.
>
> > > err_free:
> > > ide_host_free(host);
> > > err:
> > > - release_mem_region(ATA_HD_BASE, 0x40);
> > > + release_mem_region(res->start, resource_size(res));
> > > return rc;
> > > }
> > >
> > > -module_init(falconide_init);
> > > +static struct platform_driver ide_falcon_driver = {
> > > + .driver = {
> > > + .name = "atari-falcon-ide",
> > > + },
> > > +};
> >
> > Missing .remove() callback.
>
> Can't easily test driver remove, but I can certainly add a callback for that.
>
> ide_unregister does the Right Thing (i.e. leaves the ST-DMA interrupt
> registered) so no reason why it shouldn't work.
gayle.c uses ide_host_remove().
> > > +
> > > +module_platform_driver_probe(ide_falcon_driver, falconide_init);
> > > +
> > >
> > > +MODULE_AUTHOR("Geert Uytterhoeven");
> > > +MODULE_DESCRIPTION("low-level driver for Atari Falcon IDE");
> > > MODULE_LICENSE("GPL");
> > > +MODULE_ALIAS("platform:atari-falcon-ide");
> > > +MODULE_VERSION(DRV_VERSION);
> >
> > I'd drop the MODULE_VERSION().
>
> Done.
>
> Shall I merge this one with part one of the old series so there's no
> chance of a bisection going wrong?
Yes please.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-11-05 18:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1569470064-3977-1-git-send-email-schmitzmic@gmail.com>
2019-10-25 20:33 ` [PATCH RESEND v2 0/2] Convert Atari Falcon IDE driver to platform device Jens Axboe
2019-10-26 18:17 ` Geert Uytterhoeven
2019-10-28 7:03 ` Michael Schmitz
2019-11-04 11:04 ` Geert Uytterhoeven
2019-11-04 19:17 ` Michael Schmitz
2019-11-04 20:06 ` Geert Uytterhoeven
2019-11-04 21:10 ` John Paul Adrian Glaubitz
2019-11-04 21:21 ` Michael Schmitz
2019-11-04 21:42 ` John Paul Adrian Glaubitz
2019-11-05 6:57 ` Michael Schmitz
2019-11-06 1:34 ` Michael Schmitz
[not found] ` <1569470064-3977-2-git-send-email-schmitzmic@gmail.com>
2019-11-04 10:56 ` [PATCH RESEND v2 1/2] m68k/atari: add platform device for Falcon IDE port Geert Uytterhoeven
2019-11-04 21:09 ` Michael Schmitz
2019-11-05 6:37 ` [PATCH] ide: falconide: convert to platform driver Michael Schmitz
2019-11-05 8:11 ` Geert Uytterhoeven
2019-11-05 18:31 ` Michael Schmitz
2019-11-05 18:46 ` Geert Uytterhoeven [this message]
2019-11-05 20:02 ` Michael Schmitz
2019-11-05 21:13 ` Michael Schmitz
2019-11-05 21:43 ` Geert Uytterhoeven
2019-11-06 1:35 ` Michael Schmitz
2019-11-05 6:43 ` [PATCH RESEND v2 1/2] m68k/atari: add platform device for Falcon IDE port Michael Schmitz
[not found] ` <1569470064-3977-3-git-send-email-schmitzmic@gmail.com>
2019-11-04 10:58 ` [PATCH RESEND v2 2/2] drivers/ata: convert pata_falcon to arch platform device Geert Uytterhoeven
2019-11-06 2:47 ` [PATCH v3] m68k/atari: convert legacy Falcon IDE driver to platform driver Michael Schmitz
2019-11-18 9:20 ` Geert Uytterhoeven
2019-11-18 9:41 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVBpMJ6E9N1=YG6VPNJifexdbM9=PWAkjyLwdz9b5n0YQ@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=b.zolnierkie@samsung.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schmitz@debian.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).