[PATCH] quotactl.2: add EINVAL situation of Q_XQUOTARM call

[PATCH] quotactl.2: add EINVAL situation of Q_XQUOTARM call

[Yang Xu]

Since kernel commit 3dd4d40b4208("xfs: Sanity check flags
of Q_XQUOTARM call"), it has added flags check. If it is
not usr,grp,prj quota type, it will report EINVAL.

Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
 man2/quotactl.2 | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/man2/quotactl.2 b/man2/quotactl.2
index 34d3cfca8..d636818bd 100644
--- a/man2/quotactl.2
+++ b/man2/quotactl.2
@@ -666,8 +666,10 @@ value containing flags (the same as in
 .I d_flags
 field of
 .I fs_disk_quota
-structure) which identify what types of quota should be removed
-(note that the quota type passed in the
+structure, check flags since Linux 5.5)
+.\" 3dd4d40b420846dd35869ccc8f8627feef2cff32
+which identify what types of quota
+should be removed(note that the quota type passed in the
 .I cmd
 argument is ignored, but should remain valid in order to pass preliminary
 quotactl syscall handler checks).
@@ -736,6 +738,12 @@ is
 .BR Q_QUOTAON ,
 but the specified quota file is corrupted.
 .TP
+.B EINVAL
+.I cmd
+is
+.BR Q_XQUOTARM ,
+but the addr does not point to valid quota types.
+.TP
 .B ENOENT
 The file specified by
 .I special
-- 
2.18.0

Re: [PATCH] quotactl.2: add EINVAL situation of Q_XQUOTARM call

[Michael Kerrisk (man-pages)]

Hello Yang Xu,

On 12/3/19 7:05 AM, Yang Xu wrote:
> Since kernel commit 3dd4d40b4208("xfs: Sanity check flags
> of Q_XQUOTARM call"), it has added flags check. If it is
> not usr,grp,prj quota type, it will report EINVAL.
> 
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> ---
>  man2/quotactl.2 | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/man2/quotactl.2 b/man2/quotactl.2
> index 34d3cfca8..d636818bd 100644
> --- a/man2/quotactl.2
> +++ b/man2/quotactl.2
> @@ -666,8 +666,10 @@ value containing flags (the same as in
>  .I d_flags
>  field of
>  .I fs_disk_quota
> -structure) which identify what types of quota should be removed
> -(note that the quota type passed in the
> +structure, check flags since Linux 5.5)
> +.\" 3dd4d40b420846dd35869ccc8f8627feef2cff32
> +which identify what types of quota
> +should be removed(note that the quota type passed in the
>  .I cmd
>  argument is ignored, but should remain valid in order to pass preliminary
>  quotactl syscall handler checks).
> @@ -736,6 +738,12 @@ is
>  .BR Q_QUOTAON ,
>  but the specified quota file is corrupted.
>  .TP
> +.B EINVAL
> +.I cmd
> +is
> +.BR Q_XQUOTARM ,
> +but the addr does not point to valid quota types.
> +.TP
>  .B ENOENT
>  The file specified by
>  .I special

Thanks. I applied you patch, and then tweaked a little,
so that the change became as below.

Thanks,

Michael


diff --git a/man2/quotactl.2 b/man2/quotactl.2
index 34d3cfca8..43552a0d6 100644
--- a/man2/quotactl.2
+++ b/man2/quotactl.2
@@ -666,11 +666,13 @@ value containing flags (the same as in
 .I d_flags
 field of
 .I fs_disk_quota
-structure) which identify what types of quota should be removed
-(note that the quota type passed in the
+structure)
+which identify what types of quota
+should be removed.
+(Note that the quota type passed in the
 .I cmd
 argument is ignored, but should remain valid in order to pass preliminary
-quotactl syscall handler checks).
+quotactl syscall handler checks.)
 .IP
 Quotas must have already been turned off.
 The
@@ -736,6 +738,15 @@ is
 .BR Q_QUOTAON ,
 but the specified quota file is corrupted.
 .TP
+.BR EINVAL " (since Linux 5.5)"
+.\" 3dd4d40b420846dd35869ccc8f8627feef2cff32
+.I cmd
+is
+.BR Q_XQUOTARM ,
+but
+.I addr
+does not point to valid quota types.
+.TP
 .B ENOENT
 The file specified by
 .I special


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/