From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: enh <enh@google.com>
Cc: mtk.manpages@gmail.com,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
linux-man <linux-man@vger.kernel.org>,
Zack Weinberg <zackw@panix.com>,
Carlos O'Donell <carlos@redhat.com>,
Florian Weimer <fweimer@redhat.com>,
Paul Eggert <eggert@cs.ucla.edu>,
Joseph Myers <joseph@codesourcery.com>,
Linux API <linux-api@vger.kernel.org>
Subject: Re: [RFC PATCH] Replacing "master-slave" terminology for pseudoterminals
Date: Thu, 30 Jul 2020 11:16:55 +0200 [thread overview]
Message-ID: <24960dff-1d54-b617-26ba-bad168e70ee8@gmail.com> (raw)
In-Reply-To: <CAJgzZopP=O1cZ2M=3h6Q-X08+eVMPQE_zOCnsEjN=hUTHOkYwQ@mail.gmail.com>
Hello Elliot,
Thanks for looking at the patch.
On 7/29/20 6:31 PM, enh wrote:
> yeah, the old terminology was so non-obvious that reading through this,
> every change seemed like an improvement in clarity.
>
> my only suggestion would be to consistently use tty_fd and pty_fd in the
> function signatures rather than just fd. (the presence or absence of 'p' in
> the function name is a clue, i hadn't picked up on that until i
> tried rewriting code to use pty/tty rather than master/slave.)
Yes, I've made that change now also.
> (aside: i was surprised by multiplexor rather than multiplexer, but grep
> says man7.org has 2 multiplexors to 1 multiplexer, so lgtm.)
Carlos also commented on this. I've changed it (and also
in other manual pages where "multiplexor" appeared)
Cheers,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
prev parent reply other threads:[~2020-07-30 9:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 10:39 [RFC PATCH] Replacing "master-slave" terminology for pseudoterminals Michael Kerrisk (man-pages)
2020-07-29 10:47 ` Michael Kerrisk (man-pages)
2020-07-30 4:06 ` Carlos O'Donell
2020-07-30 9:16 ` Michael Kerrisk (man-pages)
2020-07-30 11:38 ` Carlos O'Donell
2020-07-30 20:35 ` enh
2020-07-31 7:48 ` Michael Kerrisk (man-pages)
2020-08-04 17:25 ` enh
2020-08-04 20:04 ` Michael Kerrisk (man-pages)
[not found] ` <CAJgzZopP=O1cZ2M=3h6Q-X08+eVMPQE_zOCnsEjN=hUTHOkYwQ@mail.gmail.com>
2020-07-30 9:16 ` Michael Kerrisk (man-pages) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24960dff-1d54-b617-26ba-bad168e70ee8@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=carlos@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=enh@google.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).