* [PATCH v2] media: unify some sony camera sensors pattern naming
@ 2018-11-27 9:03 bingbu.cao
2018-11-27 9:33 ` Sakari Ailus
0 siblings, 1 reply; 3+ messages in thread
From: bingbu.cao @ 2018-11-27 9:03 UTC (permalink / raw)
To: linux-media; +Cc: sakari.ailus, tfiga, andy.yeh, bingbu.cao, luca
From: Bingbu Cao <bingbu.cao@intel.com>
Some Sony camera sensors have same pattern
definitions, this patch unify the pattern naming
to make it more clear to the userspace.
Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
Reviewed-by: luca@lucaceresoli.net
---
drivers/media/i2c/imx258.c | 6 +++---
drivers/media/i2c/imx319.c | 8 ++++----
drivers/media/i2c/imx355.c | 8 ++++----
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c
index 31a1e2294843..de399f69dc9b 100644
--- a/drivers/media/i2c/imx258.c
+++ b/drivers/media/i2c/imx258.c
@@ -504,10 +504,10 @@ struct imx258_mode {
static const char * const imx258_test_pattern_menu[] = {
"Disabled",
- "Color Bars",
"Solid Color",
- "Grey Color Bars",
- "PN9"
+ "Eight Vertical Color Bars",
+ "Color Bars With Fade to Grey",
+ "Pseudorandom Sequence (PN9)",
};
static const int imx258_test_pattern_val[] = {
diff --git a/drivers/media/i2c/imx319.c b/drivers/media/i2c/imx319.c
index acd988d2d7f1..c508887c4574 100644
--- a/drivers/media/i2c/imx319.c
+++ b/drivers/media/i2c/imx319.c
@@ -1648,10 +1648,10 @@ struct imx319 {
static const char * const imx319_test_pattern_menu[] = {
"Disabled",
- "Solid color",
- "100% color bars",
- "Fade to gray color bars",
- "PN9"
+ "Solid Color",
+ "Eight Vertical Color Bars",
+ "Color Bars With Fade to Grey",
+ "Pseudorandom Sequence (PN9)",
};
/* supported link frequencies */
diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
index 9c9559dfd3dd..608947dc1a65 100644
--- a/drivers/media/i2c/imx355.c
+++ b/drivers/media/i2c/imx355.c
@@ -876,10 +876,10 @@ struct imx355 {
static const char * const imx355_test_pattern_menu[] = {
"Disabled",
- "Solid color",
- "100% color bars",
- "Fade to gray color bars",
- "PN9"
+ "Solid Color",
+ "Eight Vertical Color Bars",
+ "Color Bars With Fade to Grey",
+ "Pseudorandom Sequence (PN9)",
};
/* supported link frequencies */
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] media: unify some sony camera sensors pattern naming
2018-11-27 9:03 [PATCH v2] media: unify some sony camera sensors pattern naming bingbu.cao
@ 2018-11-27 9:33 ` Sakari Ailus
2018-11-27 11:12 ` Bingbu Cao
0 siblings, 1 reply; 3+ messages in thread
From: Sakari Ailus @ 2018-11-27 9:33 UTC (permalink / raw)
To: bingbu.cao; +Cc: linux-media, tfiga, andy.yeh, bingbu.cao, luca
On Tue, Nov 27, 2018 at 05:03:26PM +0800, bingbu.cao@intel.com wrote:
> From: Bingbu Cao <bingbu.cao@intel.com>
>
> Some Sony camera sensors have same pattern
> definitions, this patch unify the pattern naming
> to make it more clear to the userspace.
>
> Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> Reviewed-by: luca@lucaceresoli.net
Hi Bing Bu,
Sorry, I prefer your v1. :-)
--
Sakari Ailus
sakari.ailus@linux.intel.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] media: unify some sony camera sensors pattern naming
2018-11-27 9:33 ` Sakari Ailus
@ 2018-11-27 11:12 ` Bingbu Cao
0 siblings, 0 replies; 3+ messages in thread
From: Bingbu Cao @ 2018-11-27 11:12 UTC (permalink / raw)
To: Sakari Ailus, bingbu.cao; +Cc: linux-media, tfiga, andy.yeh, luca
On 11/27/2018 05:33 PM, Sakari Ailus wrote:
> On Tue, Nov 27, 2018 at 05:03:26PM +0800, bingbu.cao@intel.com wrote:
>> From: Bingbu Cao <bingbu.cao@intel.com>
>>
>> Some Sony camera sensors have same pattern
>> definitions, this patch unify the pattern naming
>> to make it more clear to the userspace.
>>
>> Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
>> Reviewed-by: luca@lucaceresoli.net
> Hi Bing Bu,
>
> Sorry, I prefer your v1. :-)
Thanks.
It really prevent me Google more about difference between 'colour' and 'color'. :)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-27 22:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-27 9:03 [PATCH v2] media: unify some sony camera sensors pattern naming bingbu.cao
2018-11-27 9:33 ` Sakari Ailus
2018-11-27 11:12 ` Bingbu Cao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).