[PATCH v2] media: unify some sony camera sensors pattern naming

[PATCH v2] media: unify some sony camera sensors pattern naming

[bingbu.cao]

From: Bingbu Cao <bingbu.cao@intel.com>

Some Sony camera sensors have same pattern
definitions, this patch unify the pattern naming
to make it more clear to the userspace.

Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
Reviewed-by: luca@lucaceresoli.net
---
 drivers/media/i2c/imx258.c | 6 +++---
 drivers/media/i2c/imx319.c | 8 ++++----
 drivers/media/i2c/imx355.c | 8 ++++----
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c
index 31a1e2294843..de399f69dc9b 100644
--- a/drivers/media/i2c/imx258.c
+++ b/drivers/media/i2c/imx258.c
@@ -504,10 +504,10 @@ struct imx258_mode {
 
 static const char * const imx258_test_pattern_menu[] = {
 	"Disabled",
-	"Color Bars",
 	"Solid Color",
-	"Grey Color Bars",
-	"PN9"
+	"Eight Vertical Color Bars",
+	"Color Bars With Fade to Grey",
+	"Pseudorandom Sequence (PN9)",
 };
 
 static const int imx258_test_pattern_val[] = {
diff --git a/drivers/media/i2c/imx319.c b/drivers/media/i2c/imx319.c
index acd988d2d7f1..c508887c4574 100644
--- a/drivers/media/i2c/imx319.c
+++ b/drivers/media/i2c/imx319.c
@@ -1648,10 +1648,10 @@ struct imx319 {
 
 static const char * const imx319_test_pattern_menu[] = {
 	"Disabled",
-	"Solid color",
-	"100% color bars",
-	"Fade to gray color bars",
-	"PN9"
+	"Solid Color",
+	"Eight Vertical Color Bars",
+	"Color Bars With Fade to Grey",
+	"Pseudorandom Sequence (PN9)",
 };
 
 /* supported link frequencies */
diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
index 9c9559dfd3dd..608947dc1a65 100644
--- a/drivers/media/i2c/imx355.c
+++ b/drivers/media/i2c/imx355.c
@@ -876,10 +876,10 @@ struct imx355 {
 
 static const char * const imx355_test_pattern_menu[] = {
 	"Disabled",
-	"Solid color",
-	"100% color bars",
-	"Fade to gray color bars",
-	"PN9"
+	"Solid Color",
+	"Eight Vertical Color Bars",
+	"Color Bars With Fade to Grey",
+	"Pseudorandom Sequence (PN9)",
 };
 
 /* supported link frequencies */
-- 
1.9.1

Re: [PATCH v2] media: unify some sony camera sensors pattern naming

[Sakari Ailus]

On Tue, Nov 27, 2018 at 05:03:26PM +0800, bingbu.cao@intel.com wrote:
> From: Bingbu Cao <bingbu.cao@intel.com>
> 
> Some Sony camera sensors have same pattern
> definitions, this patch unify the pattern naming
> to make it more clear to the userspace.
> 
> Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> Reviewed-by: luca@lucaceresoli.net

Hi Bing Bu,

Sorry, I prefer your v1. :-)

-- 
Sakari Ailus
sakari.ailus@linux.intel.com

Re: [PATCH v2] media: unify some sony camera sensors pattern naming

[Bingbu Cao]

On 11/27/2018 05:33 PM, Sakari Ailus wrote:
> On Tue, Nov 27, 2018 at 05:03:26PM +0800, bingbu.cao@intel.com wrote:
>> From: Bingbu Cao <bingbu.cao@intel.com>
>>
>> Some Sony camera sensors have same pattern
>> definitions, this patch unify the pattern naming
>> to make it more clear to the userspace.
>>
>> Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
>> Reviewed-by: luca@lucaceresoli.net
> Hi Bing Bu,
>
> Sorry, I prefer your v1. :-)
Thanks.
It really prevent me Google more about difference between 'colour' and 'color'.  :)
>