From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [GIT PULL FOR v4.18] v2: Various fixes/improvements
Date: Thu, 22 Nov 2018 20:43:05 -0200 [thread overview]
Message-ID: <20181122204305.532d4108@coco.lan> (raw)
In-Reply-To: <a0d2f06b-391c-6308-89e6-64865eadf0b6@xs4all.nl>
Hi Hans,
Em Thu, 22 Nov 2018 23:26:07 +0100
Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> On 11/22/2018 09:52 PM, Mauro Carvalho Chehab wrote:
> > Em Tue, 8 May 2018 12:48:45 +0200
> > Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> >
> >> Fixes/improvements all over the place.
> >>
> >> Changes since v1:
> >>
> >> Replaced "media: media-device: fix ioctl function types" with the v2 version
> >> of that patch. My fault, I missed Sakari's request for a change of v1.
> >
> > You should seriously review how you're adding SOBs... there are
> > even some like:
> >
> > Signed-off-by Hans Verkuil <hans.verkuil>
> > Reported-by: syzbot+69780d144754b8071f4b@syzkaller.appspotmail.com
> > Cc: <stable@vger.kernel.org> # for v4.20 and up
> > Signed-off-by Hans Verkuil <hansverk@cisco.com>
>
> You seem to have replied to a different git pull request (v4.18?!) then
> what these lines above indicate, but it appears that this refers to patch
> "vim2m: use cancel_delayed_work_sync instead of flush_schedule_work".
>
> It looks like I just completely mistyped the SoB in that patch. Nothing to do
> with the xs4all vs cisco SoBs and AFAICS it is an issue just with that patch.
>
> Regarding those, the core problem is that I want to show that what I'm doing is
> paid for by Cisco, but I don't want to use the cisco email address to actually
> send patches, pull requests, etc., since that requires a vpn which is really annoying.
>
> I've made a new email alias hverkuil-cisco@xs4all.nl (I'm not allowed to use a '+'
> unfortunately) and I think I will use that as my git email address to avoid
> cisco.com entirely.
Yeah, I know the drill. I had to do about the same in order to mark
that my work is sponsored by Samsung.
> Regarding the outstanding pull requests with SoB/Author mismatches: should I redo
> those and repost? It's a pain, but if you want it I'll do that tomorrow.
Yes, please.
If it was just to remove a duplicated SoB from another e-mail (or a typo
outside the e-mail part), I would gladly do when merging (probably using git
filter or something scripteable tooling), but I don't feel comfortable to
replace an e-mail address on commits.
Thanks,
Mauro
prev parent reply other threads:[~2018-11-23 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 10:48 [GIT PULL FOR v4.18] v2: Various fixes/improvements Hans Verkuil
2018-11-22 20:52 ` Mauro Carvalho Chehab
2018-11-22 22:26 ` Hans Verkuil
2018-11-22 22:43 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122204305.532d4108@coco.lan \
--to=mchehab+samsung@kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).