* [GIT PULL FOR v4.18] v2: Various fixes/improvements
@ 2018-05-08 10:48 Hans Verkuil
2018-11-22 20:52 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 4+ messages in thread
From: Hans Verkuil @ 2018-05-08 10:48 UTC (permalink / raw)
To: Linux Media Mailing List
Fixes/improvements all over the place.
Changes since v1:
Replaced "media: media-device: fix ioctl function types" with the v2 version
of that patch. My fault, I missed Sakari's request for a change of v1.
Regards,
Hans
The following changes since commit f10379aad39e9da8bc7d1822e251b5f0673067ef:
media: include/video/omapfb_dss.h: use IS_ENABLED() (2018-05-05 11:45:51 -0400)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git for-v4.18b
for you to fetch changes up to 171d364998d1e2373c12b93924fe63cc71586101:
media: media-device: fix ioctl function types (2018-05-08 12:40:23 +0200)
----------------------------------------------------------------
Arvind Yadav (2):
platform: Use gpio_is_valid()
sta2x11: Use gpio_is_valid() and remove unnecessary check
Brad Love (4):
em28xx: Fix DualHD broken second tuner
intel-ipu3: Kconfig coding style issue
cec: Kconfig coding style issue
saa7164: Fix driver name in debug output
Colin Ian King (1):
media/usbvision: fix spelling mistake: "compresion" -> "compression"
Dan Carpenter (1):
media: vpbe_venc: potential uninitialized variable in ven_sub_dev_init()
Fengguang Wu (1):
media: vcodec: fix ptr_ret.cocci warnings
Hans Verkuil (2):
cec-gpio: use GPIOD_OUT_HIGH_OPEN_DRAIN
v4l2-dev.h: fix doc warning
Jacopo Mondi (1):
media: renesas-ceu: Set mbus_fmt on subdev operations
Jan Luebbe (1):
media: imx-csi: fix burst size for 16 bit
Jasmin Jessich (2):
media: Use ktime_set() in pt1.c
media: Revert cleanup ktime_set() usage
Julia Lawall (1):
pvrusb2: delete unneeded include
Niklas Söderlund (1):
media: entity: fix spelling for media_entity_get_fwnode_pad()
Philipp Zabel (4):
media: coda: reuse coda_s_fmt_vid_cap to propagate format in coda_s_fmt_vid_out
media: coda: do not try to propagate format if capture queue busy
media: coda: set colorimetry on coded queue
media: imx: add 16-bit grayscale support
Robin Murphy (1):
media: videobuf-dma-sg: Fix dma_{sync,unmap}_sg() calls
Sami Tolvanen (1):
media: media-device: fix ioctl function types
Simon Que (1):
v4l2-core: Rename array 'video_driver' to 'video_drivers'
Souptick Joarder (1):
videobuf: Change return type to vm_fault_t
Wolfram Sang (1):
media: platform: am437x: simplify getting .drvdata
drivers/media/Kconfig | 12 ++++++------
drivers/media/dvb-core/dmxdev.c | 2 +-
drivers/media/media-device.c | 21 +++++++++++----------
drivers/media/pci/cx88/cx88-input.c | 6 ++++--
drivers/media/pci/intel/ipu3/Kconfig | 12 ++++++------
drivers/media/pci/pt1/pt1.c | 2 +-
drivers/media/pci/pt3/pt3.c | 2 +-
drivers/media/pci/saa7164/saa7164-fw.c | 3 ++-
drivers/media/pci/sta2x11/sta2x11_vip.c | 31 +++++++++++++++----------------
drivers/media/platform/am437x/am437x-vpfe.c | 6 ++----
drivers/media/platform/cec-gpio/cec-gpio.c | 2 +-
drivers/media/platform/coda/coda-common.c | 45 +++++++++++++++++++++++++++++++--------------
drivers/media/platform/davinci/vpbe_venc.c | 2 +-
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 5 +----
drivers/media/platform/renesas-ceu.c | 20 +++++++++++++++-----
drivers/media/platform/via-camera.c | 2 +-
drivers/media/usb/em28xx/em28xx-dvb.c | 2 +-
drivers/media/usb/pvrusb2/pvrusb2-cx2584x-v4l.c | 1 -
drivers/media/usb/usbvision/usbvision-core.c | 2 +-
drivers/media/v4l2-core/v4l2-dev.c | 22 +++++++++++-----------
drivers/media/v4l2-core/videobuf-dma-sg.c | 6 +++---
drivers/staging/media/imx/imx-media-csi.c | 3 ++-
drivers/staging/media/imx/imx-media-utils.c | 9 +++++++++
include/media/media-entity.h | 2 +-
include/media/v4l2-dev.h | 1 +
25 files changed, 128 insertions(+), 93 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL FOR v4.18] v2: Various fixes/improvements
2018-05-08 10:48 [GIT PULL FOR v4.18] v2: Various fixes/improvements Hans Verkuil
@ 2018-11-22 20:52 ` Mauro Carvalho Chehab
2018-11-22 22:26 ` Hans Verkuil
0 siblings, 1 reply; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2018-11-22 20:52 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List
Em Tue, 8 May 2018 12:48:45 +0200
Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> Fixes/improvements all over the place.
>
> Changes since v1:
>
> Replaced "media: media-device: fix ioctl function types" with the v2 version
> of that patch. My fault, I missed Sakari's request for a change of v1.
You should seriously review how you're adding SOBs... there are
even some like:
Signed-off-by Hans Verkuil <hans.verkuil>
Reported-by: syzbot+69780d144754b8071f4b@syzkaller.appspotmail.com
Cc: <stable@vger.kernel.org> # for v4.20 and up
Signed-off-by Hans Verkuil <hansverk@cisco.com>
On this series. Again, none matching the Author's email.
PS.: one quick way to fix it is by using git filter.
You could do something like:
$ git filter-branch -f --msg-filter 'cat|grep -v "Signed-off-by: Your Name"; echo "Signed-off-by: Your Name <your.new@email>"' origin/master..
And fix all of them with a single command.
>
> Regards,
>
> Hans
>
> The following changes since commit f10379aad39e9da8bc7d1822e251b5f0673067ef:
>
> media: include/video/omapfb_dss.h: use IS_ENABLED() (2018-05-05 11:45:51 -0400)
>
> are available in the Git repository at:
>
> git://linuxtv.org/hverkuil/media_tree.git for-v4.18b
>
> for you to fetch changes up to 171d364998d1e2373c12b93924fe63cc71586101:
>
> media: media-device: fix ioctl function types (2018-05-08 12:40:23 +0200)
>
> ----------------------------------------------------------------
> Arvind Yadav (2):
> platform: Use gpio_is_valid()
> sta2x11: Use gpio_is_valid() and remove unnecessary check
>
> Brad Love (4):
> em28xx: Fix DualHD broken second tuner
> intel-ipu3: Kconfig coding style issue
> cec: Kconfig coding style issue
> saa7164: Fix driver name in debug output
>
> Colin Ian King (1):
> media/usbvision: fix spelling mistake: "compresion" -> "compression"
>
> Dan Carpenter (1):
> media: vpbe_venc: potential uninitialized variable in ven_sub_dev_init()
>
> Fengguang Wu (1):
> media: vcodec: fix ptr_ret.cocci warnings
>
> Hans Verkuil (2):
> cec-gpio: use GPIOD_OUT_HIGH_OPEN_DRAIN
> v4l2-dev.h: fix doc warning
>
> Jacopo Mondi (1):
> media: renesas-ceu: Set mbus_fmt on subdev operations
>
> Jan Luebbe (1):
> media: imx-csi: fix burst size for 16 bit
>
> Jasmin Jessich (2):
> media: Use ktime_set() in pt1.c
> media: Revert cleanup ktime_set() usage
>
> Julia Lawall (1):
> pvrusb2: delete unneeded include
>
> Niklas Söderlund (1):
> media: entity: fix spelling for media_entity_get_fwnode_pad()
>
> Philipp Zabel (4):
> media: coda: reuse coda_s_fmt_vid_cap to propagate format in coda_s_fmt_vid_out
> media: coda: do not try to propagate format if capture queue busy
> media: coda: set colorimetry on coded queue
> media: imx: add 16-bit grayscale support
>
> Robin Murphy (1):
> media: videobuf-dma-sg: Fix dma_{sync,unmap}_sg() calls
>
> Sami Tolvanen (1):
> media: media-device: fix ioctl function types
>
> Simon Que (1):
> v4l2-core: Rename array 'video_driver' to 'video_drivers'
>
> Souptick Joarder (1):
> videobuf: Change return type to vm_fault_t
>
> Wolfram Sang (1):
> media: platform: am437x: simplify getting .drvdata
>
> drivers/media/Kconfig | 12 ++++++------
> drivers/media/dvb-core/dmxdev.c | 2 +-
> drivers/media/media-device.c | 21 +++++++++++----------
> drivers/media/pci/cx88/cx88-input.c | 6 ++++--
> drivers/media/pci/intel/ipu3/Kconfig | 12 ++++++------
> drivers/media/pci/pt1/pt1.c | 2 +-
> drivers/media/pci/pt3/pt3.c | 2 +-
> drivers/media/pci/saa7164/saa7164-fw.c | 3 ++-
> drivers/media/pci/sta2x11/sta2x11_vip.c | 31 +++++++++++++++----------------
> drivers/media/platform/am437x/am437x-vpfe.c | 6 ++----
> drivers/media/platform/cec-gpio/cec-gpio.c | 2 +-
> drivers/media/platform/coda/coda-common.c | 45 +++++++++++++++++++++++++++++++--------------
> drivers/media/platform/davinci/vpbe_venc.c | 2 +-
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 5 +----
> drivers/media/platform/renesas-ceu.c | 20 +++++++++++++++-----
> drivers/media/platform/via-camera.c | 2 +-
> drivers/media/usb/em28xx/em28xx-dvb.c | 2 +-
> drivers/media/usb/pvrusb2/pvrusb2-cx2584x-v4l.c | 1 -
> drivers/media/usb/usbvision/usbvision-core.c | 2 +-
> drivers/media/v4l2-core/v4l2-dev.c | 22 +++++++++++-----------
> drivers/media/v4l2-core/videobuf-dma-sg.c | 6 +++---
> drivers/staging/media/imx/imx-media-csi.c | 3 ++-
> drivers/staging/media/imx/imx-media-utils.c | 9 +++++++++
> include/media/media-entity.h | 2 +-
> include/media/v4l2-dev.h | 1 +
> 25 files changed, 128 insertions(+), 93 deletions(-)
Thanks,
Mauro
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL FOR v4.18] v2: Various fixes/improvements
2018-11-22 20:52 ` Mauro Carvalho Chehab
@ 2018-11-22 22:26 ` Hans Verkuil
2018-11-22 22:43 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 4+ messages in thread
From: Hans Verkuil @ 2018-11-22 22:26 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Linux Media Mailing List
On 11/22/2018 09:52 PM, Mauro Carvalho Chehab wrote:
> Em Tue, 8 May 2018 12:48:45 +0200
> Hans Verkuil <hverkuil@xs4all.nl> escreveu:
>
>> Fixes/improvements all over the place.
>>
>> Changes since v1:
>>
>> Replaced "media: media-device: fix ioctl function types" with the v2 version
>> of that patch. My fault, I missed Sakari's request for a change of v1.
>
> You should seriously review how you're adding SOBs... there are
> even some like:
>
> Signed-off-by Hans Verkuil <hans.verkuil>
> Reported-by: syzbot+69780d144754b8071f4b@syzkaller.appspotmail.com
> Cc: <stable@vger.kernel.org> # for v4.20 and up
> Signed-off-by Hans Verkuil <hansverk@cisco.com>
You seem to have replied to a different git pull request (v4.18?!) then
what these lines above indicate, but it appears that this refers to patch
"vim2m: use cancel_delayed_work_sync instead of flush_schedule_work".
It looks like I just completely mistyped the SoB in that patch. Nothing to do
with the xs4all vs cisco SoBs and AFAICS it is an issue just with that patch.
Regarding those, the core problem is that I want to show that what I'm doing is
paid for by Cisco, but I don't want to use the cisco email address to actually
send patches, pull requests, etc., since that requires a vpn which is really annoying.
I've made a new email alias hverkuil-cisco@xs4all.nl (I'm not allowed to use a '+'
unfortunately) and I think I will use that as my git email address to avoid
cisco.com entirely.
Regarding the outstanding pull requests with SoB/Author mismatches: should I redo
those and repost? It's a pain, but if you want it I'll do that tomorrow.
Regards,
Hans
>
> On this series. Again, none matching the Author's email.
>
> PS.: one quick way to fix it is by using git filter.
>
> You could do something like:
>
> $ git filter-branch -f --msg-filter 'cat|grep -v "Signed-off-by: Your Name"; echo "Signed-off-by: Your Name <your.new@email>"' origin/master..
>
> And fix all of them with a single command.
>
>>
>> Regards,
>>
>> Hans
>>
>> The following changes since commit f10379aad39e9da8bc7d1822e251b5f0673067ef:
>>
>> media: include/video/omapfb_dss.h: use IS_ENABLED() (2018-05-05 11:45:51 -0400)
>>
>> are available in the Git repository at:
>>
>> git://linuxtv.org/hverkuil/media_tree.git for-v4.18b
>>
>> for you to fetch changes up to 171d364998d1e2373c12b93924fe63cc71586101:
>>
>> media: media-device: fix ioctl function types (2018-05-08 12:40:23 +0200)
>>
>> ----------------------------------------------------------------
>> Arvind Yadav (2):
>> platform: Use gpio_is_valid()
>> sta2x11: Use gpio_is_valid() and remove unnecessary check
>>
>> Brad Love (4):
>> em28xx: Fix DualHD broken second tuner
>> intel-ipu3: Kconfig coding style issue
>> cec: Kconfig coding style issue
>> saa7164: Fix driver name in debug output
>>
>> Colin Ian King (1):
>> media/usbvision: fix spelling mistake: "compresion" -> "compression"
>>
>> Dan Carpenter (1):
>> media: vpbe_venc: potential uninitialized variable in ven_sub_dev_init()
>>
>> Fengguang Wu (1):
>> media: vcodec: fix ptr_ret.cocci warnings
>>
>> Hans Verkuil (2):
>> cec-gpio: use GPIOD_OUT_HIGH_OPEN_DRAIN
>> v4l2-dev.h: fix doc warning
>>
>> Jacopo Mondi (1):
>> media: renesas-ceu: Set mbus_fmt on subdev operations
>>
>> Jan Luebbe (1):
>> media: imx-csi: fix burst size for 16 bit
>>
>> Jasmin Jessich (2):
>> media: Use ktime_set() in pt1.c
>> media: Revert cleanup ktime_set() usage
>>
>> Julia Lawall (1):
>> pvrusb2: delete unneeded include
>>
>> Niklas Söderlund (1):
>> media: entity: fix spelling for media_entity_get_fwnode_pad()
>>
>> Philipp Zabel (4):
>> media: coda: reuse coda_s_fmt_vid_cap to propagate format in coda_s_fmt_vid_out
>> media: coda: do not try to propagate format if capture queue busy
>> media: coda: set colorimetry on coded queue
>> media: imx: add 16-bit grayscale support
>>
>> Robin Murphy (1):
>> media: videobuf-dma-sg: Fix dma_{sync,unmap}_sg() calls
>>
>> Sami Tolvanen (1):
>> media: media-device: fix ioctl function types
>>
>> Simon Que (1):
>> v4l2-core: Rename array 'video_driver' to 'video_drivers'
>>
>> Souptick Joarder (1):
>> videobuf: Change return type to vm_fault_t
>>
>> Wolfram Sang (1):
>> media: platform: am437x: simplify getting .drvdata
>>
>> drivers/media/Kconfig | 12 ++++++------
>> drivers/media/dvb-core/dmxdev.c | 2 +-
>> drivers/media/media-device.c | 21 +++++++++++----------
>> drivers/media/pci/cx88/cx88-input.c | 6 ++++--
>> drivers/media/pci/intel/ipu3/Kconfig | 12 ++++++------
>> drivers/media/pci/pt1/pt1.c | 2 +-
>> drivers/media/pci/pt3/pt3.c | 2 +-
>> drivers/media/pci/saa7164/saa7164-fw.c | 3 ++-
>> drivers/media/pci/sta2x11/sta2x11_vip.c | 31 +++++++++++++++----------------
>> drivers/media/platform/am437x/am437x-vpfe.c | 6 ++----
>> drivers/media/platform/cec-gpio/cec-gpio.c | 2 +-
>> drivers/media/platform/coda/coda-common.c | 45 +++++++++++++++++++++++++++++++--------------
>> drivers/media/platform/davinci/vpbe_venc.c | 2 +-
>> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 5 +----
>> drivers/media/platform/renesas-ceu.c | 20 +++++++++++++++-----
>> drivers/media/platform/via-camera.c | 2 +-
>> drivers/media/usb/em28xx/em28xx-dvb.c | 2 +-
>> drivers/media/usb/pvrusb2/pvrusb2-cx2584x-v4l.c | 1 -
>> drivers/media/usb/usbvision/usbvision-core.c | 2 +-
>> drivers/media/v4l2-core/v4l2-dev.c | 22 +++++++++++-----------
>> drivers/media/v4l2-core/videobuf-dma-sg.c | 6 +++---
>> drivers/staging/media/imx/imx-media-csi.c | 3 ++-
>> drivers/staging/media/imx/imx-media-utils.c | 9 +++++++++
>> include/media/media-entity.h | 2 +-
>> include/media/v4l2-dev.h | 1 +
>> 25 files changed, 128 insertions(+), 93 deletions(-)
>
>
>
> Thanks,
> Mauro
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL FOR v4.18] v2: Various fixes/improvements
2018-11-22 22:26 ` Hans Verkuil
@ 2018-11-22 22:43 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2018-11-22 22:43 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List
Hi Hans,
Em Thu, 22 Nov 2018 23:26:07 +0100
Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> On 11/22/2018 09:52 PM, Mauro Carvalho Chehab wrote:
> > Em Tue, 8 May 2018 12:48:45 +0200
> > Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> >
> >> Fixes/improvements all over the place.
> >>
> >> Changes since v1:
> >>
> >> Replaced "media: media-device: fix ioctl function types" with the v2 version
> >> of that patch. My fault, I missed Sakari's request for a change of v1.
> >
> > You should seriously review how you're adding SOBs... there are
> > even some like:
> >
> > Signed-off-by Hans Verkuil <hans.verkuil>
> > Reported-by: syzbot+69780d144754b8071f4b@syzkaller.appspotmail.com
> > Cc: <stable@vger.kernel.org> # for v4.20 and up
> > Signed-off-by Hans Verkuil <hansverk@cisco.com>
>
> You seem to have replied to a different git pull request (v4.18?!) then
> what these lines above indicate, but it appears that this refers to patch
> "vim2m: use cancel_delayed_work_sync instead of flush_schedule_work".
>
> It looks like I just completely mistyped the SoB in that patch. Nothing to do
> with the xs4all vs cisco SoBs and AFAICS it is an issue just with that patch.
>
> Regarding those, the core problem is that I want to show that what I'm doing is
> paid for by Cisco, but I don't want to use the cisco email address to actually
> send patches, pull requests, etc., since that requires a vpn which is really annoying.
>
> I've made a new email alias hverkuil-cisco@xs4all.nl (I'm not allowed to use a '+'
> unfortunately) and I think I will use that as my git email address to avoid
> cisco.com entirely.
Yeah, I know the drill. I had to do about the same in order to mark
that my work is sponsored by Samsung.
> Regarding the outstanding pull requests with SoB/Author mismatches: should I redo
> those and repost? It's a pain, but if you want it I'll do that tomorrow.
Yes, please.
If it was just to remove a duplicated SoB from another e-mail (or a typo
outside the e-mail part), I would gladly do when merging (probably using git
filter or something scripteable tooling), but I don't feel comfortable to
replace an e-mail address on commits.
Thanks,
Mauro
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-23 9:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-08 10:48 [GIT PULL FOR v4.18] v2: Various fixes/improvements Hans Verkuil
2018-11-22 20:52 ` Mauro Carvalho Chehab
2018-11-22 22:26 ` Hans Verkuil
2018-11-22 22:43 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).