Linux-Media Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] media: v4l2: Fix fourcc names for BAYER12P
@ 2019-12-03 15:12 Daniel Gomez
  2019-12-04 11:30 ` Sakari Ailus
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Gomez @ 2019-12-03 15:12 UTC (permalink / raw)
  To: unlisted-recipients:; (no To-header on input)
  Cc: daniel, Mauro Carvalho Chehab, linux-media, linux-kernel

Fix documentation fourcc names for the 12-bit packed Bayer formats.

Signed-off-by: Daniel Gomez <daniel@qtec.com>
---
 Documentation/media/uapi/v4l/pixfmt-srggb12p.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/media/uapi/v4l/pixfmt-srggb12p.rst b/Documentation/media/uapi/v4l/pixfmt-srggb12p.rst
index 960851275f23..7060a4ffad08 100644
--- a/Documentation/media/uapi/v4l/pixfmt-srggb12p.rst
+++ b/Documentation/media/uapi/v4l/pixfmt-srggb12p.rst
@@ -13,7 +13,7 @@
 .. _v4l2-pix-fmt-sgrbg12p:
 
 *******************************************************************************************************************************
-V4L2_PIX_FMT_SRGGB12P ('pRAA'), V4L2_PIX_FMT_SGRBG12P ('pgAA'), V4L2_PIX_FMT_SGBRG12P ('pGAA'), V4L2_PIX_FMT_SBGGR12P ('pBAA'),
+V4L2_PIX_FMT_SRGGB12P ('pBCC'), V4L2_PIX_FMT_SGRBG12P ('pgCC'), V4L2_PIX_FMT_SGBRG12P ('pGCC'), V4L2_PIX_FMT_SBGGR12P ('pBCC'),
 *******************************************************************************************************************************
 
 
-- 
2.24.0.rc1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] media: v4l2: Fix fourcc names for BAYER12P
  2019-12-03 15:12 [PATCH] media: v4l2: Fix fourcc names for BAYER12P Daniel Gomez
@ 2019-12-04 11:30 ` Sakari Ailus
  2019-12-05  7:31   ` Daniel Gomez
  0 siblings, 1 reply; 3+ messages in thread
From: Sakari Ailus @ 2019-12-04 11:30 UTC (permalink / raw)
  To: Daniel Gomez; +Cc: Mauro Carvalho Chehab, linux-media, linux-kernel

Hi Daniel,

On Tue, Dec 03, 2019 at 04:12:00PM +0100, Daniel Gomez wrote:
> Fix documentation fourcc names for the 12-bit packed Bayer formats.
> 
> Signed-off-by: Daniel Gomez <daniel@qtec.com>
> ---
>  Documentation/media/uapi/v4l/pixfmt-srggb12p.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/media/uapi/v4l/pixfmt-srggb12p.rst b/Documentation/media/uapi/v4l/pixfmt-srggb12p.rst
> index 960851275f23..7060a4ffad08 100644
> --- a/Documentation/media/uapi/v4l/pixfmt-srggb12p.rst
> +++ b/Documentation/media/uapi/v4l/pixfmt-srggb12p.rst
> @@ -13,7 +13,7 @@
>  .. _v4l2-pix-fmt-sgrbg12p:
>  
>  *******************************************************************************************************************************
> -V4L2_PIX_FMT_SRGGB12P ('pRAA'), V4L2_PIX_FMT_SGRBG12P ('pgAA'), V4L2_PIX_FMT_SGBRG12P ('pGAA'), V4L2_PIX_FMT_SBGGR12P ('pBAA'),
> +V4L2_PIX_FMT_SRGGB12P ('pBCC'), V4L2_PIX_FMT_SGRBG12P ('pgCC'), V4L2_PIX_FMT_SGBRG12P ('pGCC'), V4L2_PIX_FMT_SBGGR12P ('pBCC'),
>  *******************************************************************************************************************************

Thanks for the patch.

There's a bug there, but this doesn't still seem entirely correct. For
instance, V4L2_PIX_FMT_SRGGB12P is defined as follows in videodev2.h:

#define V4L2_PIX_FMT_SRGGB12P v4l2_fourcc('p', 'R', 'C', 'C')

Could you fix that, and check the rest?

Please also set the To: header to a valid value; not setting it sometimes
ends up replies being only sent to the original sender of the patch,
omitting the list and others cc'd.

-- 
Kind regards,

Sakari Ailus

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] media: v4l2: Fix fourcc names for BAYER12P
  2019-12-04 11:30 ` Sakari Ailus
@ 2019-12-05  7:31   ` Daniel Gomez
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Gomez @ 2019-12-05  7:31 UTC (permalink / raw)
  To: Sakari Ailus
  Cc: Mauro Carvalho Chehab, Linux Media Mailing List, linux-kernel

Hi Sakari,

On Wed, 4 Dec 2019 at 12:31, Sakari Ailus <sakari.ailus@iki.fi> wrote:
>
> Hi Daniel,
>
> On Tue, Dec 03, 2019 at 04:12:00PM +0100, Daniel Gomez wrote:
> > Fix documentation fourcc names for the 12-bit packed Bayer formats.
> >
> > Signed-off-by: Daniel Gomez <daniel@qtec.com>
> > ---
> >  Documentation/media/uapi/v4l/pixfmt-srggb12p.rst | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/media/uapi/v4l/pixfmt-srggb12p.rst b/Documentation/media/uapi/v4l/pixfmt-srggb12p.rst
> > index 960851275f23..7060a4ffad08 100644
> > --- a/Documentation/media/uapi/v4l/pixfmt-srggb12p.rst
> > +++ b/Documentation/media/uapi/v4l/pixfmt-srggb12p.rst
> > @@ -13,7 +13,7 @@
> >  .. _v4l2-pix-fmt-sgrbg12p:
> >
> >  *******************************************************************************************************************************
> > -V4L2_PIX_FMT_SRGGB12P ('pRAA'), V4L2_PIX_FMT_SGRBG12P ('pgAA'), V4L2_PIX_FMT_SGBRG12P ('pGAA'), V4L2_PIX_FMT_SBGGR12P ('pBAA'),
> > +V4L2_PIX_FMT_SRGGB12P ('pBCC'), V4L2_PIX_FMT_SGRBG12P ('pgCC'), V4L2_PIX_FMT_SGBRG12P ('pGCC'), V4L2_PIX_FMT_SBGGR12P ('pBCC'),
> >  *******************************************************************************************************************************
>
> Thanks for the patch.
>
> There's a bug there, but this doesn't still seem entirely correct. For
> instance, V4L2_PIX_FMT_SRGGB12P is defined as follows in videodev2.h:
>
> #define V4L2_PIX_FMT_SRGGB12P v4l2_fourcc('p', 'R', 'C', 'C')
>
> Could you fix that, and check the rest?
Thanks for the review.
I'll send a new patch with the proper names:
include/uapi/linux/videodev2.h:#define V4L2_PIX_FMT_SBGGR12P
v4l2_fourcc('p', 'B', 'C', 'C')
include/uapi/linux/videodev2.h:#define V4L2_PIX_FMT_SGBRG12P
v4l2_fourcc('p', 'G', 'C', 'C')
include/uapi/linux/videodev2.h:#define V4L2_PIX_FMT_SGRBG12P
v4l2_fourcc('p', 'g', 'C', 'C')
include/uapi/linux/videodev2.h:#define V4L2_PIX_FMT_SRGGB12P
v4l2_fourcc('p', 'R', 'C', 'C')
>
> Please also set the To: header to a valid value; not setting it sometimes
> ends up replies being only sent to the original sender of the patch,
> omitting the list and others cc'd.
>
okay.
> --
> Kind regards,
>
> Sakari Ailus

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-03 15:12 [PATCH] media: v4l2: Fix fourcc names for BAYER12P Daniel Gomez
2019-12-04 11:30 ` Sakari Ailus
2019-12-05  7:31   ` Daniel Gomez

Linux-Media Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-media/0 linux-media/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-media linux-media/ https://lore.kernel.org/linux-media \
		linux-media@vger.kernel.org
	public-inbox-index linux-media

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-media


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git