Re: [GIT PULL] Ressurect the atomisp staging driver

From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Francescodario Cuzzocrea 
	<francescodario.cuzzocrea@mail.polimi.it>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Patrik Gfeller <patrik.gfeller@gmail.com>
Cc: "mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [GIT PULL] Ressurect the atomisp staging driver
Date: Sun, 3 May 2020 17:32:13 +0200	[thread overview]
Message-ID: <20200503173213.78ae6aaa@coco.lan> (raw)
In-Reply-To: <3f551a8f87808ee7828dc03d41c7a23faac89f3c.camel@mail.polimi.it>

Em Sun, 3 May 2020 09:19:55 +0000
Francescodario Cuzzocrea <francescodario.cuzzocrea@mail.polimi.it> escreveu:

> I have a bay trail 2in1 (namely, the acer aspire swtich 10 sw5-012,
> with an OV2722 module, so supported by the driver) on top of which I
> run android-x86-q so I would be able to help a bit with testing the
> driver.
> 
> I tried to pull in your changes on top of my 5.7-rc2 here : 
> https://gitlab.com/lineageos-x86/android_kernel_common/-/commits/5.7-media
> 
> but I did not understood how to correctly enable the driver.
> According
> to Kconfig help, there is still the hardcoded switch between ISP2401
> and ISP2400, so for my Bay Trail tablet I should set :
> 
> #
> CONFIG_VIDEO_ATOMISP_ISP2401 is not set
> 
> but settings this breaks compilation with : 
> 
> ERROR: modpost:
> "ia_css_configure_sc"[drivers/staging/media/atomisp/atomisp.ko]
> undefined!

Fixed. you need to run:

	$ git remote update && git reset --hard atomisp_v2

in order to get the latest patch.

Btw, I added another branch on my experimental tree:

	https://git.linuxtv.org/mchehab/experimental.git/log/?h=yocto_intel_atom

It is based on Kernel 4.4, and it has only those patches from
the https://github.com/intel-aero/meta-intel-aero.git tree for ISP2401,
as available at changeset 4ebb7cc829f5 
(Merge pull request #70 from zehortigoza/jam):

	$ git grep -l atomisp
	recipes-kernel/linux/linux-yocto/0013-temp-atomisp-support.patch
	recipes-kernel/linux/linux-yocto/0014-OV8858-add-sensor-sources-to-cloudsrest-platform.patch
	recipes-kernel/linux/linux-yocto/0015-kernel-Adding-support-for-HW-flip-using-AtomISP.patch
	recipes-kernel/linux/linux-yocto/0016-kernel-bug-fix-for-intermittent-green-patches.patch
	recipes-kernel/linux/linux-yocto/0022-ov8858-fix-regulator-management-on-ov8858_s_ctrl.patch
	recipes-kernel/linux/linux-yocto/0023-ov7251-remove-early-return-statement.patch

It would be cool to have it tested on boards with ISP2401. If this works,
then we'll have a reference implementation to check against our tree.

https://github.com/intel-aero/meta-intel-aero/blob/4ebb7cc829f57306b9895f20af8fd17987089392/recipes-kernel/linux/linux-yocto/shisp_2401a0_v21.bin

That said, there are some *.cfg files with stuff that should be at the
Kernel's .config, like this one:

https://github.com/intel-aero/meta-intel-aero/blob/4ebb7cc829f57306b9895f20af8fd17987089392/recipes-kernel/linux/linux-yocto/regulator.cfg

Thanks,
Mauro