From: Patrik Gfeller <patrik.gfeller@gmail.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Francescodario Cuzzocrea
<francescodario.cuzzocrea@mail.polimi.it>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
"mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [GIT PULL] Ressurect the atomisp staging driver
Date: Mon, 4 May 2020 15:44:20 +0200 [thread overview]
Message-ID: <20200504154420.5dcf505f@ASUS> (raw)
In-Reply-To: <20200504140833.11dd5622@coco.lan>
On Mon, 4 May 2020 14:08:33 +0200
Mauro Carvalho Chehab <mchehab@kernel.org> wrote:
> Em Mon, 4 May 2020 12:45:39 +0200
> Patrik Gfeller <patrik.gfeller@gmail.com> escreveu:
>
> > On Mon, 4 May 2020 10:49:34 +0200
> > Mauro Carvalho Chehab <mchehab@kernel.org> wrote:
> >
> [...]
> [...]
> [...]
> [...]
> [...]
> [...]
> [...]
> [...]
> >
> > There are still errors when I try to build. I've found code like the
> > one below:
> >
> > const struct v4l2_ioctl_ops atomisp_ioctl_ops = {
> > .vidioc_querycap = atomisp_querycap,
> > #ifndef CONFIG_INTEL_MID_ISP
> > .vidioc_g_chip_ident = atomisp_g_chip_ident,
> > #endif
> > .vidioc_enum_input = atomisp_enum_input,
> >
> > Therefore I've tried with "CONFIG_INTEL_MID_ISP=y". Not sure if this is
> > a good idea function wise - but it compiles.
>
> Yes, that's it. You also need:
>
> CONFIG_REGULATOR_WHISKEY_COVE=y
>
> and maybe some other stuff. Take a look at the Yocto's *.cfg files I pointed
> with the options (see enclosed).
>
>
>
> > But the last step of the
> > module build produces some scary warnings:
> >
> > WARNING: "cpu_tss" [drivers/media/pci/atomisp//css2401a0_v21_build/atomisp-css2401a0_v21.ko] undefined!
> > WARNING: "pv_lock_ops" [drivers/media/pci/atomisp//css2401a0_v21_build/atomisp-css2401a0_v21.ko] undefined!
> > WARNING: "__alloc_workqueue_key" [drivers/media/pci/atomisp//css2401a0_v21_build/atomisp-css2401a0_v21.ko] undefined!
> > WARNING: "v4l2_subdev_querymenu" [drivers/media/pci/atomisp//css2401a0_v21_build/atomisp-css2401a0_v21.ko] undefined!
> > WARNING: "intel_mid_msgbus_write32" [drivers/media/pci/atomisp//css2401a0_v21_build/atomisp-css2401a0_v21.ko] undefined!
> > ...
> >
> > Maybe this is related to my partial build (only the module to test if
> > it builds). I'll now do a full build of the kernel.
>
> Yeah, either that or there are some config options with different values.
>
> I was able to do a full build here without the above errors, although
> I had to turn of some CONFIG options that were otherwise failing.
Strange - I do not get it :-/ ... can you send me the .config file and
Makefile you use; probably I missed something.
>
>
> Thanks,
> Mauro
>
> ~/meta-intel-aero/recipes-kernel/linux/linux-yocto $ cat *.cfg
> CONFIG_USB_ACM=y
> CONFIG_USB_WDM=y
> CONFIG_USB_USBNET=y
> CONFIG_USB_NET_CDC_MBIM=y
> CONFIG_MEDIA_PCI_SUPPORT=y
>
> CONFIG_VIDEO_DEV=y
> CONFIG_MEDIA_SUPPORT=y
> CONFIG_VIDEO_V4L2=y
> CONFIG_INTEL_MID_ISP=y
> CONFIG_VIDEO_ATOMISP=m
> CONFIG_VIDEO_OV7251=y
> CONFIG_VIDEO_OV8858=y
> CONFIG_I2C_CHARDEV=y
> CONFIG_GPIO_SYSFS=y
> CONFIG_DYNAMIC_DEBUG=y
> CONFIG_PRINTK_TIME=y
> CONFIG_DMADEVICES=y
> CONFIG_DW_DMAC_CORE=y
> CONFIG_DW_DMAC=y
> # DRONE CODE CONFIG
> CONFIG_HAVE_INTEL_TXT=y
> CONFIG_MMU_NOTIFIER=y
> CONFIG_PCI_ATS=y
> CONFIG_PCI_PASID=y
>
> CONFIG_VFIO_IOMMU_TYPE1=y
> CONFIG_VFIO_VIRQFD=y
> CONFIG_VFIO=y
> CONFIG_VFIO_PCI=y
> CONFIG_VFIO_PCI_MMAP=y
> CONFIG_VFIO_PCI_INTX=y
> CONFIG_IRQ_BYPASS_MANAGER=y
>
> CONFIG_IOMMU_API=y
> CONFIG_IOMMU_IOVA=y
> CONFIG_DMAR_TABLE=y
> CONFIG_INTEL_IOMMU=y
> CONFIG_INTEL_IOMMU_SVM=y
> CONFIG_INTEL_IOMMU_DEFAULT_ON=y
> CONFIG_INTEL_IOMMU_FLOPPY_WA=y
>
> CONFIG_X86_INTEL_LPSS=y
> CONFIG_I2C_DESIGNWARE_CORE=y
> CONFIG_I2C_DESIGNWARE_PCI=y
> CONFIG_I2C_DESIGNWARE_PLATFORM=y
> CONFIG_SERIAL_8250_DW=y
> CONFIG_MMC=y
> CONFIG_MMC_SDHCI=y
> CONFIG_MMC_SDHCI_ACPI=y
> CONFIG_NF_NAT_FTP=y
> CONFIG_NF_NAT_IPV4=y
> CONFIG_NF_NAT_IRC=y
> CONFIG_NF_NAT_NEEDED=y
> CONFIG_NF_NAT_SIP=y
> CONFIG_IP_NF_NAT=y
> CONFIG_GPIOLIB=y
> CONFIG_DEBUG_PINCTRL=y
> CONFIG_PINCTRL_CHERRYVIEW=y
>
> #GPIO Keys
> CONFIG_KEYBOARD_GPIO=y
> CONFIG_INPUT_MISC=y
> CONFIG_INPUT_SOC_BUTTON_ARRAY=y
> CONFIG_REGULATOR=y
> CONFIG_REGULATOR_DEBUG=y
> CONFIG_REGULATOR_FIXED_VOLTAGE=y
> CONFIG_REGULATOR_GPIO=y
> CONFIG_REGULATOR_WHISKEY_COVE=y
> CONFIG_INTEL_SOC_DTS_THERMAL=y
> CONFIG_SPI=y
> CONFIG_SPI_MASTER=y
> CONFIG_SPI_SPIDEV=y
> CONFIG_SPI_PXA2XX=y
> CONFIG_SPI_PXA2XX_DMA=y
> CONFIG_SPI_PXA2XX_PCI=y
> CONFIG_USB_ETH=y
> CONFIG_USB_GADGET=y
> CONFIG_USB_DWC3=y
> CONFIG_USB_DWC3_PCI=y
> CONFIG_USB_DWC3_GADGET=y
> CONFIG_USB_OTG=y
> CONFIG_USB_OTG_FSM=y
> CONFIG_INTEL_CHT_PHY=y
> CONFIG_NOP_USB_XCEIV=y
> CONFIG_IIO=y
> CONFIG_INTEL_SOC_PMIC=y
> CONFIG_ITCO_WDT=y
> # CONFIG_ITCO_VENDOR_SUPPORT is not set
> CONFIG_LPC_ICH=y
>
with kind regards,
Patrik
next prev parent reply other threads:[~2020-05-04 13:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 19:57 [GIT PULL] Ressurect the atomisp staging driver Mauro Carvalho Chehab
2020-05-02 6:03 ` Greg KH
2020-05-20 7:48 ` Mauro Carvalho Chehab
2020-05-03 9:19 ` Francescodario Cuzzocrea
2020-05-03 10:07 ` Mauro Carvalho Chehab
2020-05-03 15:32 ` Mauro Carvalho Chehab
[not found] ` <CADnVkj96W0QfthukTKQ0a-i2fH1buooH3BEgfy22J9H9=_PcKA@mail.gmail.com>
2020-05-03 16:07 ` Patrik Gfeller
2020-05-04 8:16 ` Patrik Gfeller
2020-05-04 8:49 ` Mauro Carvalho Chehab
2020-05-04 10:45 ` Patrik Gfeller
2020-05-04 12:08 ` Mauro Carvalho Chehab
2020-05-04 13:44 ` Patrik Gfeller [this message]
2020-05-15 8:32 ` Mauro Carvalho Chehab
2020-05-15 9:10 ` Hans de Goede
2020-05-15 9:42 ` Mauro Carvalho Chehab
2020-05-19 7:39 ` Mauro Carvalho Chehab
2020-05-19 17:36 ` Mauro Carvalho Chehab
2020-05-22 10:46 ` Hans de Goede
2020-05-22 11:42 ` Mauro Carvalho Chehab
2020-05-23 8:00 ` Mauro Carvalho Chehab
2020-05-27 16:23 ` Hans de Goede
2020-05-27 17:36 ` Mauro Carvalho Chehab
2020-05-15 9:37 ` Ressurect the atomisp staging driver - current progress Mauro Carvalho Chehab
2020-05-06 15:10 ` [GIT PULL] Ressurect the atomisp staging driver Mauro Carvalho Chehab
2020-05-03 9:23 ` bosconovic
2020-05-16 13:23 [GIT,PULL] " Finn Rayment
[not found] ` <20200516115459.4a24063b@coco.lan>
2020-05-16 19:53 ` Finn Rayment
2020-05-19 17:37 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504154420.5dcf505f@ASUS \
--to=patrik.gfeller@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=francescodario.cuzzocrea@mail.polimi.it \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).