From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] staging: media: atomisp: pci: Change line break to avoid an open parenthesis at the end of the line
Date: Fri, 16 Apr 2021 11:37:28 +0300 [thread overview]
Message-ID: <20210416083728.GL3@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20210416054941.GF6021@kadam>
Hi Dan,
On Fri, Apr 16, 2021 at 08:49:41AM +0300, Dan Carpenter wrote:
> On Fri, Apr 16, 2021 at 12:21:58AM +0300, Sakari Ailus wrote:
> > On Thu, Apr 15, 2021 at 08:59:41PM +0100, Matthew Wilcox wrote:
> > > On Thu, Apr 15, 2021 at 08:57:04PM +0100, Matthew Wilcox wrote:
> > > > On Thu, Apr 15, 2021 at 10:49:55PM +0300, Sakari Ailus wrote:
> > > > > On Thu, Apr 15, 2021 at 06:14:09PM +0100, Matthew Wilcox wrote:
> > > > > > On Thu, Apr 15, 2021 at 02:08:19PM -0300, Aline Santana Cordeiro wrote:
> > > > > > > -const struct atomisp_format_bridge *get_atomisp_format_bridge_from_mbus(
> > > > > > > - u32 mbus_code);
> > > > > > > +const struct atomisp_format_bridge*
> > > > > > > +get_atomisp_format_bridge_from_mbus(u32 mbus_code);
> > > > > >
> > > > > > No, this does not match coding style. Probably best to break the
> > > > > > 80-column guideline in this instance. Best would be to have a function
> > > > >
> > > > > Having the return type on the previous line is perfectly fine. There should
> > > > > be a space before the asterisk though.
> > > >
> > > > No, it's not. Linus has ranted about that before.
> > >
> > > Found it. https://lore.kernel.org/lkml/1054519757.161606@palladium.transmeta.com/
> >
> > Two decades ago, really?
> >
> > This is simply one of the practical means how you split long function
> > declarations and avoid overly long lines. Not my favourite though, but
> > still better than those long lines.
>
> I've always thought we allow either style, but it has to be done
> consistently within the file. I was pretty sure that was policy but
> it's another thing that goes back decades so I don't have a reference.
> It shouldn't be about breaking up long lines.
>
> >
> > My personal preference would be to wrap at the opening parenthesis and
> > indent by just a tab, but I know many people who disagree with that...
>
> If you're running into the 80 character limit, then it's fine to use
> two tabs. I think we have been rejecting patches that push align the
> parameters but push past the 80 character limit. Using one tab is
> confusing because it makes the decalarations line up with the code.
Interesting. Do you have an example of this? I've thought checkpatch.pl
gave a warning if the line ended with an opening parenthesis no matter
what.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2021-04-16 8:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 17:08 [PATCH v2] staging: media: atomisp: pci: Change line break to avoid an open parenthesis at the end of the line Aline Santana Cordeiro
2021-04-15 17:14 ` [Outreachy kernel] " Matthew Wilcox
2021-04-15 18:09 ` ascordeiro
2021-04-15 19:49 ` Sakari Ailus
2021-04-15 19:57 ` Matthew Wilcox
2021-04-15 19:59 ` Matthew Wilcox
2021-04-15 21:21 ` Sakari Ailus
2021-04-16 5:49 ` Dan Carpenter
2021-04-16 8:37 ` Sakari Ailus [this message]
2021-04-16 8:46 ` Julia Lawall
2021-04-16 8:54 ` Sakari Ailus
2021-04-16 9:03 ` Julia Lawall
2021-04-16 9:13 ` Dan Carpenter
2021-04-20 12:41 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416083728.GL3@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=alinesantanacordeiro@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).