From: ascordeiro <alinesantanacordeiro@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] staging: media: atomisp: pci: Change line break to avoid an open parenthesis at the end of the line
Date: Thu, 15 Apr 2021 15:09:54 -0300 [thread overview]
Message-ID: <74c59fd225b7b107662ce045086cdd8560e3e08f.camel@gmail.com> (raw)
In-Reply-To: <20210415171409.GC2531743@casper.infradead.org>
Em qui, 2021-04-15 às 18:14 +0100, Matthew Wilcox escreveu:
> On Thu, Apr 15, 2021 at 02:08:19PM -0300, Aline Santana Cordeiro
> wrote:
> > -const struct atomisp_format_bridge
> > *get_atomisp_format_bridge_from_mbus(
> > - u32 mbus_code);
> > +const struct atomisp_format_bridge*
> > +get_atomisp_format_bridge_from_mbus(u32 mbus_code);
>
> No, this does not match coding style. Probably best to break the
> 80-column guideline in this instance. Best would be to have a
> function
> and/or struct name that isn't so ridiculously long, but that would
> require some in-depth thinking.
>
I left the type of function and its name with the parameters in
different lines, following up some examples of other files, such as
atomisp_acc.c.
But I didn't pay attention and left the pointer with the function name
instead of left it with the type of the function in v1, so Hans
suggested it to a v2, as I did.
What should I do in this case?
Thank you in advance,
Aline
> > -void atomisp_apply_css_parameters(
> > - struct atomisp_sub_device *asd,
> > - struct atomisp_css_params *css_param);
> > +void atomisp_apply_css_parameters(struct atomisp_sub_device *asd,
> > + struct atomisp_css_params
> > *css_param);
> > +
>
> Good.
>
next prev parent reply other threads:[~2021-04-15 18:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 17:08 [PATCH v2] staging: media: atomisp: pci: Change line break to avoid an open parenthesis at the end of the line Aline Santana Cordeiro
2021-04-15 17:14 ` [Outreachy kernel] " Matthew Wilcox
2021-04-15 18:09 ` ascordeiro [this message]
2021-04-15 19:49 ` Sakari Ailus
2021-04-15 19:57 ` Matthew Wilcox
2021-04-15 19:59 ` Matthew Wilcox
2021-04-15 21:21 ` Sakari Ailus
2021-04-16 5:49 ` Dan Carpenter
2021-04-16 8:37 ` Sakari Ailus
2021-04-16 8:46 ` Julia Lawall
2021-04-16 8:54 ` Sakari Ailus
2021-04-16 9:03 ` Julia Lawall
2021-04-16 9:13 ` Dan Carpenter
2021-04-20 12:41 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74c59fd225b7b107662ce045086cdd8560e3e08f.camel@gmail.com \
--to=alinesantanacordeiro@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=sakari.ailus@linux.intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).