linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: kieran.bingham+renesas@ideasonboard.com,
	Ricardo Ribalda <ribalda@chromium.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mikhail Ulyanov <mikhail.ulyanov@cogentembedded.com>
Subject: Re: [PATCH 5/9] media: jpu: Do not zero reserved fields
Date: Thu, 21 Jan 2021 10:53:39 +0100	[thread overview]
Message-ID: <63e16013-43f7-0ad5-76d1-a4d10c666382@xs4all.nl> (raw)
In-Reply-To: <faacd5b3-949e-54bd-0ab8-bd43100809b0@ideasonboard.com>

On 12/01/2021 12:07, Kieran Bingham wrote:
> Hi Ricardo,
> 
> On 11/01/2021 14:54, Ricardo Ribalda wrote:
>> Core code already clears reserved fields of struct
>> v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero
>> v4l2_plane_pix_format reserved fields").
>>
>> Cc: Mikhail Ulyanov <mikhail.ulyanov@cogentembedded.com>
>> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
>> ---
>>  drivers/media/platform/rcar_jpu.c | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/media/platform/rcar_jpu.c b/drivers/media/platform/rcar_jpu.c
>> index 9b99ff368698..2bddc957cb87 100644
>> --- a/drivers/media/platform/rcar_jpu.c
>> +++ b/drivers/media/platform/rcar_jpu.c
> 
> There's a memset(cap->reserved...) in jpu_querycap()
> 
> Is that also applicable and covered by the core?

Yes: VIDIOC_QUERYCAP is a read-only ioctl: the core will always zero
the struct in that case before handing it over to the driver.

This is something for a separate patch, though. There may well be
more drivers that do this for querycap.

Regards,

	Hans

> 
> Looking at v4l_querycap() it doesn't seem to be so:
> 
> 
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> 
>> @@ -793,7 +793,6 @@ static int __jpu_try_fmt(struct jpu_ctx *ctx, struct jpu_fmt **fmtinfo,
>>  	pix->colorspace = fmt->colorspace;
>>  	pix->field = V4L2_FIELD_NONE;
>>  	pix->num_planes = fmt->num_planes;
>> -	memset(pix->reserved, 0, sizeof(pix->reserved));
>>  
>>  	jpu_bound_align_image(&pix->width, JPU_WIDTH_MIN, JPU_WIDTH_MAX,
>>  			      fmt->h_align, &pix->height, JPU_HEIGHT_MIN,
>> @@ -808,8 +807,6 @@ static int __jpu_try_fmt(struct jpu_ctx *ctx, struct jpu_fmt **fmtinfo,
>>  			pix->plane_fmt[0].sizeimage = JPU_JPEG_HDR_SIZE +
>>  				(JPU_JPEG_MAX_BYTES_PER_PIXEL * w * h);
>>  		pix->plane_fmt[0].bytesperline = 0;
>> -		memset(pix->plane_fmt[0].reserved, 0,
>> -		       sizeof(pix->plane_fmt[0].reserved));
>>  	} else {
>>  		unsigned int i, bpl = 0;
>>  
>> @@ -822,8 +819,6 @@ static int __jpu_try_fmt(struct jpu_ctx *ctx, struct jpu_fmt **fmtinfo,
>>  		for (i = 0; i < pix->num_planes; ++i) {
>>  			pix->plane_fmt[i].bytesperline = bpl;
>>  			pix->plane_fmt[i].sizeimage = bpl * h * fmt->bpp[i] / 8;
>> -			memset(pix->plane_fmt[i].reserved, 0,
>> -			       sizeof(pix->plane_fmt[i].reserved));
>>  		}
>>  	}
>>  
>>
> 


  reply	other threads:[~2021-01-21 10:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 14:54 [PATCH 1/9] media: ipu3-cio2: Do not zero reserved fields Ricardo Ribalda
2021-01-11 14:54 ` [PATCH] media: staging/intel-ipu3 : " Ricardo Ribalda
2021-01-12 11:59   ` Kieran Bingham
2021-01-12 12:14     ` Ricardo Ribalda
2021-01-11 14:54 ` [PATCH 2/9] media: mtk-mdp: " Ricardo Ribalda
2021-01-12 12:01   ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 3/9] media: mtk-vcodec: " Ricardo Ribalda
2021-01-12 12:09   ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 4/9] media: fdp1: " Ricardo Ribalda
2021-01-12 10:58   ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 5/9] media: jpu: " Ricardo Ribalda
2021-01-12 11:07   ` Kieran Bingham
2021-01-21  9:53     ` Hans Verkuil [this message]
2021-01-11 14:54 ` [PATCH 6/9] media: sum4i-csi: " Ricardo Ribalda
2021-01-11 18:11   ` Ezequiel Garcia
2021-01-12 11:10   ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 7/9] media: ti-vpe: " Ricardo Ribalda
2021-01-12 11:12   ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 8/9] media: vicodec: " Ricardo Ribalda
2021-01-12 11:44   ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 9/9] media: staging/intel-ipu3 : " Ricardo Ribalda
2021-01-12 11:55   ` Kieran Bingham
2021-01-12 11:58 ` [PATCH 1/9] media: ipu3-cio2: " Kieran Bingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63e16013-43f7-0ad5-76d1-a4d10c666382@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mikhail.ulyanov@cogentembedded.com \
    --cc=ribalda@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).