From: Helen Koike <helen.koike@collabora.com>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
linux-media@vger.kernel.org, ezequiel@collabora.com,
hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com,
sakari.ailus@linux.intel.com, linux-rockchip@lists.infradead.org,
mchehab@kernel.org, laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 4/4] media: staging: rkisp1: cap: remove unsupported formats
Date: Mon, 30 Mar 2020 16:20:44 -0300 [thread overview]
Message-ID: <83fc8d9c-16a0-a381-f5b8-5da642d79f5c@collabora.com> (raw)
In-Reply-To: <20200326201610.31762-5-dafna.hirschfeld@collabora.com>
On 3/26/20 5:16 PM, Dafna Hirschfeld wrote:
> For Ycbcr packed formats only YUYV can be supported by
> the driver. This patch removes the other formats.
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Acked-by: Helen Koike <helen.koike@collabora.com>
> ---
> drivers/staging/media/rkisp1/rkisp1-capture.c | 21 -------------------
> 1 file changed, 21 deletions(-)
>
> diff --git a/drivers/staging/media/rkisp1/rkisp1-capture.c b/drivers/staging/media/rkisp1/rkisp1-capture.c
> index 2d274e8f565b..076335193f40 100644
> --- a/drivers/staging/media/rkisp1/rkisp1-capture.c
> +++ b/drivers/staging/media/rkisp1/rkisp1-capture.c
> @@ -98,15 +98,6 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_mp_fmts[] = {
> .fmt_type = RKISP1_FMT_YUV,
> .uv_swap = 0,
> .write_format = RKISP1_MI_CTRL_MP_WRITE_YUVINT,
> - }, {
> - .fourcc = V4L2_PIX_FMT_YVYU,
> - .fmt_type = RKISP1_FMT_YUV,
> - .uv_swap = 1,
> - .write_format = RKISP1_MI_CTRL_MP_WRITE_YUVINT,
> - }, {
> - .fourcc = V4L2_PIX_FMT_VYUY,
> - .fmt_type = RKISP1_FMT_YUV,
> - .write_format = RKISP1_MI_CTRL_MP_WRITE_YUVINT,
> }, {
> .fourcc = V4L2_PIX_FMT_YUV422P,
> .fmt_type = RKISP1_FMT_YUV,
> @@ -234,18 +225,6 @@ static const struct rkisp1_capture_fmt_cfg rkisp1_sp_fmts[] = {
> .uv_swap = 0,
> .write_format = RKISP1_MI_CTRL_SP_WRITE_INT,
> .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV422,
> - }, {
> - .fourcc = V4L2_PIX_FMT_YVYU,
> - .fmt_type = RKISP1_FMT_YUV,
> - .uv_swap = 1,
> - .write_format = RKISP1_MI_CTRL_SP_WRITE_INT,
> - .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV422,
> - }, {
> - .fourcc = V4L2_PIX_FMT_VYUY,
> - .fmt_type = RKISP1_FMT_YUV,
> - .uv_swap = 1,
> - .write_format = RKISP1_MI_CTRL_SP_WRITE_INT,
> - .output_format = RKISP1_MI_CTRL_SP_OUTPUT_YUV422,
> }, {
> .fourcc = V4L2_PIX_FMT_YUV422P,
> .fmt_type = RKISP1_FMT_YUV,
>
prev parent reply other threads:[~2020-03-30 19:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 20:16 [PATCH 0/4] media: staging: rkisp1: cap: various fixes for capture formats Dafna Hirschfeld
2020-03-26 20:16 ` [PATCH 1/4] media: staging: rkisp1: cap: fix issues when writing to uv swap register Dafna Hirschfeld
2020-03-30 19:11 ` Helen Koike
2020-03-26 20:16 ` [PATCH 2/4] media: staging: rkisp1: cap: support uv swap only for semiplanar formats Dafna Hirschfeld
2020-03-30 19:12 ` Helen Koike
2020-03-26 20:16 ` [PATCH 3/4] media: staging: rkisp1: cap: support uv swapped plane formats Dafna Hirschfeld
2020-03-30 19:13 ` Helen Koike
2020-03-26 20:16 ` [PATCH 4/4] media: staging: rkisp1: cap: remove unsupported formats Dafna Hirschfeld
2020-03-30 19:20 ` Helen Koike [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fc8d9c-16a0-a381-f5b8-5da642d79f5c@collabora.com \
--to=helen.koike@collabora.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=ezequiel@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).