From: Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com> To: CK Hu <ck.hu@mediatek.com> Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com, Jassi Brar <jassisinghbrar@gmail.com>, linux-kernel@vger.kernel.org, Houlong Wei <houlong.wei@mediatek.com>, Rob Herring <robh+dt@kernel.org>, linux-mediatek@lists.infradead.org, Bibby Hsieh <bibby.hsieh@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 13/14] soc: mediatek: cmdq: add wait no clear event function Date: Thu, 12 Dec 2019 09:42:55 +0800 Message-ID: <1576114975.17653.16.camel@mtkswgap22> (raw) In-Reply-To: <1576029887.19653.17.camel@mtksdaap41> On Wed, 2019-12-11 at 10:04 +0800, CK Hu wrote: > Hi, Dennis: > > On Wed, 2019-11-27 at 09:58 +0800, Dennis YC Hsieh wrote: > > Add wait no clear event function in cmdq helper functions to wait specific > > event without clear to 0 after receive it. > > > > Signed-off-by: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com> > > --- > > drivers/soc/mediatek/mtk-cmdq-helper.c | 15 +++++++++++++++ > > include/linux/soc/mediatek/mtk-cmdq.h | 10 ++++++++++ > > 2 files changed, 25 insertions(+) > > > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > > index 10a9b4481e58..6f270fadfb50 100644 > > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > > @@ -330,6 +330,21 @@ int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u16 event) > > } > > EXPORT_SYMBOL(cmdq_pkt_wfe); > > > > +int cmdq_pkt_wait_no_clear(struct cmdq_pkt *pkt, u16 event) > > +{ > > + struct cmdq_instruction inst = { {0} }; > > + > > + if (event >= CMDQ_MAX_EVENT) > > + return -EINVAL; > > + > > + inst.op = CMDQ_CODE_WFE; > > + inst.value = CMDQ_WFE_WAIT | CMDQ_WFE_WAIT_VALUE; > > + inst.event = event; > > + > > + return cmdq_pkt_append_command(pkt, inst); > > +} > > +EXPORT_SYMBOL(cmdq_pkt_wait_no_clear); > > So the wait command has two version, one is wait and then clear event, > another is wait and not clear event. The name of cmdq_pkt_wfe() is 'wait > for event', so it's trivial that we think it does not clear event. I've > three suggestion for this: > > 1. Let cmdq_pkt_wfe() wait and not clear event, and > cmdq_pkt_wfe_clear_event() wait and clear event. > > or > 2. Let cmdq_pkt_wfe() has a parameter to indicate that clear event or > not after wait. > > or > 3. Let cmdq_pkt_wfe() wait and not clear event, and not provide wait and > clear event version. For DRM and MDP, I think both just need wait and > not clear event. > > Regards, > CK > ok, I will change cmdq_pkt_wfe wait and not clear, and expose another cmdq_pkt_wfe_clear_event() api Regards, Dennis > > > + > > int cmdq_pkt_clear_event(struct cmdq_pkt *pkt, u16 event) > > { > > struct cmdq_instruction inst = { {0} }; > > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > > index d15d8c941992..40bc61ad8d31 100644 > > --- a/include/linux/soc/mediatek/mtk-cmdq.h > > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > > @@ -149,6 +149,16 @@ int cmdq_pkt_write_s_value(struct cmdq_pkt *pkt, dma_addr_t addr, > > */ > > int cmdq_pkt_wfe(struct cmdq_pkt *pkt, u16 event); > > > > +/** > > + * cmdq_pkt_wait_no_clear() - Append wait for event command to the CMDQ packet, > > + * without update event to 0 after receive it. > > + * @pkt: the CMDQ packet > > + * @event: the desired event type to wait > > + * > > + * Return: 0 for success; else the error code is returned > > + */ > > +int cmdq_pkt_wait_no_clear(struct cmdq_pkt *pkt, u16 event); > > + > > /** > > * cmdq_pkt_clear_event() - append clear event command to the CMDQ packet > > * @pkt: the CMDQ packet > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply index Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-27 1:58 [PATCH v2] support gce on mt6779 platform Dennis YC Hsieh 2019-11-27 1:58 ` [PATCH v2 00/14] " Dennis YC Hsieh 2019-11-27 1:58 ` [PATCH v2 01/14] dt-binding: gce: add gce header file for mt6779 Dennis YC Hsieh 2019-12-05 20:37 ` Rob Herring 2019-11-27 1:58 ` [PATCH v2 02/14] mailbox: cmdq: variablize address shift in platform Dennis YC Hsieh 2019-12-10 1:55 ` CK Hu 2019-12-12 1:03 ` Dennis-YC Hsieh 2019-11-27 1:58 ` [PATCH v2 03/14] mailbox: cmdq: support mt6779 gce platform definition Dennis YC Hsieh 2019-12-10 2:04 ` CK Hu 2019-11-27 1:58 ` [PATCH v2 04/14] mailbox: mediatek: cmdq: clear task in channel before shutdown Dennis YC Hsieh 2019-12-10 2:49 ` CK Hu 2019-12-12 1:13 ` Dennis-YC Hsieh 2019-12-12 1:31 ` CK Hu 2019-12-12 1:51 ` Dennis-YC Hsieh 2019-12-12 2:03 ` CK Hu 2019-12-12 2:20 ` Dennis-YC Hsieh 2019-11-27 1:58 ` [PATCH v2 05/14] arm64: dts: add gce node for mt6779 Dennis YC Hsieh 2019-12-06 4:05 ` Bibby Hsieh 2019-11-27 1:58 ` [PATCH v2 06/14] soc: mediatek: cmdq: return send msg error code Dennis YC Hsieh 2019-12-06 4:02 ` Bibby Hsieh 2019-12-18 8:00 ` Dennis-YC Hsieh 2019-12-18 8:14 ` Bibby Hsieh 2019-11-27 1:58 ` [PATCH v2 07/14] soc: mediatek: cmdq: add assign function Dennis YC Hsieh 2019-12-10 3:24 ` CK Hu 2019-12-12 1:15 ` Dennis-YC Hsieh 2019-11-27 1:58 ` [PATCH v2 08/14] soc: mediatek: cmdq: add write_s function Dennis YC Hsieh 2019-12-10 5:18 ` CK Hu 2019-12-12 1:31 ` Dennis-YC Hsieh 2019-12-10 7:35 ` Bibby Hsieh 2019-12-12 1:31 ` Dennis-YC Hsieh 2019-11-27 1:58 ` [PATCH v2 09/14] soc: mediatek: cmdq: add read_s function Dennis YC Hsieh 2019-12-10 7:55 ` CK Hu 2019-12-12 1:33 ` Dennis-YC Hsieh 2019-11-27 1:58 ` [PATCH v2 10/14] soc: mediatek: cmdq: add write_s value function Dennis YC Hsieh 2019-11-27 1:58 ` [PATCH v2 11/14] soc: mediatek: cmdq: export finalize function Dennis YC Hsieh 2019-12-10 7:50 ` CK Hu 2019-11-27 1:58 ` [PATCH v2 12/14] soc: mediatek: cmdq: add loop function Dennis YC Hsieh 2019-12-11 1:48 ` CK Hu 2019-12-12 1:37 ` Dennis-YC Hsieh 2019-11-27 1:58 ` [PATCH v2 13/14] soc: mediatek: cmdq: add wait no clear event function Dennis YC Hsieh 2019-12-11 2:04 ` CK Hu 2019-12-12 1:42 ` Dennis-YC Hsieh [this message] 2019-11-27 1:58 ` [PATCH v2 14/14] soc: mediatek: cmdq: add set " Dennis YC Hsieh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1576114975.17653.16.camel@mtkswgap22 \ --to=dennis-yc.hsieh@mediatek.com \ --cc=bibby.hsieh@mediatek.com \ --cc=ck.hu@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=houlong.wei@mediatek.com \ --cc=jassisinghbrar@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=robh+dt@kernel.org \ --cc=wsd_upstream@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-mediatek Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-mediatek/0 linux-mediatek/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-mediatek linux-mediatek/ https://lore.kernel.org/linux-mediatek \ linux-mediatek@lists.infradead.org public-inbox-index linux-mediatek Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mediatek AGPL code for this site: git clone https://public-inbox.org/public-inbox.git