From: CK Hu <ck.hu@mediatek.com>
To: Bibby Hsieh <bibby.hsieh@mediatek.com>
Cc: devicetree@vger.kernel.org,
Nicolas Boichat <drinkcat@chromium.org>,
srv_heupstream@mediatek.com,
Jassi Brar <jassisinghbrar@gmail.com>,
linux-kernel@vger.kernel.org,
Houlong Wei <houlong.wei@mediatek.com>,
Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: mediatek: knows_txdone needs to be set in Mediatek CMDQ helper
Date: Fri, 14 Feb 2020 14:23:57 +0800 [thread overview]
Message-ID: <1581661437.16618.0.camel@mtksdaap41> (raw)
In-Reply-To: <20200214043545.16713-1-bibby.hsieh@mediatek.com>
Hi, Bibby:
On Fri, 2020-02-14 at 12:35 +0800, Bibby Hsieh wrote:
> Mediatek CMDQ driver have a mechanism to do TXDONE_BY_ACK,
> so we should set knows_txdone.
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Fixes:576f1b4bc802 ("soc: mediatek: Add Mediatek CMDQ helper")
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> ---
> drivers/soc/mediatek/mtk-cmdq-helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> index 9add0fd5fa6c..2ca1a759a347 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -80,6 +80,7 @@ struct cmdq_client *cmdq_mbox_create(struct device *dev, int index, u32 timeout)
> client->pkt_cnt = 0;
> client->client.dev = dev;
> client->client.tx_block = false;
> + client->client.knows_txdone = true;
> client->chan = mbox_request_channel(&client->client, index);
>
> if (IS_ERR(client->chan)) {
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-02-14 6:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 4:35 [PATCH] soc: mediatek: knows_txdone needs to be set in Mediatek CMDQ helper Bibby Hsieh
2020-02-14 6:23 ` CK Hu [this message]
2020-02-14 10:15 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581661437.16618.0.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=bibby.hsieh@mediatek.com \
--cc=dennis-yc.hsieh@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=houlong.wei@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).