* [PATCH] mt76: fix possible undetected invalid MAC address
@ 2019-11-26 13:15 Shayne Chen
0 siblings, 0 replies; only message in thread
From: Shayne Chen @ 2019-11-26 13:15 UTC (permalink / raw)
To: Felix Fietkau
Cc: Ryder Lee, linux-wireless, linux-mediatek, Roy Luo,
Lorenzo Bianconi, Lorenzo Bianconi, Shayne Chen
Make sure the MAC address is checked before function returns.
If CONFIG_OF is set and the device node is null, the function will
return directly, and an invalid MAC address will not be checked.
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
---
drivers/net/wireless/mediatek/mt76/eeprom.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c
index 804224e81103..358fb0a1e523 100644
--- a/drivers/net/wireless/mediatek/mt76/eeprom.c
+++ b/drivers/net/wireless/mediatek/mt76/eeprom.c
@@ -80,13 +80,14 @@ mt76_eeprom_override(struct mt76_dev *dev)
const u8 *mac;
if (!np)
- return;
+ goto out;
mac = of_get_mac_address(np);
if (!IS_ERR(mac))
ether_addr_copy(dev->macaddr, mac);
#endif
+out:
if (!is_valid_ether_addr(dev->macaddr)) {
eth_random_addr(dev->macaddr);
dev_info(dev->dev,
--
2.17.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-11-26 13:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-26 13:15 [PATCH] mt76: fix possible undetected invalid MAC address Shayne Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).