From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Andrei Stefanescu <andrei.stefanescu@microchip.com>,
Heiko Stuebner <heiko@sntech.de>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Linus Walleij <linus.walleij@linaro.org>,
Brendan Higgins <brendanhiggins@google.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andreas Kemnade <andreas@kemnade.info>,
"Angelo G. Del Regno" <kholk11@gmail.com>,
Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>,
linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org,
Axel Lin <axel.lin@ingics.com>,
Gregory CLEMENT <gregory.clement@bootlin.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Markus Reichl <m.reichl@fivetechno.de>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Chen-Yu Tsai <wens@csie.org>, Andy Gross <agross@kernel.org>,
markus.laine@fi.rohmeurope.com,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
devicetree@vger.kernel.org,
Charles Keepax <ckeepax@opensource.cirrus.com>,
mazziesaccount@gmail.com, linux-arm-msm@vger.kernel.org,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-arm-kernel@lists.infradead.org,
Support Opensource <support.opensource@diasemi.com>,
Baolin Wang <baolin.wang@linaro.org>,
Sangbeom Kim <sbkim73@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, mikko.mutanen@fi.rohmeurope.com,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
patches@opensource.cirrus.com
Subject: Re: [PATCH v8 01/10] dt-bindings: battery: add new battery parameters
Date: Sun, 5 Apr 2020 05:28:23 +0200 [thread overview]
Message-ID: <20200405032823.bje2tnk7fbaem3jr@earth.universe> (raw)
In-Reply-To: <8827238b51029886dea56ce3141b216361a3f299.1585902279.git.matti.vaittinen@fi.rohmeurope.com>
[-- Attachment #1.1: Type: text/plain, Size: 3503 bytes --]
Hi,
On Fri, Apr 03, 2020 at 11:41:11AM +0300, Matti Vaittinen wrote:
> Add:
>
> - trickle-charge-current-microamp:
>
> Some chargers have 3 charging stages. First one when battery is almost
> empty is often called as trickle-charge. Last state when battery has been
> "woken up" is usually called as fast-charge. In addition to this some
> chargers have a 'middle state' which ROHM BD99954 data-sheet describes as
> pre-charge. Some batteries can benefit from this 3-phase charging
> [citation needed].
>
> Introduce trickle-charge-current-microamp so that batteries can give
> charging current limit for all three states.
>
> - precharge-upper-limit-microvolt:
>
> When battery voltage has reached certain limit we change from
> trickle-charge to next charging state (pre-charge for BD99954). Allow
> battery to specify this limit.
>
> - re-charge-voltage-microvolt:
>
> Allow giving a battery specific voltage limit for chargers which can
> automatically re-start charging when battery has discharghed down to
> this limit.
>
> - over-voltage-threshold-microvolt
>
> Allow specifying voltage threshold after which the battery is assumed to
> be faulty.
>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
>
> No changes since v7
>
> Documentation/devicetree/bindings/power/supply/battery.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/battery.txt b/Documentation/devicetree/bindings/power/supply/battery.txt
> index 3049cf88bdcf..5e29595edd74 100644
> --- a/Documentation/devicetree/bindings/power/supply/battery.txt
> +++ b/Documentation/devicetree/bindings/power/supply/battery.txt
> @@ -11,15 +11,21 @@ different type. This prevents unpredictable, potentially harmful,
> behavior should a replacement that changes the battery type occur
> without a corresponding update to the dtb.
>
> +Please note that not all charger drivers respect all of the properties.
> +
> Required Properties:
> - compatible: Must be "simple-battery"
>
> Optional Properties:
> + - over-voltage-threshold-microvolt: battery over-voltage limit
> + - re-charge-voltage-microvolt: limit to automatically start charging again
> - voltage-min-design-microvolt: drained battery voltage
> - voltage-max-design-microvolt: fully charged battery voltage
> - energy-full-design-microwatt-hours: battery design energy
> - charge-full-design-microamp-hours: battery design capacity
> + - trickle-charge-current-microamp: current for trickle-charge phase
> - precharge-current-microamp: current for pre-charge phase
> + - precharge-upper-limit-microvolt: limit when to change to constant charging
> - charge-term-current-microamp: current for charge termination phase
> - constant-charge-current-max-microamp: maximum constant input current
> - constant-charge-voltage-max-microvolt: maximum constant input voltage
> --
> 2.21.0
>
>
> --
> Matti Vaittinen, Linux device drivers
> ROHM Semiconductors, Finland SWDC
> Kiviharjunlenkki 1E
> 90220 OULU
> FINLAND
>
> ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
> Simon says - in Latin please.
> ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
> Thanks to Simon Glass for the translation =]
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-04-05 3:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 8:36 [PATCH v8 00/10] Support ROHM BD99954 charger IC Matti Vaittinen
2020-04-03 8:41 ` [PATCH v8 01/10] dt-bindings: battery: add new battery parameters Matti Vaittinen
2020-04-05 3:28 ` Sebastian Reichel [this message]
2020-04-03 8:45 ` [PATCH v8 02/10] dt_bindings: ROHM BD99954 Charger Matti Vaittinen
2020-04-05 3:30 ` Sebastian Reichel
2020-04-03 8:45 ` [PATCH v8 03/10] lib: add linear ranges helpers Matti Vaittinen
2020-04-03 9:37 ` Andy Shevchenko
2020-04-03 8:46 ` [PATCH v8 04/10] lib/test_linear_ranges: add a test for the 'linear_ranges' Matti Vaittinen
2020-04-03 8:46 ` [PATCH v8 05/10] power: supply: bd70528: rename linear_range to avoid collision Matti Vaittinen
2020-04-05 3:33 ` Sebastian Reichel
2020-04-06 9:21 ` Vaittinen, Matti
2020-04-03 8:46 ` [PATCH v8 06/10] regulator: use linear_ranges helper Matti Vaittinen
2020-04-03 8:47 ` [PATCH v8 07/10] power: supply: bd70528: use linear ranges Matti Vaittinen
2020-04-05 3:37 ` Sebastian Reichel
2020-04-03 8:47 ` [PATCH v8 08/10] power: supply: add battery parameters Matti Vaittinen
2020-04-05 3:35 ` Sebastian Reichel
2020-04-03 8:48 ` [PATCH v8 09/10] power: supply: Support ROHM bd99954 charger Matti Vaittinen
2020-04-03 9:41 ` Andy Shevchenko
2020-04-05 3:22 ` Sebastian Reichel
2020-04-06 9:59 ` Vaittinen, Matti
2020-04-03 8:48 ` [PATCH v8 10/10] power: supply: Fix Kconfig help text indentiation Matti Vaittinen
2020-04-05 3:35 ` Sebastian Reichel
2020-04-03 10:07 ` [PATCH v8 00/10] Support ROHM BD99954 charger IC Vaittinen, Matti
2020-04-03 11:02 ` andriy.shevchenko
2020-04-03 11:13 ` Vaittinen, Matti
2020-04-03 11:50 ` andriy.shevchenko
2020-04-03 11:51 ` andriy.shevchenko
2020-04-03 12:01 ` Mark Brown
2020-04-03 12:30 ` Vaittinen, Matti
2020-04-03 12:31 ` Mark Brown
2020-04-05 3:27 ` Sebastian Reichel
2020-04-06 5:22 ` Vaittinen, Matti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200405032823.bje2tnk7fbaem3jr@earth.universe \
--to=sebastian.reichel@collabora.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=agross@kernel.org \
--cc=andreas@kemnade.info \
--cc=andrei.stefanescu@microchip.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=axel.lin@ingics.com \
--cc=b.zolnierkie@samsung.com \
--cc=baolin.wang@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=brendanhiggins@google.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=heiko@sntech.de \
--cc=hsin-hsiung.wang@mediatek.com \
--cc=kholk11@gmail.com \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.reichl@fivetechno.de \
--cc=mark.rutland@arm.com \
--cc=markus.laine@fi.rohmeurope.com \
--cc=matthias.bgg@gmail.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mikko.mutanen@fi.rohmeurope.com \
--cc=patches@opensource.cirrus.com \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rf@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=sbkim73@samsung.com \
--cc=support.opensource@diasemi.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).