Re: [PATCH v8 05/10] power: supply: bd70528: rename linear_range to avoid collision

From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Andrei Stefanescu <andrei.stefanescu@microchip.com>,
	Heiko Stuebner <heiko@sntech.de>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Brendan Higgins <brendanhiggins@google.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andreas Kemnade <andreas@kemnade.info>,
	"Angelo G. Del Regno" <kholk11@gmail.com>,
	Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>,
	linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org,
	Axel Lin <axel.lin@ingics.com>,
	Gregory CLEMENT <gregory.clement@bootlin.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Markus Reichl <m.reichl@fivetechno.de>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Chen-Yu Tsai <wens@csie.org>, Andy Gross <agross@kernel.org>,
	markus.laine@fi.rohmeurope.com,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	devicetree@vger.kernel.org,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	mazziesaccount@gmail.com, linux-arm-msm@vger.kernel.org,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	Mark Brown <broonie@kernel.org>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-arm-kernel@lists.infradead.org,
	Support Opensource <support.opensource@diasemi.com>,
	Baolin Wang <baolin.wang@linaro.org>,
	Sangbeom Kim <sbkim73@samsung.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-pm@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org, mikko.mutanen@fi.rohmeurope.com,
	Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	patches@opensource.cirrus.com
Subject: Re: [PATCH v8 05/10] power: supply: bd70528: rename linear_range to avoid collision
Date: Sun, 5 Apr 2020 05:33:16 +0200	[thread overview]
Message-ID: <20200405033316.bhafrtorxzwev24z@earth.universe> (raw)
In-Reply-To: <7a6727838bcc93f443c993d91d21d9306dee22be.1585902279.git.matti.vaittinen@fi.rohmeurope.com>

[-- Attachment #1.1: Type: text/plain, Size: 2972 bytes --]

Hi,

On Fri, Apr 03, 2020 at 11:46:30AM +0300, Matti Vaittinen wrote:
> Follow-up patches in this series will add a generic struct
> linear_range. Rename bd70528 internal struct to avoid collision.
> 
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---

Actually the patch is before this one. But since the include is not
yet used in the bd70528 charger driver, it should be ok to do it in
this order.

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

> 
> No changes since v7
> 
>  drivers/power/supply/bd70528-charger.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/power/supply/bd70528-charger.c b/drivers/power/supply/bd70528-charger.c
> index b8e1ec106627..3b820110ecfa 100644
> --- a/drivers/power/supply/bd70528-charger.c
> +++ b/drivers/power/supply/bd70528-charger.c
> @@ -335,14 +335,14 @@ static int bd70528_get_present(struct bd70528_psy *bdpsy, int *val)
>  	return 0;
>  }
>  
> -struct linear_range {
> +struct bd70528_linear_range {
>  	int min;
>  	int step;
>  	int vals;
>  	int low_sel;
>  };
>  
> -static const struct linear_range current_limit_ranges[] = {
> +static const struct bd70528_linear_range current_limit_ranges[] = {
>  	{
>  		.min = 5,
>  		.step = 1,
> @@ -374,7 +374,7 @@ static const struct linear_range current_limit_ranges[] = {
>   * voltage for low temperatures. The driver currently only reads
>   * the charge current at room temperature. We do set both though.
>   */
> -static const struct linear_range warm_charge_curr[] = {
> +static const struct bd70528_linear_range warm_charge_curr[] = {
>  	{
>  		.min = 10,
>  		.step = 10,
> @@ -398,7 +398,7 @@ static const struct linear_range warm_charge_curr[] = {
>  #define MAX_WARM_CHG_CURR_SEL 0x1f
>  #define MIN_CHG_CURR_SEL 0x0
>  
> -static int find_value_for_selector_low(const struct linear_range *r,
> +static int find_value_for_selector_low(const struct bd70528_linear_range *r,
>  				       int selectors, unsigned int sel,
>  				       unsigned int *val)
>  {
> @@ -420,7 +420,7 @@ static int find_value_for_selector_low(const struct linear_range *r,
>   * I guess it is enough if we use voltage/current which is closest (below)
>   * the requested?
>   */
> -static int find_selector_for_value_low(const struct linear_range *r,
> +static int find_selector_for_value_low(const struct bd70528_linear_range *r,
>  				       int selectors, unsigned int val,
>  				       unsigned int *sel, bool *found)
>  {
> -- 
> 2.21.0
> 
> 
> -- 
> Matti Vaittinen, Linux device drivers
> ROHM Semiconductors, Finland SWDC
> Kiviharjunlenkki 1E
> 90220 OULU
> FINLAND
> 
> ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
> Simon says - in Latin please.
> ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
> Thanks to Simon Glass for the translation =] 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek