Re: [PATCH v8 08/10] power: supply: add battery parameters

From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Andrei Stefanescu <andrei.stefanescu@microchip.com>,
	Heiko Stuebner <heiko@sntech.de>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Brendan Higgins <brendanhiggins@google.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andreas Kemnade <andreas@kemnade.info>,
	"Angelo G. Del Regno" <kholk11@gmail.com>,
	Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>,
	linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org,
	Axel Lin <axel.lin@ingics.com>,
	Gregory CLEMENT <gregory.clement@bootlin.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Markus Reichl <m.reichl@fivetechno.de>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Chen-Yu Tsai <wens@csie.org>, Andy Gross <agross@kernel.org>,
	markus.laine@fi.rohmeurope.com,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	devicetree@vger.kernel.org,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	mazziesaccount@gmail.com, linux-arm-msm@vger.kernel.org,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	Mark Brown <broonie@kernel.org>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-arm-kernel@lists.infradead.org,
	Support Opensource <support.opensource@diasemi.com>,
	Baolin Wang <baolin.wang@linaro.org>,
	Sangbeom Kim <sbkim73@samsung.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-pm@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org, mikko.mutanen@fi.rohmeurope.com,
	Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	patches@opensource.cirrus.com
Subject: Re: [PATCH v8 08/10] power: supply: add battery parameters
Date: Sun, 5 Apr 2020 05:35:00 +0200	[thread overview]
Message-ID: <20200405033500.yvelxz6cqnjwnxu7@earth.universe> (raw)
In-Reply-To: <48f250bf6928929f60764c4334c60611b46233c4.1585902279.git.matti.vaittinen@fi.rohmeurope.com>


[-- Attachment #1.1: Type: text/plain, Size: 3332 bytes --]

Hi,

On Fri, Apr 03, 2020 at 11:47:43AM +0300, Matti Vaittinen wrote:
> Add parsing of new device-tree battery bindings.
> 
>      - trickle-charge-current-microamp
>      - precharge-upper-limit-microvolt
>      - re-charge-voltage-microvolt
>      - over-voltage-threshold-microvolt
> 
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

> ---
> No changes since v7
> 
>  drivers/power/supply/power_supply_core.c | 8 ++++++++
>  include/linux/power_supply.h             | 4 ++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c
> index 1a9a9fae73d3..02b37fe6061c 100644
> --- a/drivers/power/supply/power_supply_core.c
> +++ b/drivers/power/supply/power_supply_core.c
> @@ -620,10 +620,18 @@ int power_supply_get_battery_info(struct power_supply *psy,
>  			     &info->voltage_min_design_uv);
>  	of_property_read_u32(battery_np, "voltage-max-design-microvolt",
>  			     &info->voltage_max_design_uv);
> +	of_property_read_u32(battery_np, "trickle-charge-current-microamp",
> +			     &info->tricklecharge_current_ua);
>  	of_property_read_u32(battery_np, "precharge-current-microamp",
>  			     &info->precharge_current_ua);
> +	of_property_read_u32(battery_np, "precharge-upper-limit-microvolt",
> +			     &info->precharge_voltage_max_uv);
>  	of_property_read_u32(battery_np, "charge-term-current-microamp",
>  			     &info->charge_term_current_ua);
> +	of_property_read_u32(battery_np, "re-charge-voltage-microvolt",
> +			     &info->charge_restart_voltage_uv);
> +	of_property_read_u32(battery_np, "over-voltage-threshold-microvolt",
> +			     &info->overvoltage_limit_uv);
>  	of_property_read_u32(battery_np, "constant-charge-current-max-microamp",
>  			     &info->constant_charge_current_max_ua);
>  	of_property_read_u32(battery_np, "constant-charge-voltage-max-microvolt",
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index dcd5a71e6c67..d01322d1ab52 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -346,8 +346,12 @@ struct power_supply_battery_info {
>  	int charge_full_design_uah;	    /* microAmp-hours */
>  	int voltage_min_design_uv;	    /* microVolts */
>  	int voltage_max_design_uv;	    /* microVolts */
> +	int tricklecharge_current_ua;	    /* microAmps */
>  	int precharge_current_ua;	    /* microAmps */
> +	int precharge_voltage_max_uv;	    /* microVolts */
>  	int charge_term_current_ua;	    /* microAmps */
> +	int charge_restart_voltage_uv;	    /* microVolts */
> +	int overvoltage_limit_uv;	    /* microVolts */
>  	int constant_charge_current_max_ua; /* microAmps */
>  	int constant_charge_voltage_max_uv; /* microVolts */
>  	int factory_internal_resistance_uohm;   /* microOhms */
> -- 
> 2.21.0
> 
> 
> -- 
> Matti Vaittinen, Linux device drivers
> ROHM Semiconductors, Finland SWDC
> Kiviharjunlenkki 1E
> 90220 OULU
> FINLAND
> 
> ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
> Simon says - in Latin please.
> ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
> Thanks to Simon Glass for the translation =] 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek