From: Ulf Hansson <ulf.hansson@linaro.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: chaotian.jing@mediatek.com, matthias.bgg@gmail.com,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH 5/5] mmc: mtk-sd: Assign src_clk parent to src_clk_cg for legacy DTs
Date: Tue, 28 Dec 2021 17:57:41 +0100 [thread overview]
Message-ID: <CAPDyKFpX7_EfnDup-ZvG=9H36Ok3tvnBdS_Q+e4RcAYMN1K_KQ@mail.gmail.com> (raw)
In-Reply-To: <20211216125748.179602-5-angelogioacchino.delregno@collabora.com>
On Thu, 16 Dec 2021 at 13:57, AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> In commit 3c1a88443698 ("mmc: mediatek: add support of source_cg clock")
> an independent cg was introduced to avoid a hardware hang issue during
> clock mode switches (subsequent commits will set that clock as optional).
>
> When this clock is not present in device-tree, any operation is being
> done on src_clk's parent (calling clk_get_parent()): to simplify this
> and avoid checking for src_clk_cg presence everytime, just assign the
> parent clock to src_clk_cg and remove the now useless checks.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
The series applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/mtk-sd.c | 28 ++++++++++++++++------------
> 1 file changed, 16 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 59d7decc3051..65037e1d7723 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -901,14 +901,8 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz)
> }
> }
> sdr_clr_bits(host->base + MSDC_CFG, MSDC_CFG_CKPDN);
> - /*
> - * As src_clk/HCLK use the same bit to gate/ungate,
> - * So if want to only gate src_clk, need gate its parent(mux).
> - */
> - if (host->src_clk_cg)
> - clk_disable_unprepare(host->src_clk_cg);
> - else
> - clk_disable_unprepare(clk_get_parent(host->src_clk));
> +
> + clk_disable_unprepare(host->src_clk_cg);
> if (host->dev_comp->clk_div_bits == 8)
> sdr_set_field(host->base + MSDC_CFG,
> MSDC_CFG_CKMOD | MSDC_CFG_CKDIV,
> @@ -917,11 +911,8 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz)
> sdr_set_field(host->base + MSDC_CFG,
> MSDC_CFG_CKMOD_EXTRA | MSDC_CFG_CKDIV_EXTRA,
> (mode << 12) | div);
> - if (host->src_clk_cg)
> - clk_prepare_enable(host->src_clk_cg);
> - else
> - clk_prepare_enable(clk_get_parent(host->src_clk));
>
> + clk_prepare_enable(host->src_clk_cg);
> readl_poll_timeout(host->base + MSDC_CFG, val, (val & MSDC_CFG_CKSTB), 0, 0);
> sdr_set_bits(host->base + MSDC_CFG, MSDC_CFG_CKPDN);
> mmc->actual_clock = sclk;
> @@ -2530,6 +2521,19 @@ static int msdc_of_clock_parse(struct platform_device *pdev,
> if (IS_ERR(host->src_clk_cg))
> return PTR_ERR(host->src_clk_cg);
>
> + /*
> + * Fallback for legacy device-trees: src_clk and HCLK use the same
> + * bit to control gating but they are parented to a different mux,
> + * hence if our intention is to gate only the source, required
> + * during a clk mode switch to avoid hw hangs, we need to gate
> + * its parent (specified as a different clock only on new DTs).
> + */
> + if (!host->src_clk_cg) {
> + host->src_clk_cg = clk_get_parent(host->src_clk);
> + if (IS_ERR(host->src_clk_cg))
> + return PTR_ERR(host->src_clk_cg);
> + }
> +
> host->sys_clk_cg = devm_clk_get_optional(&pdev->dev, "sys_cg");
> if (IS_ERR(host->sys_clk_cg))
> host->sys_clk_cg = NULL;
> --
> 2.33.1
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
prev parent reply other threads:[~2021-12-28 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 12:57 [PATCH 1/5] mmc: mtk-sd: Use readl_poll_timeout instead of open-coded polling AngeloGioacchino Del Regno
2021-12-16 12:57 ` [PATCH 2/5] mmc: mtk-sd: Use BIT() and GENMASK() macros to describe fields AngeloGioacchino Del Regno
2021-12-16 12:57 ` [PATCH 3/5] mmc: mtk-sd: Take action for no-sdio device-tree parameter AngeloGioacchino Del Regno
2021-12-16 12:57 ` [PATCH 4/5] mmc: mtk-sd: Fix usage of devm_clk_get_optional() AngeloGioacchino Del Regno
2021-12-16 12:57 ` [PATCH 5/5] mmc: mtk-sd: Assign src_clk parent to src_clk_cg for legacy DTs AngeloGioacchino Del Regno
2021-12-28 16:57 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFpX7_EfnDup-ZvG=9H36Ok3tvnBdS_Q+e4RcAYMN1K_KQ@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chaotian.jing@mediatek.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).