From: Paul Burton <paul.burton@imgtec.com>
To: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] MIPS: Fix ISA I FP sigcontext access violation handling
Date: Tue, 1 Nov 2016 09:27:39 +0000 [thread overview]
Message-ID: <3679706.n1bQkNAIWn@np-p-burton> (raw)
Message-ID: <20161101092739.UOYmhd8Q1o8qwtMG6fO8ULpis9WW2L-ZU1fCypghu_c@z> (raw)
In-Reply-To: <alpine.DEB.2.00.1610310325060.31859@tp.orcam.me.uk>
[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]
On Monday, 31 October 2016 16:25:44 GMT Maciej W. Rozycki wrote:
> Complement commit 0ae8dceaebe3 ("Merge with 2.3.10.") and use the local
> `fault' handler to recover from FP sigcontext access violation faults,
> like corresponding code does in r4k_fpu.S. The `bad_stack' handler is
> in syscall.c and is not suitable here as we want to propagate the error
> condition up through the caller rather than killing the thread outright.
>
> Signed-off-by: Maciej W. Rozycki <macro@imgtec.com>
> ---
> I guess it hardly ever triggers and code still builds, so it has aged so
> well...
>
> Maciej
>
> linux-mips-isa1-sig-fp-context-fault.patch
> Index: linux-sfr-test/arch/mips/kernel/r2300_fpu.S
> ===================================================================
> --- linux-sfr-test.orig/arch/mips/kernel/r2300_fpu.S 2016-10-22
> 02:36:46.000000000 +0100 +++
> linux-sfr-test/arch/mips/kernel/r2300_fpu.S 2016-10-22 02:37:20.891186000
> +0100 @@ -21,7 +21,7 @@
> #define EX(a,b) \
> 9: a,##b; \
> .section __ex_table,"a"; \
> - PTR 9b,bad_stack; \
> + PTR 9b,fault; \
> .previous
>
> .set noreorder
Hi Maciej,
Looks good to me:
Reviewed-by: Paul Burton <paul.burton@imgtec.com>
Thanks,
Paul
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-11-01 9:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 16:24 [PATCH 0/4] MIPS I/II FP signal context handling fixes Maciej W. Rozycki
2016-10-31 16:24 ` Maciej W. Rozycki
2016-10-31 16:25 ` [PATCH 1/4] MIPS: Fix ISA I FP sigcontext access violation handling Maciej W. Rozycki
2016-10-31 16:25 ` Maciej W. Rozycki
2016-11-01 9:27 ` Paul Burton [this message]
2016-11-01 9:27 ` Paul Burton
2016-10-31 16:26 ` [PATCH 2/4] MIPS: Remove FIR from ISA I FP signal context Maciej W. Rozycki
2016-10-31 16:26 ` Maciej W. Rozycki
2016-10-31 16:27 ` [PATCH 3/4] MIPS: Fix ISA I/II FP signal context offsets Maciej W. Rozycki
2016-10-31 16:27 ` Maciej W. Rozycki
2016-11-01 9:31 ` Paul Burton
2016-11-01 9:31 ` Paul Burton
2016-11-01 11:49 ` Maciej W. Rozycki
2016-11-01 11:49 ` Maciej W. Rozycki
2016-10-31 16:27 ` [PATCH 4/4] MIPS: Correct MIPS I FP sigcontext layout Maciej W. Rozycki
2016-10-31 16:27 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3679706.n1bQkNAIWn@np-p-burton \
--to=paul.burton@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@imgtec.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).