linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@imgtec.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: <linux-mips@linux-mips.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/4] MIPS: Remove FIR from ISA I FP signal context
Date: Mon, 31 Oct 2016 16:26:24 +0000	[thread overview]
Message-ID: <alpine.DEB.2.00.1610310345580.31859@tp.orcam.me.uk> (raw)
In-Reply-To: <alpine.DEB.2.00.1610310319010.31859@tp.orcam.me.uk>

Complement commit e50c0a8fa60d ("Support the MIPS32 / MIPS64 DSP ASE.") 
and remove the Floating Point Implementation Register (FIR) from the FP 
register set recorded in a signal context with MIPS I processors too, in 
line with the change applied to r4k_fpu.S.

The `sc_fpc_eir' slot is unused according to our current ABI and the FIR 
register is read-only and always directly accessible from user software.

Signed-off-by: Maciej W. Rozycki <macro@imgtec.com>
---
linux-mips-isa1-sig-fp-context-dsp.patch
Index: linux-sfr-test/arch/mips/kernel/r2300_fpu.S
===================================================================
--- linux-sfr-test.orig/arch/mips/kernel/r2300_fpu.S	2016-10-22 02:17:38.000000000 +0100
+++ linux-sfr-test/arch/mips/kernel/r2300_fpu.S	2016-10-22 02:19:40.565112000 +0100
@@ -64,13 +64,9 @@ LEAF(_save_fp_context)
 	EX(swc1 $f29,(SC_FPREGS+232)(a0))
 	EX(swc1 $f30,(SC_FPREGS+240)(a0))
 	EX(swc1 $f31,(SC_FPREGS+248)(a0))
-	EX(sw	t1,(SC_FPC_CSR)(a0))
-	cfc1	t0,$0				# implementation/version
 	jr	ra
+	 EX(sw	t1,(SC_FPC_CSR)(a0))
 	.set	pop
-	.set	nomacro
-	 EX(sw	t0,(SC_FPC_EIR)(a0))
-	.set	macro
 	END(_save_fp_context)
 
 /*

WARNING: multiple messages have this Message-ID (diff)
From: "Maciej W. Rozycki" <macro@imgtec.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] MIPS: Remove FIR from ISA I FP signal context
Date: Mon, 31 Oct 2016 16:26:24 +0000	[thread overview]
Message-ID: <alpine.DEB.2.00.1610310345580.31859@tp.orcam.me.uk> (raw)
Message-ID: <20161031162624.oGPWX_y6u4zA6fEO2yzwwKxLNuwDmz7dZ9v8HwWq4hk@z> (raw)
In-Reply-To: <alpine.DEB.2.00.1610310319010.31859@tp.orcam.me.uk>

Complement commit e50c0a8fa60d ("Support the MIPS32 / MIPS64 DSP ASE.") 
and remove the Floating Point Implementation Register (FIR) from the FP 
register set recorded in a signal context with MIPS I processors too, in 
line with the change applied to r4k_fpu.S.

The `sc_fpc_eir' slot is unused according to our current ABI and the FIR 
register is read-only and always directly accessible from user software.

Signed-off-by: Maciej W. Rozycki <macro@imgtec.com>
---
linux-mips-isa1-sig-fp-context-dsp.patch
Index: linux-sfr-test/arch/mips/kernel/r2300_fpu.S
===================================================================
--- linux-sfr-test.orig/arch/mips/kernel/r2300_fpu.S	2016-10-22 02:17:38.000000000 +0100
+++ linux-sfr-test/arch/mips/kernel/r2300_fpu.S	2016-10-22 02:19:40.565112000 +0100
@@ -64,13 +64,9 @@ LEAF(_save_fp_context)
 	EX(swc1 $f29,(SC_FPREGS+232)(a0))
 	EX(swc1 $f30,(SC_FPREGS+240)(a0))
 	EX(swc1 $f31,(SC_FPREGS+248)(a0))
-	EX(sw	t1,(SC_FPC_CSR)(a0))
-	cfc1	t0,$0				# implementation/version
 	jr	ra
+	 EX(sw	t1,(SC_FPC_CSR)(a0))
 	.set	pop
-	.set	nomacro
-	 EX(sw	t0,(SC_FPC_EIR)(a0))
-	.set	macro
 	END(_save_fp_context)
 
 /*

  parent reply	other threads:[~2016-10-31 16:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-31 16:24 [PATCH 0/4] MIPS I/II FP signal context handling fixes Maciej W. Rozycki
2016-10-31 16:24 ` Maciej W. Rozycki
2016-10-31 16:25 ` [PATCH 1/4] MIPS: Fix ISA I FP sigcontext access violation handling Maciej W. Rozycki
2016-10-31 16:25   ` Maciej W. Rozycki
2016-11-01  9:27   ` Paul Burton
2016-11-01  9:27     ` Paul Burton
2016-10-31 16:26 ` Maciej W. Rozycki [this message]
2016-10-31 16:26   ` [PATCH 2/4] MIPS: Remove FIR from ISA I FP signal context Maciej W. Rozycki
2016-10-31 16:27 ` [PATCH 3/4] MIPS: Fix ISA I/II FP signal context offsets Maciej W. Rozycki
2016-10-31 16:27   ` Maciej W. Rozycki
2016-11-01  9:31   ` Paul Burton
2016-11-01  9:31     ` Paul Burton
2016-11-01 11:49     ` Maciej W. Rozycki
2016-11-01 11:49       ` Maciej W. Rozycki
2016-10-31 16:27 ` [PATCH 4/4] MIPS: Correct MIPS I FP sigcontext layout Maciej W. Rozycki
2016-10-31 16:27   ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1610310345580.31859@tp.orcam.me.uk \
    --to=macro@imgtec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).