Linux-MIPS Archive on lore.kernel.org
 help / color / Atom feed
* MIPS: CI20: Update defconfig for EFUSE.
@ 2020-07-23  7:19 周琰杰 (Zhou Yanjie)
  2020-07-23  7:19 ` [PATCH] " 周琰杰 (Zhou Yanjie)
  0 siblings, 1 reply; 6+ messages in thread
From: 周琰杰 (Zhou Yanjie) @ 2020-07-23  7:19 UTC (permalink / raw)
  To: tsbogend
  Cc: linux-kernel, linux-mips, keescook, hns, ebiederm, dongsheng.qiu,
	aric.pzqi, rick.tyliu, yanfei.li, sernia.zhou, zhenwenjin, paul

周琰杰 (Zhou Yanjie) (1):
  MIPS: CI20: Update defconfig for EFUSE.

 arch/mips/configs/ci20_defconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.11.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] MIPS: CI20: Update defconfig for EFUSE.
  2020-07-23  7:19 MIPS: CI20: Update defconfig for EFUSE 周琰杰 (Zhou Yanjie)
@ 2020-07-23  7:19 ` 周琰杰 (Zhou Yanjie)
  2020-07-23  8:47   ` Paul Cercueil
  0 siblings, 1 reply; 6+ messages in thread
From: 周琰杰 (Zhou Yanjie) @ 2020-07-23  7:19 UTC (permalink / raw)
  To: tsbogend
  Cc: linux-kernel, linux-mips, keescook, hns, ebiederm, dongsheng.qiu,
	aric.pzqi, rick.tyliu, yanfei.li, sernia.zhou, zhenwenjin, paul

The commit 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
controller use NVMEM to find the default MAC address") add EFUSE
node for DM9000 in CI20, however, the EFUSE driver is not selected,
which will cause the DM9000 to fail to read the MAC address from
EFUSE, causing the following issue:

[FAILED] Failed to start Raise network interfaces.

Fix this problem by select CONFIG_JZ4780_EFUSE by default in the
ci20_defconfig.

Fixes: 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
controller use NVMEM to find the default MAC address").

Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
---
 arch/mips/configs/ci20_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_defconfig
index f433fad16073..ba26ba4de09a 100644
--- a/arch/mips/configs/ci20_defconfig
+++ b/arch/mips/configs/ci20_defconfig
@@ -140,6 +140,7 @@ CONFIG_INGENIC_OST=y
 CONFIG_MEMORY=y
 CONFIG_PWM=y
 CONFIG_PWM_JZ4740=m
+CONFIG_JZ4780_EFUSE=y
 CONFIG_EXT4_FS=y
 # CONFIG_DNOTIFY is not set
 CONFIG_AUTOFS_FS=y
-- 
2.11.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MIPS: CI20: Update defconfig for EFUSE.
  2020-07-23  7:19 ` [PATCH] " 周琰杰 (Zhou Yanjie)
@ 2020-07-23  8:47   ` Paul Cercueil
  2020-07-25  8:02     ` Zhou Yanjie
  0 siblings, 1 reply; 6+ messages in thread
From: Paul Cercueil @ 2020-07-23  8:47 UTC (permalink / raw)
  To: 周琰杰
  Cc: tsbogend, linux-kernel, linux-mips, keescook, hns, ebiederm,
	dongsheng.qiu, aric.pzqi, rick.tyliu, yanfei.li, sernia.zhou,
	zhenwenjin

Hi Zhou,

Le jeu. 23 juil. 2020 à 15:19, 周琰杰 (Zhou Yanjie) 
<zhouyanjie@wanyeetech.com> a écrit :
> The commit 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
> controller use NVMEM to find the default MAC address") add EFUSE
> node for DM9000 in CI20, however, the EFUSE driver is not selected,
> which will cause the DM9000 to fail to read the MAC address from
> EFUSE, causing the following issue:
> 
> [FAILED] Failed to start Raise network interfaces.
> 
> Fix this problem by select CONFIG_JZ4780_EFUSE by default in the
> ci20_defconfig.

Does it actually fix it on a clean 5.8-rc kernel?

 From what I know, the efuse driver cannot probe, because the nemc 
driver requests the complete memory resource, so the efuse driver's 
devm_platform_ioremap_resource() fails.

I did send a patch to fix this 
(https://lore.kernel.org/lkml/551a8560261543c1decb1d4d1671ec4b7fa52fdb.1582905653.git.hns@goldelico.com/),
but it's hard to have somebody merge it, because nobody maintains 
drivers/memory/.

> Fixes: 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
> controller use NVMEM to find the default MAC address").

That shouldn't be a fix IMHO - the devicetree was updated in one 
commit, the config should be updated in another. The "bug" here is that 
it wasn't done right away.

> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>

Btw - when you add a Fixes: tag to fix a commit that is not for the 
kernel currently in RC phase, you need to Cc linux-stable as well.

Cheers,
-Paul

> ---
>  arch/mips/configs/ci20_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/configs/ci20_defconfig 
> b/arch/mips/configs/ci20_defconfig
> index f433fad16073..ba26ba4de09a 100644
> --- a/arch/mips/configs/ci20_defconfig
> +++ b/arch/mips/configs/ci20_defconfig
> @@ -140,6 +140,7 @@ CONFIG_INGENIC_OST=y
>  CONFIG_MEMORY=y
>  CONFIG_PWM=y
>  CONFIG_PWM_JZ4740=m
> +CONFIG_JZ4780_EFUSE=y
>  CONFIG_EXT4_FS=y
>  # CONFIG_DNOTIFY is not set
>  CONFIG_AUTOFS_FS=y
> --
> 2.11.0
> 



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MIPS: CI20: Update defconfig for EFUSE.
  2020-07-23  8:47   ` Paul Cercueil
@ 2020-07-25  8:02     ` Zhou Yanjie
  2020-07-28 15:40       ` Paul Cercueil
  0 siblings, 1 reply; 6+ messages in thread
From: Zhou Yanjie @ 2020-07-25  8:02 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: tsbogend, linux-kernel, linux-mips, keescook, hns, ebiederm,
	dongsheng.qiu, aric.pzqi, rick.tyliu, yanfei.li, sernia.zhou,
	zhenwenjin

Hi Paul,

在 2020/7/23 下午4:47, Paul Cercueil 写道:
> Hi Zhou,
>
> Le jeu. 23 juil. 2020 à 15:19, 周琰杰 (Zhou Yanjie) 
> <zhouyanjie@wanyeetech.com> a écrit :
>> The commit 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
>> controller use NVMEM to find the default MAC address") add EFUSE
>> node for DM9000 in CI20, however, the EFUSE driver is not selected,
>> which will cause the DM9000 to fail to read the MAC address from
>> EFUSE, causing the following issue:
>>
>> [FAILED] Failed to start Raise network interfaces.
>>
>> Fix this problem by select CONFIG_JZ4780_EFUSE by default in the
>> ci20_defconfig.
>
> Does it actually fix it on a clean 5.8-rc kernel?
>
> From what I know, the efuse driver cannot probe, because the nemc 
> driver requests the complete memory resource, so the efuse driver's 
> devm_platform_ioremap_resource() fails.
>
> I did send a patch to fix this 
> (https://lore.kernel.org/lkml/551a8560261543c1decb1d4d1671ec4b7fa52fdb.1582905653.git.hns@goldelico.com/),
> but it's hard to have somebody merge it, because nobody maintains 
> drivers/memory/.
>
You are right, I cleaned up the changes made to support X1000's EFUSE 
and rebase to clean 5.8-RC6, it still does not work properly, I think we 
should drop this fix patch.

>> Fixes: 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
>> controller use NVMEM to find the default MAC address").
>
> That shouldn't be a fix IMHO - the devicetree was updated in one 
> commit, the config should be updated in another. The "bug" here is 
> that it wasn't done right away.
>
Okay.
>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
>
> Btw - when you add a Fixes: tag to fix a commit that is not for the 
> kernel currently in RC phase, you need to Cc linux-stable as well.
>
Sure, I will pay attention next time.

Thanks and best regards!


> Cheers,
> -Paul
>
>> ---
>>  arch/mips/configs/ci20_defconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/mips/configs/ci20_defconfig 
>> b/arch/mips/configs/ci20_defconfig
>> index f433fad16073..ba26ba4de09a 100644
>> --- a/arch/mips/configs/ci20_defconfig
>> +++ b/arch/mips/configs/ci20_defconfig
>> @@ -140,6 +140,7 @@ CONFIG_INGENIC_OST=y
>>  CONFIG_MEMORY=y
>>  CONFIG_PWM=y
>>  CONFIG_PWM_JZ4740=m
>> +CONFIG_JZ4780_EFUSE=y
>>  CONFIG_EXT4_FS=y
>>  # CONFIG_DNOTIFY is not set
>>  CONFIG_AUTOFS_FS=y
>> -- 
>> 2.11.0
>>
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MIPS: CI20: Update defconfig for EFUSE.
  2020-07-25  8:02     ` Zhou Yanjie
@ 2020-07-28 15:40       ` Paul Cercueil
  2020-08-07 15:55         ` Zhou Yanjie
  0 siblings, 1 reply; 6+ messages in thread
From: Paul Cercueil @ 2020-07-28 15:40 UTC (permalink / raw)
  To: Zhou Yanjie
  Cc: tsbogend, linux-kernel, linux-mips, keescook, hns, ebiederm,
	dongsheng.qiu, aric.pzqi, rick.tyliu, yanfei.li, sernia.zhou,
	zhenwenjin

Hi Zhou,

Le sam. 25 juil. 2020 à 16:02, Zhou Yanjie <zhouyanjie@wanyeetech.com> 
a écrit :
> Hi Paul,
> 
> 在 2020/7/23 下午4:47, Paul Cercueil 写道:
>> Hi Zhou,
>> 
>> Le jeu. 23 juil. 2020 à 15:19, 周琰杰 (Zhou Yanjie) 
>> \x7f<zhouyanjie@wanyeetech.com> a écrit :
>>> The commit 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
>>> controller use NVMEM to find the default MAC address") add EFUSE
>>> node for DM9000 in CI20, however, the EFUSE driver is not selected,
>>> which will cause the DM9000 to fail to read the MAC address from
>>> EFUSE, causing the following issue:
>>> 
>>> [FAILED] Failed to start Raise network interfaces.
>>> 
>>> Fix this problem by select CONFIG_JZ4780_EFUSE by default in the
>>> ci20_defconfig.
>> 
>> Does it actually fix it on a clean 5.8-rc kernel?
>> 
>> From what I know, the efuse driver cannot probe, because the nemc 
>> \x7fdriver requests the complete memory resource, so the efuse driver's 
>> \x7fdevm_platform_ioremap_resource() fails.
>> 
>> I did send a patch to fix this 
>> \x7f(https://lore.kernel.org/lkml/551a8560261543c1decb1d4d1671ec4b7fa52fdb.1582905653.git.hns@goldelico.com/),
>> but it's hard to have somebody merge it, because nobody maintains 
>> \x7fdrivers/memory/.
>> 
> You are right, I cleaned up the changes made to support X1000's EFUSE 
> and rebase to clean 5.8-RC6, it still does not work properly, I think 
> we should drop this fix patch.

The patch I mentioned was merged, so starting from 5.9-rc1 the efuse 
driver should work. Please resend this patch after 5.9-rc1 then.

Thanks,
-Paul

> 
>>> Fixes: 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
>>> controller use NVMEM to find the default MAC address").
>> 
>> That shouldn't be a fix IMHO - the devicetree was updated in one 
>> \x7fcommit, the config should be updated in another. The "bug" here is 
>> \x7fthat it wasn't done right away.
>> 
> Okay.
>>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
>> 
>> Btw - when you add a Fixes: tag to fix a commit that is not for the 
>> \x7fkernel currently in RC phase, you need to Cc linux-stable as well.
>> 
> Sure, I will pay attention next time.
> 
> Thanks and best regards!
> 
> 
>> Cheers,
>> -Paul
>> 
>>> ---
>>>  arch/mips/configs/ci20_defconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>> 
>>> diff --git a/arch/mips/configs/ci20_defconfig 
>>> \x7f\x7fb/arch/mips/configs/ci20_defconfig
>>> index f433fad16073..ba26ba4de09a 100644
>>> --- a/arch/mips/configs/ci20_defconfig
>>> +++ b/arch/mips/configs/ci20_defconfig
>>> @@ -140,6 +140,7 @@ CONFIG_INGENIC_OST=y
>>>  CONFIG_MEMORY=y
>>>  CONFIG_PWM=y
>>>  CONFIG_PWM_JZ4740=m
>>> +CONFIG_JZ4780_EFUSE=y
>>>  CONFIG_EXT4_FS=y
>>>  # CONFIG_DNOTIFY is not set
>>>  CONFIG_AUTOFS_FS=y
>>> --
>>> 2.11.0
>>> 
>> 



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MIPS: CI20: Update defconfig for EFUSE.
  2020-07-28 15:40       ` Paul Cercueil
@ 2020-08-07 15:55         ` Zhou Yanjie
  0 siblings, 0 replies; 6+ messages in thread
From: Zhou Yanjie @ 2020-08-07 15:55 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: tsbogend, linux-kernel, linux-mips, keescook, hns, ebiederm,
	dongsheng.qiu, aric.pzqi, rick.tyliu, yanfei.li, sernia.zhou,
	zhenwenjin

Hi Paul,

在 2020/7/28 下午11:40, Paul Cercueil 写道:
> Hi Zhou,
>
> Le sam. 25 juil. 2020 à 16:02, Zhou Yanjie <zhouyanjie@wanyeetech.com> 
> a écrit :
>> Hi Paul,
>>
>> 在 2020/7/23 下午4:47, Paul Cercueil 写道:
>>> Hi Zhou,
>>>
>>> Le jeu. 23 juil. 2020 à 15:19, 周琰杰 (Zhou Yanjie) 
>>> \x7f<zhouyanjie@wanyeetech.com> a écrit :
>>>> The commit 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
>>>> controller use NVMEM to find the default MAC address") add EFUSE
>>>> node for DM9000 in CI20, however, the EFUSE driver is not selected,
>>>> which will cause the DM9000 to fail to read the MAC address from
>>>> EFUSE, causing the following issue:
>>>>
>>>> [FAILED] Failed to start Raise network interfaces.
>>>>
>>>> Fix this problem by select CONFIG_JZ4780_EFUSE by default in the
>>>> ci20_defconfig.
>>>
>>> Does it actually fix it on a clean 5.8-rc kernel?
>>>
>>> From what I know, the efuse driver cannot probe, because the nemc 
>>> \x7fdriver requests the complete memory resource, so the efuse driver's 
>>> \x7fdevm_platform_ioremap_resource() fails.
>>>
>>> I did send a patch to fix this 
>>> \x7f(https://lore.kernel.org/lkml/551a8560261543c1decb1d4d1671ec4b7fa52fdb.1582905653.git.hns@goldelico.com/),
>>> but it's hard to have somebody merge it, because nobody maintains 
>>> \x7fdrivers/memory/.
>>>
>> You are right, I cleaned up the changes made to support X1000's EFUSE 
>> and rebase to clean 5.8-RC6, it still does not work properly, I think 
>> we should drop this fix patch.
>
> The patch I mentioned was merged, so starting from 5.9-rc1 the efuse 
> driver should work. Please resend this patch after 5.9-rc1 then.
>

Sure, I will resent when 5.9-rc1 is released.

Thanks and best regards!

> Thanks,
> -Paul
>
>>
>>>> Fixes: 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
>>>> controller use NVMEM to find the default MAC address").
>>>
>>> That shouldn't be a fix IMHO - the devicetree was updated in one 
>>> \x7fcommit, the config should be updated in another. The "bug" here is 
>>> \x7fthat it wasn't done right away.
>>>
>> Okay.
>>>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
>>>
>>> Btw - when you add a Fixes: tag to fix a commit that is not for the 
>>> \x7fkernel currently in RC phase, you need to Cc linux-stable as well.
>>>
>> Sure, I will pay attention next time.
>>
>> Thanks and best regards!
>>
>>
>>> Cheers,
>>> -Paul
>>>
>>>> ---
>>>>  arch/mips/configs/ci20_defconfig | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/arch/mips/configs/ci20_defconfig 
>>>> \x7f\x7fb/arch/mips/configs/ci20_defconfig
>>>> index f433fad16073..ba26ba4de09a 100644
>>>> --- a/arch/mips/configs/ci20_defconfig
>>>> +++ b/arch/mips/configs/ci20_defconfig
>>>> @@ -140,6 +140,7 @@ CONFIG_INGENIC_OST=y
>>>>  CONFIG_MEMORY=y
>>>>  CONFIG_PWM=y
>>>>  CONFIG_PWM_JZ4740=m
>>>> +CONFIG_JZ4780_EFUSE=y
>>>>  CONFIG_EXT4_FS=y
>>>>  # CONFIG_DNOTIFY is not set
>>>>  CONFIG_AUTOFS_FS=y
>>>> -- 
>>>> 2.11.0
>>>>
>>>
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23  7:19 MIPS: CI20: Update defconfig for EFUSE 周琰杰 (Zhou Yanjie)
2020-07-23  7:19 ` [PATCH] " 周琰杰 (Zhou Yanjie)
2020-07-23  8:47   ` Paul Cercueil
2020-07-25  8:02     ` Zhou Yanjie
2020-07-28 15:40       ` Paul Cercueil
2020-08-07 15:55         ` Zhou Yanjie

Linux-MIPS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mips/0 linux-mips/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mips linux-mips/ https://lore.kernel.org/linux-mips \
		linux-mips@vger.kernel.org
	public-inbox-index linux-mips

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-mips


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git