From: Paul Cercueil <paul@crapouillou.net>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Kees Cook <keescook@chromium.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Harry Wentland <harry.wentland@amd.com>,
Sam Ravnborg <sam@ravnborg.org>,
Maxime Ripard <maxime@cerno.tech>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Paul Boddie <paul@boddie.org.uk>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org,
Jonas Karlman <jonas@kwiboo.se>,
dri-devel@lists.freedesktop.org, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v5 3/7] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema
Date: Tue, 05 Oct 2021 21:43:56 +0100 [thread overview]
Message-ID: <8XUI0R.KDQ64KIMI9BU@crapouillou.net> (raw)
In-Reply-To: <518d5db83e84e3f0326854c5afb53a92e7ae4e41.1633436959.git.hns@goldelico.com>
Hi Nikolaus,
Le mar., oct. 5 2021 at 14:29:15 +0200, H. Nikolaus Schaller
<hns@goldelico.com> a écrit :
> From: Sam Ravnborg <sam@ravnborg.org>
>
> Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC.
> Based on .txt binding from Zubair Lutfullah Kakakhel
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> ---
> .../bindings/display/ingenic-jz4780-hdmi.yaml | 79
> +++++++++++++++++++
> 1 file changed, 79 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml
> b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml
> new file mode 100644
> index 000000000000..5bcb342da86f
> --- /dev/null
> +++
> b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml
> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/ingenic-jz4780-hdmi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Bindings for Ingenic JZ4780 HDMI Transmitter
> +
> +maintainers:
> + - H. Nikolaus Schaller <hns@goldelico.com>
> +
> +description: |
> + The HDMI Transmitter in the Ingenic JZ4780 is a Synopsys
> DesignWare HDMI 1.4
> + TX controller IP with accompanying PHY IP.
My dmesg disagrees:
dw-hdmi-ingenic 10180000.hdmi: Detected HDMI TX controller v1.31a with
HDCP (DWC HDMI 3D TX PHY)
Or am I comparing apples to oranges?
> +
> +allOf:
> + - $ref: bridge/synopsys,dw-hdmi.yaml#
> +
> +properties:
> + compatible:
> + const: ingenic,jz4780-dw-hdmi
> +
> + reg-io-width:
> + const: 4
> +
> + clocks:
> + maxItems: 2
> +
> + hdmi-5v-supply:
> + description: Optional regulator to provide +5V at the connector
> +
> + ddc-i2c-bus:
> + description: An I2C interface if the internal DDC I2C driver is
> not to be used
This property is used within
(drivers/gpu/drm/bridge/synopsys/dw-hdmi.c); I think it would make
sense to move it to bridge/synopsys,dw-hdmi.yaml.
Cheers,
-Paul
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> +required:
> + - compatible
> + - clocks
> + - clock-names
> + - ports
> + - reg-io-width
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/jz4780-cgu.h>
> +
> + hdmi: hdmi@10180000 {
> + compatible = "ingenic,jz4780-dw-hdmi";
> + reg = <0x10180000 0x8000>;
> + reg-io-width = <4>;
> + ddc-i2c-bus = <&i2c4>;
> + interrupt-parent = <&intc>;
> + interrupts = <3>;
> + clocks = <&cgu JZ4780_CLK_AHB0>, <&cgu JZ4780_CLK_HDMI>;
> + clock-names = "iahb", "isfr";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + hdmi_in: port@0 {
> + reg = <0>;
> + dw_hdmi_in: endpoint {
> + remote-endpoint = <&jz4780_lcd_out>;
> + };
> + };
> + hdmi_out: port@1 {
> + reg = <1>;
> + dw_hdmi_out: endpoint {
> + remote-endpoint = <&hdmi_con>;
> + };
> + };
> + };
> + };
> +
> +...
> --
> 2.33.0
>
next prev parent reply other threads:[~2021-10-05 20:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 12:29 [PATCH v5 0/7] MIPS: JZ4780 and CI20 HDMI H. Nikolaus Schaller
2021-10-05 12:29 ` [PATCH v5 1/7] drm/ingenic: Fix drm_init error path if IPU was registered H. Nikolaus Schaller
2021-10-05 12:29 ` [PATCH v5 2/7] drm/ingenic: Add support for JZ4780 and HDMI output H. Nikolaus Schaller
2021-10-05 20:22 ` Paul Cercueil
[not found] ` <7CEBB741-2218-40A7-9800-B3A154895274@goldelico.com>
2021-11-07 19:01 ` Paul Cercueil
2021-11-07 20:25 ` H. Nikolaus Schaller
2021-11-08 9:37 ` Paul Cercueil
2021-11-08 10:52 ` H. Nikolaus Schaller
2021-11-08 12:20 ` Paul Cercueil
2021-11-08 15:29 ` H. Nikolaus Schaller
2021-11-08 16:30 ` Paul Cercueil
2021-11-08 17:22 ` H. Nikolaus Schaller
2021-11-08 17:49 ` Paul Cercueil
2021-11-08 18:33 ` H. Nikolaus Schaller
2021-11-08 18:53 ` Paul Cercueil
2021-12-22 14:03 ` H. Nikolaus Schaller
2022-01-18 14:50 ` H. Nikolaus Schaller
2022-01-18 16:58 ` Paul Cercueil
2022-01-18 17:14 ` H. Nikolaus Schaller
[not found] ` <13356060.GkHXLIg068@jason>
2022-01-19 6:40 ` H. Nikolaus Schaller
2022-01-19 20:04 ` Paul Boddie
2021-10-05 12:29 ` [PATCH v5 3/7] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema H. Nikolaus Schaller
2021-10-05 20:43 ` Paul Cercueil [this message]
2021-11-07 13:43 ` H. Nikolaus Schaller
2021-11-07 19:03 ` Paul Cercueil
2021-10-05 22:45 ` Rob Herring
2021-10-05 12:29 ` [PATCH v5 4/7] drm/ingenic: Add dw-hdmi driver for jz4780 H. Nikolaus Schaller
2021-10-05 12:29 ` [PATCH v5 5/7] MIPS: DTS: jz4780: Account for Synopsys HDMI driver and LCD controllers H. Nikolaus Schaller
2021-10-05 20:50 ` Paul Cercueil
2021-10-05 21:44 ` Paul Boddie
2021-10-05 21:52 ` Paul Cercueil
2021-11-07 13:45 ` H. Nikolaus Schaller
2021-11-07 19:05 ` Paul Cercueil
2021-11-09 20:19 ` H. Nikolaus Schaller
2021-11-09 20:36 ` Paul Cercueil
2021-11-09 20:42 ` H. Nikolaus Schaller
2021-11-09 21:14 ` [Letux-kernel] " H. Nikolaus Schaller
2021-10-05 12:29 ` [PATCH v5 6/7] MIPS: DTS: CI20: Add DT nodes for HDMI setup H. Nikolaus Schaller
2021-10-05 12:29 ` [PATCH v5 7/7] MIPS: defconfig: CI20: configure for DRM_DW_HDMI_JZ4780 H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8XUI0R.KDQ64KIMI9BU@crapouillou.net \
--to=paul@crapouillou.net \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiederm@xmission.com \
--cc=ezequiel@collabora.com \
--cc=geert+renesas@glider.be \
--cc=harry.wentland@amd.com \
--cc=hns@goldelico.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=keescook@chromium.org \
--cc=letux-kernel@openphoenux.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime@cerno.tech \
--cc=miquel.raynal@bootlin.com \
--cc=narmstrong@baylibre.com \
--cc=paul@boddie.org.uk \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).