Linux-mm Archive on lore.kernel.org
 help / color / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Minchan Kim <minchan@kernel.org>
Cc: linux-mm@kvack.org, kernel-team <kernel-team@lge.com>,
	Christoph Hellwig <hch@lst.de>,
	Dan Williams <dan.j.williams@intel.com>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	Hugh Dickins <hughd@google.com>,
	Ilya Dryomov <idryomov@gmail.com>, Jens Axboe <axboe@kernel.dk>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Huang Ying <ying.huang@intel.com>
Subject: Re: [PATCH] mm for mmotm: Revert skip swap cache feture for synchronous device
Date: Tue, 02 Jan 2018 14:42:21 -0800
Message-ID: <1514932941.4018.12.camel@HansenPartnership.com> (raw)
In-Reply-To: <20180102132214.289b725cf00ac07d91e8f60b@linux-foundation.org>

On Tue, 2018-01-02 at 13:22 -0800, Andrew Morton wrote:
> On Fri, 29 Dec 2017 09:55:07 +0900 Minchan Kim <minchan@kernel.org>
> wrote:
> 
> > 
> > James reported a bug of swap paging-in for his testing and found it
> > at rc5, soon to be -rc5.
> > 
> > Although we can fix the specific problem at the moment, it may
> > have other lurkig bugs so want to have one more cycle in -next
> > before merging.
> > 
> > This patchset reverts 23c47d2ada9f, 08fa93021d80, 8e31f339295f
> > completely
> > but 79b5f08fa34e partially because the swp_swap_info function that
> > 79b5f08fa34e introduced is used by [1].
> 
> Gets a significant reject in do_swap_page().A A Could you please take a
> look, redo against current mainline?
> 
> Or not.A A We had a bug and James fixed it.A A That's what -rc is
> for.A A Why not fix the thing and proceed?

My main worry was lack of testing at -rc5, since the bug could
essentially be excited by pushing pages out to swap and then trying to
access them again ... plus since one serious bug was discovered it
wouldn't be unusual for there to be others. A However, because of the
IPT stuff, I think Linus is going to take 4.15 over a couple of extra
-rc releases, so this is less of a problem.

> There's still James's "unaccountable shutdown delay".A A Is that still
> present?A A Is it possible to see whether the full revert patch fixes
> it?

On -rc6 it's no longer manifesting with just the bug fix applied, so it
might have been a -rc5 artifact.

James

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-29  0:55 Minchan Kim
2018-01-02 21:22 ` Andrew Morton
2018-01-02 22:42   ` James Bottomley [this message]
2018-01-02 23:56     ` Minchan Kim
2018-01-03  0:11       ` James Bottomley
2018-01-03  0:24         ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1514932941.4018.12.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=dan.j.williams@intel.com \
    --cc=hch@lst.de \
    --cc=hughd@google.com \
    --cc=idryomov@gmail.com \
    --cc=kernel-team@lge.com \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=ross.zwisler@linux.intel.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mm Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \
		linux-mm@kvack.org
	public-inbox-index linux-mm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kvack.linux-mm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git