From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: linux-mm@kvack.org,
James Bottomley <James.Bottomley@hansenpartnership.com>,
kernel-team <kernel-team@lge.com>, Christoph Hellwig <hch@lst.de>,
Dan Williams <dan.j.williams@intel.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Hugh Dickins <hughd@google.com>,
Ilya Dryomov <idryomov@gmail.com>, Jens Axboe <axboe@kernel.dk>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Huang Ying <ying.huang@intel.com>
Subject: Re: [PATCH] mm for mmotm: Revert skip swap cache feture for synchronous device
Date: Tue, 2 Jan 2018 13:22:14 -0800 [thread overview]
Message-ID: <20180102132214.289b725cf00ac07d91e8f60b@linux-foundation.org> (raw)
In-Reply-To: <1514508907-10039-1-git-send-email-minchan@kernel.org>
On Fri, 29 Dec 2017 09:55:07 +0900 Minchan Kim <minchan@kernel.org> wrote:
> James reported a bug of swap paging-in for his testing and found it
> at rc5, soon to be -rc5.
>
> Although we can fix the specific problem at the moment, it may
> have other lurkig bugs so want to have one more cycle in -next
> before merging.
>
> This patchset reverts 23c47d2ada9f, 08fa93021d80, 8e31f339295f completely
> but 79b5f08fa34e partially because the swp_swap_info function that
> 79b5f08fa34e introduced is used by [1].
Gets a significant reject in do_swap_page(). Could you please take a
look, redo against current mainline?
Or not. We had a bug and James fixed it. That's what -rc is for. Why
not fix the thing and proceed?
There's still James's "unaccountable shutdown delay". Is that still
present? Is it possible to see whether the full revert patch fixes it?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2018-01-02 21:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 0:55 [PATCH] mm for mmotm: Revert skip swap cache feture for synchronous device Minchan Kim
2018-01-02 21:22 ` Andrew Morton [this message]
2018-01-02 22:42 ` James Bottomley
2018-01-02 23:56 ` Minchan Kim
2018-01-03 0:11 ` James Bottomley
2018-01-03 0:24 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180102132214.289b725cf00ac07d91e8f60b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=idryomov@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).