From: Minchan Kim <minchan@kernel.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, kernel-team <kernel-team@lge.com>,
Christoph Hellwig <hch@lst.de>,
Dan Williams <dan.j.williams@intel.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Hugh Dickins <hughd@google.com>,
Ilya Dryomov <idryomov@gmail.com>, Jens Axboe <axboe@kernel.dk>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Huang Ying <ying.huang@intel.com>
Subject: Re: [PATCH] mm for mmotm: Revert skip swap cache feture for synchronous device
Date: Wed, 3 Jan 2018 08:56:06 +0900 [thread overview]
Message-ID: <20180102235606.GA19438@bbox> (raw)
In-Reply-To: <1514932941.4018.12.camel@HansenPartnership.com>
On Tue, Jan 02, 2018 at 02:42:21PM -0800, James Bottomley wrote:
> On Tue, 2018-01-02 at 13:22 -0800, Andrew Morton wrote:
> > On Fri, 29 Dec 2017 09:55:07 +0900 Minchan Kim <minchan@kernel.org>
> > wrote:
> >
> > >
> > > James reported a bug of swap paging-in for his testing and found it
> > > at rc5, soon to be -rc5.
> > >
> > > Although we can fix the specific problem at the moment, it may
> > > have other lurkig bugs so want to have one more cycle in -next
> > > before merging.
> > >
> > > This patchset reverts 23c47d2ada9f, 08fa93021d80, 8e31f339295f
> > > completely
> > > but 79b5f08fa34e partially because the swp_swap_info function that
> > > 79b5f08fa34e introduced is used by [1].
> >
> > Gets a significant reject in do_swap_page(). Could you please take a
> > look, redo against current mainline?
> >
> > Or not. We had a bug and James fixed it. That's what -rc is
> > for. Why not fix the thing and proceed?
>
> My main worry was lack of testing at -rc5, since the bug could
> essentially be excited by pushing pages out to swap and then trying to
> access them again ... plus since one serious bug was discovered it
> wouldn't be unusual for there to be others. However, because of the
> IPT stuff, I think Linus is going to take 4.15 over a couple of extra
> -rc releases, so this is less of a problem.
Then, Here is right fix patch against current mainline.
next prev parent reply other threads:[~2018-01-02 23:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 0:55 [PATCH] mm for mmotm: Revert skip swap cache feture for synchronous device Minchan Kim
2018-01-02 21:22 ` Andrew Morton
2018-01-02 22:42 ` James Bottomley
2018-01-02 23:56 ` Minchan Kim [this message]
2018-01-03 0:11 ` James Bottomley
2018-01-03 0:24 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180102235606.GA19438@bbox \
--to=minchan@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=idryomov@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-mm@kvack.org \
--cc=ross.zwisler@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).