From: Qian Cai <cai@lca.pw>
To: Ben Dooks <ben.dooks@codethink.co.uk>,
linux-kernel@lists.codethink.co.uk
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: include <linux/huge_mm.h> for is_vma_temporary_stack
Date: Wed, 09 Oct 2019 11:37:38 -0400 [thread overview]
Message-ID: <1570635458.5937.15.camel@lca.pw> (raw)
In-Reply-To: <20191009151155.27763-1-ben.dooks@codethink.co.uk>
On Wed, 2019-10-09 at 16:11 +0100, Ben Dooks wrote:
> Include <linux/huge_mm.h> for the definition of
> is_vma_temporary_stack to fix the following
> sparse warning:
>
> mm/rmap.c:1673:6: warning: symbol 'is_vma_temporary_stack' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
It makes sense.
Reviewed-by: Qian Cai <cai@lca.pw>
> ---
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> ---
> mm/rmap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/rmap.c b/mm/rmap.c
> index d9a23bb773bf..0c7b2a9400d4 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -61,6 +61,7 @@
> #include <linux/mmu_notifier.h>
> #include <linux/migrate.h>
> #include <linux/hugetlb.h>
> +#include <linux/huge_mm.h>
> #include <linux/backing-dev.h>
> #include <linux/page_idle.h>
> #include <linux/memremap.h>
WARNING: multiple messages have this Message-ID (diff)
From: "Qian Cai" <cai@lca.pw>
To: "Ben Dooks" <ben.dooks@codethink.co.uk>,
"linux-kernel@lists.codethink.co.uk"
<linux-kernel@lists.codethink.co.uk>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: include <linux/huge_mm.h> for is_vma_temporary_stack
Date: Wed, 09 Oct 2019 11:37:38 -0400 [thread overview]
Message-ID: <1570635458.5937.15.camel@lca.pw> (raw)
Message-ID: <20191009153738.k9O6prXUZ0kH2rN8IcIct6a3oIbS8oX_qwKYW_Dqs-k@z> (raw)
In-Reply-To: <20191009151155.27763-1-ben.dooks@codethink.co.uk>
On Wed, 2019-10-09 at 16:11 +0100, Ben Dooks wrote:
> Include <linux/huge_mm.h> for the definition of
> is_vma_temporary_stack to fix the following
> sparse warning:
>
> mm/rmap.c:1673:6: warning: symbol 'is_vma_temporary_stack' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
It makes sense.
Reviewed-by: Qian Cai <cai@lca.pw>
> ---
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> ---
> mm/rmap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/rmap.c b/mm/rmap.c
> index d9a23bb773bf..0c7b2a9400d4 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -61,6 +61,7 @@
> #include <linux/mmu_notifier.h>
> #include <linux/migrate.h>
> #include <linux/hugetlb.h>
> +#include <linux/huge_mm.h>
> #include <linux/backing-dev.h>
> #include <linux/page_idle.h>
> #include <linux/memremap.h>
next prev parent reply other threads:[~2019-10-09 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 15:11 [PATCH] mm: include <linux/huge_mm.h> for is_vma_temporary_stack Ben Dooks
2019-10-09 15:37 ` Qian Cai [this message]
2019-10-09 15:37 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1570635458.5937.15.camel@lca.pw \
--to=cai@lca.pw \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).