[PATCH] mm: include <linux/huge_mm.h> for is_vma_temporary_stack

[PATCH] mm: include <linux/huge_mm.h> for is_vma_temporary_stack

[Ben Dooks]

Include <linux/huge_mm.h> for the definition of
is_vma_temporary_stack to fix the following
sparse warning:

mm/rmap.c:1673:6: warning: symbol 'is_vma_temporary_stack' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
---
 mm/rmap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/rmap.c b/mm/rmap.c
index d9a23bb773bf..0c7b2a9400d4 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -61,6 +61,7 @@
 #include <linux/mmu_notifier.h>
 #include <linux/migrate.h>
 #include <linux/hugetlb.h>
+#include <linux/huge_mm.h>
 #include <linux/backing-dev.h>
 #include <linux/page_idle.h>
 #include <linux/memremap.h>
-- 
2.23.0

Re: [PATCH] mm: include <linux/huge_mm.h> for is_vma_temporary_stack

[Qian Cai]

On Wed, 2019-10-09 at 16:11 +0100, Ben Dooks wrote:
> Include <linux/huge_mm.h> for the definition of
> is_vma_temporary_stack to fix the following
> sparse warning:
> 
> mm/rmap.c:1673:6: warning: symbol 'is_vma_temporary_stack' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

It makes sense.

Reviewed-by: Qian Cai <cai@lca.pw>

> ---
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  mm/rmap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mm/rmap.c b/mm/rmap.c
> index d9a23bb773bf..0c7b2a9400d4 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -61,6 +61,7 @@
>  #include <linux/mmu_notifier.h>
>  #include <linux/migrate.h>
>  #include <linux/hugetlb.h>
> +#include <linux/huge_mm.h>
>  #include <linux/backing-dev.h>
>  #include <linux/page_idle.h>
>  #include <linux/memremap.h>

Re: [PATCH] mm: include <linux/huge_mm.h> for is_vma_temporary_stack

[Qian Cai]

On Wed, 2019-10-09 at 16:11 +0100, Ben Dooks wrote:
> Include <linux/huge_mm.h> for the definition of
> is_vma_temporary_stack to fix the following
> sparse warning:
> 
> mm/rmap.c:1673:6: warning: symbol 'is_vma_temporary_stack' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

It makes sense.

Reviewed-by: Qian Cai <cai@lca.pw>

> ---
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  mm/rmap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mm/rmap.c b/mm/rmap.c
> index d9a23bb773bf..0c7b2a9400d4 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -61,6 +61,7 @@
>  #include <linux/mmu_notifier.h>
>  #include <linux/migrate.h>
>  #include <linux/hugetlb.h>
> +#include <linux/huge_mm.h>
>  #include <linux/backing-dev.h>
>  #include <linux/page_idle.h>
>  #include <linux/memremap.h>