* [PATCH -next] mm/ptdump: fix a -Wold-style-declaration warning
@ 2019-11-04 19:23 Qian Cai
0 siblings, 0 replies; only message in thread
From: Qian Cai @ 2019-11-04 19:23 UTC (permalink / raw)
To: akpm; +Cc: steven.price, linux-mm, linux-kernel, Qian Cai
The -next commit "mm: add generic ptdump" [1] introduced a GCC
compilation warning,
mm/ptdump.c:123:1: warning: 'static' is not at beginning of declaration
[-Wold-style-declaration]
const static struct mm_walk_ops ptdump_ops = {
^~~~~
[1] http://lkml.kernel.org/r/20191028135910.33253-20-steven.price@arm.com
Signed-off-by: Qian Cai <cai@lca.pw>
---
mm/ptdump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/ptdump.c b/mm/ptdump.c
index 5d349311e77e..a30ea0cf6c5f 100644
--- a/mm/ptdump.c
+++ b/mm/ptdump.c
@@ -120,7 +120,7 @@ static int ptdump_hole(unsigned long addr, unsigned long next,
return 0;
}
-const static struct mm_walk_ops ptdump_ops = {
+static const struct mm_walk_ops ptdump_ops = {
.pgd_entry = ptdump_pgd_entry,
.p4d_entry = ptdump_p4d_entry,
.pud_entry = ptdump_pud_entry,
--
1.8.3.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-11-04 19:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04 19:23 [PATCH -next] mm/ptdump: fix a -Wold-style-declaration warning Qian Cai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).