* [PATCH] mm: memblock: fix minor typo and unclear comment
@ 2020-05-07 10:22 qiwuchen55
2020-05-09 16:01 ` Mike Rapoport
0 siblings, 1 reply; 2+ messages in thread
From: qiwuchen55 @ 2020-05-07 10:22 UTC (permalink / raw)
To: rppt, akpm; +Cc: linux-mm, chenqiwu
From: chenqiwu <chenqiwu@xiaomi.com>
Fix a minor typo "usabe->usable" for the current discription
of member variable "memory" in struct memblock.
BTW, I think it's unclear the member variable "base" in
struct memblock_type is currently described as the physical
address of memory region, change it to base address of the
region is clearer since the variable is decorated as phys_addr_t.
Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
---
include/linux/memblock.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/memblock.h b/include/linux/memblock.h
index 6bc37a7..b594e0b 100644
--- a/include/linux/memblock.h
+++ b/include/linux/memblock.h
@@ -41,7 +41,7 @@ enum memblock_flags {
/**
* struct memblock_region - represents a memory region
- * @base: physical address of the region
+ * @base: base address of the region
* @size: size of the region
* @flags: memory region attributes
* @nid: NUMA node id
@@ -75,7 +75,7 @@ struct memblock_type {
* struct memblock - memblock allocator metadata
* @bottom_up: is bottom up direction?
* @current_limit: physical address of the current allocation limit
- * @memory: usabe memory regions
+ * @memory: usable memory regions
* @reserved: reserved memory regions
* @physmem: all physical memory
*/
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm: memblock: fix minor typo and unclear comment
2020-05-07 10:22 [PATCH] mm: memblock: fix minor typo and unclear comment qiwuchen55
@ 2020-05-09 16:01 ` Mike Rapoport
0 siblings, 0 replies; 2+ messages in thread
From: Mike Rapoport @ 2020-05-09 16:01 UTC (permalink / raw)
To: qiwuchen55; +Cc: akpm, linux-mm, chenqiwu
On Thu, May 07, 2020 at 06:22:32PM +0800, qiwuchen55@gmail.com wrote:
> From: chenqiwu <chenqiwu@xiaomi.com>
>
> Fix a minor typo "usabe->usable" for the current discription
> of member variable "memory" in struct memblock.
>
> BTW, I think it's unclear the member variable "base" in
> struct memblock_type is currently described as the physical
> address of memory region, change it to base address of the
> region is clearer since the variable is decorated as phys_addr_t.
>
> Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> include/linux/memblock.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
> index 6bc37a7..b594e0b 100644
> --- a/include/linux/memblock.h
> +++ b/include/linux/memblock.h
> @@ -41,7 +41,7 @@ enum memblock_flags {
>
> /**
> * struct memblock_region - represents a memory region
> - * @base: physical address of the region
> + * @base: base address of the region
> * @size: size of the region
> * @flags: memory region attributes
> * @nid: NUMA node id
> @@ -75,7 +75,7 @@ struct memblock_type {
> * struct memblock - memblock allocator metadata
> * @bottom_up: is bottom up direction?
> * @current_limit: physical address of the current allocation limit
> - * @memory: usabe memory regions
> + * @memory: usable memory regions
> * @reserved: reserved memory regions
> * @physmem: all physical memory
> */
> --
> 1.9.1
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-09 16:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 10:22 [PATCH] mm: memblock: fix minor typo and unclear comment qiwuchen55
2020-05-09 16:01 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).