From: Vlastimil Babka <vbabka@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michal Hocko <mhocko@kernel.org>,
Mel Gorman <mgorman@techsingularity.net>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
David Rientjes <rientjes@google.com>,
Rik van Riel <riel@redhat.com>, Vlastimil Babka <vbabka@suse.cz>
Subject: [PATCH v3 00/17] make direct compaction more deterministic
Date: Fri, 24 Jun 2016 11:54:20 +0200 [thread overview]
Message-ID: <20160624095437.16385-1-vbabka@suse.cz> (raw)
Changes since v2:
* Rebase on mmotm-2016-06-15-16-18 with Mel's node-based reclaim series dropped
locally. Note there will be some small conflicts, but nothing substantial
that should complicate readding Mel's series later and invalidate testing.
* Dropped patch 18 which was the only major conflict with Mel's series, which
solves the same thing, and it wasn't that important in this series.
* The rebasing however required some major rewrite of patches 2 and 3 due to
changes in mmotm, so I dropped the acks. Changes there should also address
reviewers' concerns. E.g. ALLOC_NO_WATERMARKS is used in direct reclaim and
compaction attempts after patch 3, as Joonsoo suggested.
* In patch 12, compaction retries are now only counted after reaching the final
priority (suggested by Michal Hocko).
Changes since v1 RFC:
* Incorporate feedback from Michal, Joonsoo, Tetsuo
* Expanded cleanup of watermark checks controlling reclaim/compaction
This is mostly a followup to Michal's oom detection rework, which highlighted
the need for direct compaction to provide better feedback in reclaim/compaction
loop, so that it can reliably recognize when compaction cannot make further
progress, and allocation should invoke OOM killer or fail. We've discussed
this at LSF/MM [1] where I proposed expanding the async/sync migration mode
used in compaction to more general "priorities". This patchset adds one new
priority that just overrides all the heuristics and makes compaction fully
scan all zones. I don't currently think that we need more fine-grained
priorities, but we'll see. Other than that there's some smaller fixes and
cleanups, mainly related to the THP-specific hacks.
I've tested this with stress-highalloc in GFP_KERNEL order-4 and
GFP_HIGHUSER_MOVABLE order-9 scenarios. There's not much report but noise,
except reductions in direct reclaim.
order-9:
Direct pages scanned 238949 41502
Kswapd pages scanned 2069710 2229295
Kswapd pages reclaimed 1981047 2139089
Direct pages reclaimed 236534 41502
order-4:
Direct pages scanned 204214 110733
Kswapd pages scanned 2125221 2179180
Kswapd pages reclaimed 2027102 2098257
Direct pages reclaimed 194942 110695
Also Patch 1 describes reductions in page migration failures.
[1] https://lwn.net/Articles/684611/
Hugh Dickins (1):
mm, compaction: don't isolate PageWriteback pages in
MIGRATE_SYNC_LIGHT mode
Vlastimil Babka (16):
mm, page_alloc: set alloc_flags only once in slowpath
mm, page_alloc: don't retry initial attempt in slowpath
mm, page_alloc: restructure direct compaction handling in slowpath
mm, page_alloc: make THP-specific decisions more generic
mm, thp: remove __GFP_NORETRY from khugepaged and madvised allocations
mm, compaction: introduce direct compaction priority
mm, compaction: simplify contended compaction handling
mm, compaction: make whole_zone flag ignore cached scanner positions
mm, compaction: cleanup unused functions
mm, compaction: add the ultimate direct compaction priority
mm, compaction: more reliably increase direct compaction priority
mm, compaction: use correct watermark when checking allocation success
mm, compaction: create compact_gap wrapper
mm, compaction: use proper alloc_flags in __compaction_suitable()
mm, compaction: require only min watermarks for non-costly orders
mm, vmscan: make compaction_ready() more accurate and readable
include/linux/compaction.h | 84 ++++++-------
include/linux/gfp.h | 14 ++-
include/trace/events/compaction.h | 12 +-
include/trace/events/mmflags.h | 1 +
mm/compaction.c | 186 +++++++++------------------
mm/huge_memory.c | 29 +++--
mm/internal.h | 7 +-
mm/khugepaged.c | 2 +-
mm/migrate.c | 2 +-
mm/page_alloc.c | 258 ++++++++++++++++++--------------------
mm/vmscan.c | 47 ++++---
tools/perf/builtin-kmem.c | 1 +
12 files changed, 281 insertions(+), 362 deletions(-)
--
2.8.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2016-06-24 9:55 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 9:54 Vlastimil Babka [this message]
2016-06-24 9:54 ` [PATCH v3 01/17] mm, compaction: don't isolate PageWriteback pages in MIGRATE_SYNC_LIGHT mode Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 02/17] mm, page_alloc: set alloc_flags only once in slowpath Vlastimil Babka
2016-06-30 14:44 ` Michal Hocko
2016-06-24 9:54 ` [PATCH v3 03/17] mm, page_alloc: don't retry initial attempt " Vlastimil Babka
2016-06-30 15:03 ` Michal Hocko
2016-06-24 9:54 ` [PATCH v3 04/17] mm, page_alloc: restructure direct compaction handling " Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 05/17] mm, page_alloc: make THP-specific decisions more generic Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 06/17] mm, thp: remove __GFP_NORETRY from khugepaged and madvised allocations Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 07/17] mm, compaction: introduce direct compaction priority Vlastimil Babka
2016-06-24 11:39 ` kbuild test robot
2016-06-24 11:51 ` Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 08/17] mm, compaction: simplify contended compaction handling Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 09/17] mm, compaction: make whole_zone flag ignore cached scanner positions Vlastimil Babka
2016-07-06 5:09 ` Joonsoo Kim
2016-07-18 9:12 ` Vlastimil Babka
2016-07-19 6:44 ` Joonsoo Kim
2016-07-19 6:54 ` Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 10/17] mm, compaction: cleanup unused functions Vlastimil Babka
2016-06-24 11:53 ` Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 11/17] mm, compaction: add the ultimate direct compaction priority Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 12/17] mm, compaction: more reliably increase " Vlastimil Babka
2016-07-06 5:39 ` Joonsoo Kim
2016-07-15 13:37 ` Vlastimil Babka
2016-07-18 4:41 ` Joonsoo Kim
2016-07-18 12:21 ` Vlastimil Babka
2016-07-19 4:53 ` Joonsoo Kim
2016-07-19 7:42 ` Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 13/17] mm, compaction: use correct watermark when checking allocation success Vlastimil Babka
2016-07-06 5:47 ` Joonsoo Kim
2016-07-18 9:23 ` Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 14/17] mm, compaction: create compact_gap wrapper Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 15/17] mm, compaction: use proper alloc_flags in __compaction_suitable() Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 16/17] mm, compaction: require only min watermarks for non-costly orders Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 17/17] mm, vmscan: make compaction_ready() more accurate and readable Vlastimil Babka
2016-07-06 5:55 ` Joonsoo Kim
2016-07-18 11:48 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624095437.16385-1-vbabka@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).