From: Vlastimil Babka <vbabka@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michal Hocko <mhocko@kernel.org>,
Mel Gorman <mgorman@techsingularity.net>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
David Rientjes <rientjes@google.com>,
Rik van Riel <riel@redhat.com>, Hugh Dickins <hughd@google.com>,
Vlastimil Babka <vbabka@suse.cz>
Subject: [PATCH v3 01/17] mm, compaction: don't isolate PageWriteback pages in MIGRATE_SYNC_LIGHT mode
Date: Fri, 24 Jun 2016 11:54:21 +0200 [thread overview]
Message-ID: <20160624095437.16385-2-vbabka@suse.cz> (raw)
In-Reply-To: <20160624095437.16385-1-vbabka@suse.cz>
From: Hugh Dickins <hughd@google.com>
At present MIGRATE_SYNC_LIGHT is allowing __isolate_lru_page() to
isolate a PageWriteback page, which __unmap_and_move() then rejects
with -EBUSY: of course the writeback might complete in between, but
that's not what we usually expect, so probably better not to isolate it.
When tested by stress-highalloc from mmtests, this has reduced the number of
page migrate failures by 60-70%.
Signed-off-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
Acked-by: Michal Hocko <mhocko@suse.com>
---
mm/compaction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index c611b8a42023..b7b696e46eaa 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1204,7 +1204,7 @@ static isolate_migrate_t isolate_migratepages(struct zone *zone,
struct page *page;
const isolate_mode_t isolate_mode =
(sysctl_compact_unevictable_allowed ? ISOLATE_UNEVICTABLE : 0) |
- (cc->mode == MIGRATE_ASYNC ? ISOLATE_ASYNC_MIGRATE : 0);
+ (cc->mode != MIGRATE_SYNC ? ISOLATE_ASYNC_MIGRATE : 0);
/*
* Start at where we last stopped, or beginning of the zone as
--
2.8.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-06-24 9:55 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 9:54 [PATCH v3 00/17] make direct compaction more deterministic Vlastimil Babka
2016-06-24 9:54 ` Vlastimil Babka [this message]
2016-06-24 9:54 ` [PATCH v3 02/17] mm, page_alloc: set alloc_flags only once in slowpath Vlastimil Babka
2016-06-30 14:44 ` Michal Hocko
2016-06-24 9:54 ` [PATCH v3 03/17] mm, page_alloc: don't retry initial attempt " Vlastimil Babka
2016-06-30 15:03 ` Michal Hocko
2016-06-24 9:54 ` [PATCH v3 04/17] mm, page_alloc: restructure direct compaction handling " Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 05/17] mm, page_alloc: make THP-specific decisions more generic Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 06/17] mm, thp: remove __GFP_NORETRY from khugepaged and madvised allocations Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 07/17] mm, compaction: introduce direct compaction priority Vlastimil Babka
2016-06-24 11:39 ` kbuild test robot
2016-06-24 11:51 ` Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 08/17] mm, compaction: simplify contended compaction handling Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 09/17] mm, compaction: make whole_zone flag ignore cached scanner positions Vlastimil Babka
2016-07-06 5:09 ` Joonsoo Kim
2016-07-18 9:12 ` Vlastimil Babka
2016-07-19 6:44 ` Joonsoo Kim
2016-07-19 6:54 ` Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 10/17] mm, compaction: cleanup unused functions Vlastimil Babka
2016-06-24 11:53 ` Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 11/17] mm, compaction: add the ultimate direct compaction priority Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 12/17] mm, compaction: more reliably increase " Vlastimil Babka
2016-07-06 5:39 ` Joonsoo Kim
2016-07-15 13:37 ` Vlastimil Babka
2016-07-18 4:41 ` Joonsoo Kim
2016-07-18 12:21 ` Vlastimil Babka
2016-07-19 4:53 ` Joonsoo Kim
2016-07-19 7:42 ` Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 13/17] mm, compaction: use correct watermark when checking allocation success Vlastimil Babka
2016-07-06 5:47 ` Joonsoo Kim
2016-07-18 9:23 ` Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 14/17] mm, compaction: create compact_gap wrapper Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 15/17] mm, compaction: use proper alloc_flags in __compaction_suitable() Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 16/17] mm, compaction: require only min watermarks for non-costly orders Vlastimil Babka
2016-06-24 9:54 ` [PATCH v3 17/17] mm, vmscan: make compaction_ready() more accurate and readable Vlastimil Babka
2016-07-06 5:55 ` Joonsoo Kim
2016-07-18 11:48 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624095437.16385-2-vbabka@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).