From: Michal Hocko <mhocko@suse.com>
To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
mike.kravetz@Oracle.com, n-horiguchi@ah.jp.nec.com,
aneesh.kumar@linux.vnet.ibm.com, gerald.schaefer@de.ibm.com,
zhongjiang@huawei.com, aarcange@redhat.com,
kirill.shutemov@linux.intel.com
Subject: Re: [PATCH] mm/hugetlb: Warn the user when issues arise on boot due to hugepages
Date: Mon, 5 Jun 2017 06:57:42 +0200 [thread overview]
Message-ID: <20170605045725.GA9248@dhcp22.suse.cz> (raw)
In-Reply-To: <20170603005413.10380-1-Liam.Howlett@Oracle.com>
On Fri 02-06-17 20:54:13, Liam R. Howlett wrote:
> When the user specifies too many hugepages or an invalid
> default_hugepagesz the communication to the user is implicit in the
> allocation message. This patch adds a warning when the desired page
> count is not allocated and prints an error when the default_hugepagesz
> is invalid on boot.
We do not warn when doing echo $NUM > nr_hugepages, so why should we
behave any different during the boot?
> Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
> ---
> mm/hugetlb.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index e5828875f7bb..6de30bbac23e 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -70,6 +70,7 @@ struct mutex *hugetlb_fault_mutex_table ____cacheline_aligned_in_smp;
>
> /* Forward declaration */
> static int hugetlb_acct_memory(struct hstate *h, long delta);
> +static char * __init memfmt(char *buf, unsigned long n);
>
> static inline void unlock_or_release_subpool(struct hugepage_subpool *spool)
> {
> @@ -2189,7 +2190,14 @@ static void __init hugetlb_hstate_alloc_pages(struct hstate *h)
> &node_states[N_MEMORY]))
> break;
> }
> - h->max_huge_pages = i;
> + if (i < h->max_huge_pages) {
> + char buf[32];
> +
> + memfmt(buf, huge_page_size(h)),
> + pr_warn("HugeTLB: allocating %lu of page size %s failed. Only allocated %lu hugepages.\n",
> + h->max_huge_pages, buf, i);
> + h->max_huge_pages = i;
> + }
> }
>
> static void __init hugetlb_init_hstates(void)
> @@ -2785,6 +2793,11 @@ static int __init hugetlb_init(void)
> return 0;
>
> if (!size_to_hstate(default_hstate_size)) {
> + if (default_hstate_size != 0) {
> + pr_err("HugeTLB: unsupported default_hugepagesz %lu. Reverting to %lu\n",
> + default_hstate_size, HPAGE_SIZE);
> + }
> +
> default_hstate_size = HPAGE_SIZE;
> if (!size_to_hstate(default_hstate_size))
> hugetlb_add_hstate(HUGETLB_PAGE_ORDER);
> --
> 2.13.0.92.gcd65a7235
>
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-05 4:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-03 0:54 [PATCH] mm/hugetlb: Warn the user when issues arise on boot due to hugepages Liam R. Howlett
2017-06-05 4:57 ` Michal Hocko [this message]
2017-06-05 15:15 ` Liam R. Howlett
2017-06-06 5:49 ` Michal Hocko
2017-06-06 6:01 ` Michal Hocko
2017-06-12 17:28 ` Liam R. Howlett
2017-06-12 17:49 ` Michal Hocko
2017-06-12 18:37 ` Liam R. Howlett
2017-06-12 18:52 ` Michal Hocko
2017-06-13 1:35 ` Liam R. Howlett
2017-06-13 5:42 ` Michal Hocko
2017-06-13 15:25 ` Liam R. Howlett
2017-06-13 16:26 ` Mike Kravetz
2017-06-14 7:27 ` Michal Hocko
2017-06-14 17:02 ` Mike Kravetz
2017-06-14 7:25 ` Michal Hocko
2017-06-16 19:07 ` Andrew Morton
2017-06-17 0:25 ` Mike Kravetz
2017-06-17 6:51 ` Michal Hocko
2017-06-19 19:59 ` Liam R. Howlett
2017-06-05 22:38 ` Andrew Morton
2017-06-06 19:03 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170605045725.GA9248@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=Liam.Howlett@Oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@Oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).