From: Andrew Morton <akpm@linux-foundation.org>
To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
Cc: linux-mm@kvack.org, mike.kravetz@Oracle.com, mhocko@suse.com,
n-horiguchi@ah.jp.nec.com, aneesh.kumar@linux.vnet.ibm.com,
gerald.schaefer@de.ibm.com, zhongjiang@huawei.com,
aarcange@redhat.com, kirill.shutemov@linux.intel.com--dry-run
Subject: Re: [PATCH] mm/hugetlb: Warn the user when issues arise on boot due to hugepages
Date: Mon, 5 Jun 2017 15:38:19 -0700 [thread overview]
Message-ID: <20170605153819.9c86969a73926e4269e77976@linux-foundation.org> (raw)
In-Reply-To: <20170603005413.10380-1-Liam.Howlett@Oracle.com>
On Fri, 2 Jun 2017 20:54:13 -0400 "Liam R. Howlett" <Liam.Howlett@Oracle.com> wrote:
> When the user specifies too many hugepages or an invalid
> default_hugepagesz the communication to the user is implicit in the
> allocation message. This patch adds a warning when the desired page
> count is not allocated and prints an error when the default_hugepagesz
> is invalid on boot.
>
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -70,6 +70,7 @@ struct mutex *hugetlb_fault_mutex_table ____cacheline_aligned_in_smp;
>
> /* Forward declaration */
> static int hugetlb_acct_memory(struct hstate *h, long delta);
> +static char * __init memfmt(char *buf, unsigned long n);
It's better to just move memfmt() to the right place. After all, you
have revealed that it was in the wrong place, no?
(Am a bit surprised that something as general as memfmt is private to
hugetlb.c)
--- a/mm/hugetlb.c~mm-hugetlb-warn-the-user-when-issues-arise-on-boot-due-to-hugepages-fix
+++ a/mm/hugetlb.c
@@ -69,7 +69,17 @@ struct mutex *hugetlb_fault_mutex_table
/* Forward declaration */
static int hugetlb_acct_memory(struct hstate *h, long delta);
-static char * __init memfmt(char *buf, unsigned long n);
+
+static char * __init memfmt(char *buf, unsigned long n)
+{
+ if (n >= (1UL << 30))
+ sprintf(buf, "%lu GB", n >> 30);
+ else if (n >= (1UL << 20))
+ sprintf(buf, "%lu MB", n >> 20);
+ else
+ sprintf(buf, "%lu KB", n >> 10);
+ return buf;
+}
static inline void unlock_or_release_subpool(struct hugepage_subpool *spool)
{
@@ -2238,17 +2248,6 @@ static void __init hugetlb_init_hstates(
VM_BUG_ON(minimum_order == UINT_MAX);
}
-static char * __init memfmt(char *buf, unsigned long n)
-{
- if (n >= (1UL << 30))
- sprintf(buf, "%lu GB", n >> 30);
- else if (n >= (1UL << 20))
- sprintf(buf, "%lu MB", n >> 20);
- else
- sprintf(buf, "%lu KB", n >> 10);
- return buf;
-}
-
static void __init report_hugepages(void)
{
struct hstate *h;
_
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-05 22:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-03 0:54 [PATCH] mm/hugetlb: Warn the user when issues arise on boot due to hugepages Liam R. Howlett
2017-06-05 4:57 ` Michal Hocko
2017-06-05 15:15 ` Liam R. Howlett
2017-06-06 5:49 ` Michal Hocko
2017-06-06 6:01 ` Michal Hocko
2017-06-12 17:28 ` Liam R. Howlett
2017-06-12 17:49 ` Michal Hocko
2017-06-12 18:37 ` Liam R. Howlett
2017-06-12 18:52 ` Michal Hocko
2017-06-13 1:35 ` Liam R. Howlett
2017-06-13 5:42 ` Michal Hocko
2017-06-13 15:25 ` Liam R. Howlett
2017-06-13 16:26 ` Mike Kravetz
2017-06-14 7:27 ` Michal Hocko
2017-06-14 17:02 ` Mike Kravetz
2017-06-14 7:25 ` Michal Hocko
2017-06-16 19:07 ` Andrew Morton
2017-06-17 0:25 ` Mike Kravetz
2017-06-17 6:51 ` Michal Hocko
2017-06-19 19:59 ` Liam R. Howlett
2017-06-05 22:38 ` Andrew Morton [this message]
2017-06-06 19:03 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170605153819.9c86969a73926e4269e77976@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@Oracle.com \
--cc=aarcange@redhat.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=kirill.shutemov@linux.intel.com--dry-run \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@Oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).