From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: linux-mm <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@kernel.org>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH] mm/memblock: replace u64 with phys_addr_t where appropriate
Date: Tue, 3 Jul 2018 12:57:22 -0700 [thread overview]
Message-ID: <20180703125722.6fd0f02b27c01f5684877354@linux-foundation.org> (raw)
In-Reply-To: <1530637506-1256-1-git-send-email-rppt@linux.vnet.ibm.com>
On Tue, 3 Jul 2018 20:05:06 +0300 Mike Rapoport <rppt@linux.vnet.ibm.com> wrote:
> Most functions in memblock already use phys_addr_t to represent a physical
> address with __memblock_free_late() being an exception.
>
> This patch replaces u64 with phys_addr_t in __memblock_free_late() and
> switches several format strings from %llx to %pa to avoid casting from
> phys_addr_t to u64.
>
> ...
>
> @@ -1343,9 +1343,9 @@ void * __init memblock_virt_alloc_try_nid_raw(
> {
> void *ptr;
>
> - memblock_dbg("%s: %llu bytes align=0x%llx nid=%d from=0x%llx max_addr=0x%llx %pF\n",
> - __func__, (u64)size, (u64)align, nid, (u64)min_addr,
> - (u64)max_addr, (void *)_RET_IP_);
> + memblock_dbg("%s: %llu bytes align=0x%llx nid=%d from=%pa max_addr=%pa %pF\n",
> + __func__, (u64)size, (u64)align, nid, &min_addr,
> + &max_addr, (void *)_RET_IP_);
>
Did you see all this checkpatch noise?
: WARNING: Deprecated vsprintf pointer extension '%pF' - use %pS instead
: #54: FILE: mm/memblock.c:1348:
: + memblock_dbg("%s: %llu bytes align=0x%llx nid=%d from=%pa max_addr=%pa %pF\n",
: + __func__, (u64)size, (u64)align, nid, &min_addr,
: + &max_addr, (void *)_RET_IP_);
: ...
:
* - 'S' For symbolic direct pointers (or function descriptors) with offset
* - 's' For symbolic direct pointers (or function descriptors) without offset
* - 'F' Same as 'S'
* - 'f' Same as 's'
I'm not sure why or when all that happened.
I suppose we should do that as a separate patch sometime.
next prev parent reply other threads:[~2018-07-03 19:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 17:05 [PATCH] mm/memblock: replace u64 with phys_addr_t where appropriate Mike Rapoport
2018-07-03 17:22 ` Pavel Tatashin
2018-07-03 19:57 ` Andrew Morton [this message]
2018-07-03 20:24 ` Joe Perches
2018-07-04 7:03 ` Mike Rapoport
2018-07-04 7:23 ` Sergey Senozhatsky
2018-07-04 9:04 ` Joe Perches
2018-07-04 9:20 ` Sergey Senozhatsky
2018-07-04 9:43 ` Sergey Senozhatsky
2018-07-04 15:20 ` Mike Rapoport
2018-07-04 7:54 ` Sergey Senozhatsky
2018-07-04 15:21 ` Mike Rapoport
2018-07-04 17:22 ` Joe Perches
2018-07-05 7:12 ` Mike Rapoport
2018-07-04 7:02 ` Mike Rapoport
2018-07-04 13:05 ` Michal Hocko
2018-07-04 13:24 ` Mike Rapoport
2018-07-04 13:29 ` Michal Hocko
2018-07-04 14:04 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703125722.6fd0f02b27c01f5684877354@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).