linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@linux.vnet.ibm.com>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm <linux-mm@kvack.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Michal Hocko <mhocko@kernel.org>,
	Matthew Wilcox <willy@infradead.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] mm/memblock: replace u64 with phys_addr_t where appropriate
Date: Wed, 4 Jul 2018 10:03:06 +0300	[thread overview]
Message-ID: <20180704070305.GB4352@rapoport-lnx> (raw)
In-Reply-To: <063c785caa11b8e1c421c656b2a030d45d6eb68f.camel@perches.com>

On Tue, Jul 03, 2018 at 01:24:07PM -0700, Joe Perches wrote:
> On Tue, 2018-07-03 at 12:57 -0700, Andrew Morton wrote:
> > Did you see all this checkpatch noise?
> > 
> > : WARNING: Deprecated vsprintf pointer extension '%pF' - use %pS instead
> > : #54: FILE: mm/memblock.c:1348:
> > : +	memblock_dbg("%s: %llu bytes align=0x%llx nid=%d from=%pa max_addr=%pa %pF\n",
> > : +		     __func__, (u64)size, (u64)align, nid, &min_addr,
> > : +		     &max_addr, (void *)_RET_IP_);
> > : ...
> 
> %p[Ff] got deprecated by commit 04b8eb7a4ccd9ef9343e2720ccf2a5db8cfe2f67
> 
> I think it'd be simplest to just convert
> all the %pF and %pf uses all at once.
> 
> $ git grep --name-only "%p[Ff]" | \
>   xargs sed -i -e 's/%pF/%pS/' -e 's/%pf/%ps/'
> 
> and remove the appropriate Documentation bit.
> 

Something like this:

  reply	other threads:[~2018-07-04  7:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03 17:05 [PATCH] mm/memblock: replace u64 with phys_addr_t where appropriate Mike Rapoport
2018-07-03 17:22 ` Pavel Tatashin
2018-07-03 19:57 ` Andrew Morton
2018-07-03 20:24   ` Joe Perches
2018-07-04  7:03     ` Mike Rapoport [this message]
2018-07-04  7:23       ` Sergey Senozhatsky
2018-07-04  9:04         ` Joe Perches
2018-07-04  9:20           ` Sergey Senozhatsky
2018-07-04  9:43             ` Sergey Senozhatsky
2018-07-04 15:20               ` Mike Rapoport
2018-07-04  7:54       ` Sergey Senozhatsky
2018-07-04 15:21         ` Mike Rapoport
2018-07-04 17:22       ` Joe Perches
2018-07-05  7:12         ` Mike Rapoport
2018-07-04  7:02   ` Mike Rapoport
2018-07-04 13:05 ` Michal Hocko
2018-07-04 13:24   ` Mike Rapoport
2018-07-04 13:29     ` Michal Hocko
2018-07-04 14:04 ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180704070305.GB4352@rapoport-lnx \
    --to=rppt@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).