From: Baoquan He <bhe@redhat.com>
To: Mike Rapoport <rppt@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
pasha.tatashin@oracle.com, mhocko@suse.com,
rppt@linux.vnet.ibm.com, richard.weiyang@gmail.com,
linux-mm@kvack.org
Subject: Re: [PATCH 1/3] mm/sparse: Clean up the obsolete code comment
Date: Wed, 20 Mar 2019 16:00:08 +0800 [thread overview]
Message-ID: <20190320080008.GK18740@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20190320075058.GB13626@rapoport-lnx>
On 03/20/19 at 09:50am, Mike Rapoport wrote:
> Hi,
>
> On Wed, Mar 20, 2019 at 03:35:38PM +0800, Baoquan He wrote:
> > The code comment above sparse_add_one_section() is obsolete and
> > incorrect, clean it up and write new one.
> >
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > ---
> > mm/sparse.c | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/mm/sparse.c b/mm/sparse.c
> > index 77a0554fa5bd..0a0f82c5d969 100644
> > --- a/mm/sparse.c
> > +++ b/mm/sparse.c
> > @@ -674,9 +674,12 @@ static void free_map_bootmem(struct page *memmap)
> > #endif /* CONFIG_SPARSEMEM_VMEMMAP */
> >
> > /*
> > - * returns the number of sections whose mem_maps were properly
> > - * set. If this is <=0, then that means that the passed-in
> > - * map was not consumed and must be freed.
> > + * sparse_add_one_section - add a memory section
>
> Please mention that this is only intended for memory hotplug
Will do. Thanks for reviewing.
>
> > + * @nid: The node to add section on
> > + * @start_pfn: start pfn of the memory range
> > + * @altmap: device page map
> > + *
> > + * Return 0 on success and an appropriate error code otherwise.
>
> s/Return/Return:/ please
Thanks, will change.
>
> > */
> > int __meminit sparse_add_one_section(int nid, unsigned long start_pfn,
> > struct vmem_altmap *altmap)
> > --
> > 2.17.2
> >
>
> --
> Sincerely yours,
> Mike.
>
next prev parent reply other threads:[~2019-03-20 8:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 7:35 [PATCH 1/3] mm/sparse: Clean up the obsolete code comment Baoquan He
2019-03-20 7:35 ` [PATCH 2/3] mm/sparse: Optimize sparse_add_one_section() Baoquan He
2019-03-20 7:56 ` Mike Rapoport
2019-03-20 8:03 ` Baoquan He
2019-03-20 10:13 ` Baoquan He
2019-03-20 11:22 ` Matthew Wilcox
2019-03-20 11:27 ` Mike Rapoport
2019-03-20 7:35 ` [PATCH 3/3] mm/sparse: Rename function related to section memmap allocation/free Baoquan He
2019-03-20 7:50 ` [PATCH 1/3] mm/sparse: Clean up the obsolete code comment Mike Rapoport
2019-03-20 8:00 ` Baoquan He [this message]
2019-03-20 11:19 ` Matthew Wilcox
2019-03-20 11:53 ` Baoquan He
2019-03-20 12:20 ` Oscar Salvador
2019-03-20 12:22 ` Matthew Wilcox
2019-03-20 12:36 ` Mike Rapoport
2019-03-20 12:58 ` Matthew Wilcox
2019-03-21 6:40 ` Baoquan He
2019-03-21 9:21 ` Baoquan He
2019-03-21 10:24 ` William Kucharski
2019-03-21 10:35 ` Michal Hocko
2019-03-21 11:19 ` William Kucharski
2019-03-21 14:19 ` Baoquan He
2019-03-20 12:37 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320080008.GK18740@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pasha.tatashin@oracle.com \
--cc=richard.weiyang@gmail.com \
--cc=rppt@linux.ibm.com \
--cc=rppt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).