From: Baoquan He <bhe@redhat.com>
To: Michal Hocko <mhocko@kernel.org>,
William Kucharski <william.kucharski@oracle.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Oscar Salvador <osalvador@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Pavel Tatashin <pasha.tatashin@oracle.com>,
rppt@linux.vnet.ibm.com, richard.weiyang@gmail.com,
linux-mm@kvack.org
Subject: Re: [PATCH 1/3] mm/sparse: Clean up the obsolete code comment
Date: Thu, 21 Mar 2019 22:19:15 +0800 [thread overview]
Message-ID: <20190321141915.GZ18740@MiWiFi-R3L-srv> (raw)
In-Reply-To: <EAFD8223-BEED-4985-8CD4-D3410A5898A6@oracle.com>
On 03/21/19 at 05:19am, William Kucharski wrote:
>
>
> > On Mar 21, 2019, at 4:35 AM, Michal Hocko <mhocko@kernel.org> wrote:
> >
> > I am sorry to be snarky but hasn't this generated way much more email
> > traffic than it really deserves? A simply and trivial clean up in the
> > beginning that was it, right?
Yeah, I'd like to do like this. Will arrange patch and post a new
version. Sorry about the mail bomb to CCed people.
Yet I also would like to hear any suggestion from people who intend to
improve. Discussions make me know more the status of errno than before.
Thank you all for sharing.
>
> That's rather the point; that it did generate a fair amount of email
> traffic indicates it's worthy of at least a passing mention in a
> comment somewhere.
We header files to put errno. Only changing in kernel may cause
difference between it and userspace. I will list each returned value in
code comment and tell what they are meaning in this function, that could
be helpful. Thanks.
usr/include/asm-generic/errno-base.h
include/uapi/asm-generic/errno-base.h
next prev parent reply other threads:[~2019-03-21 14:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 7:35 [PATCH 1/3] mm/sparse: Clean up the obsolete code comment Baoquan He
2019-03-20 7:35 ` [PATCH 2/3] mm/sparse: Optimize sparse_add_one_section() Baoquan He
2019-03-20 7:56 ` Mike Rapoport
2019-03-20 8:03 ` Baoquan He
2019-03-20 10:13 ` Baoquan He
2019-03-20 11:22 ` Matthew Wilcox
2019-03-20 11:27 ` Mike Rapoport
2019-03-20 7:35 ` [PATCH 3/3] mm/sparse: Rename function related to section memmap allocation/free Baoquan He
2019-03-20 7:50 ` [PATCH 1/3] mm/sparse: Clean up the obsolete code comment Mike Rapoport
2019-03-20 8:00 ` Baoquan He
2019-03-20 11:19 ` Matthew Wilcox
2019-03-20 11:53 ` Baoquan He
2019-03-20 12:20 ` Oscar Salvador
2019-03-20 12:22 ` Matthew Wilcox
2019-03-20 12:36 ` Mike Rapoport
2019-03-20 12:58 ` Matthew Wilcox
2019-03-21 6:40 ` Baoquan He
2019-03-21 9:21 ` Baoquan He
2019-03-21 10:24 ` William Kucharski
2019-03-21 10:35 ` Michal Hocko
2019-03-21 11:19 ` William Kucharski
2019-03-21 14:19 ` Baoquan He [this message]
2019-03-20 12:37 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321141915.GZ18740@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@oracle.com \
--cc=richard.weiyang@gmail.com \
--cc=rppt@linux.ibm.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).