From: Matthew Wilcox <willy@infradead.org>
To: Mike Rapoport <rppt@linux.ibm.com>
Cc: Oscar Salvador <osalvador@suse.de>, Baoquan He <bhe@redhat.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
pasha.tatashin@oracle.com, mhocko@suse.com,
rppt@linux.vnet.ibm.com, richard.weiyang@gmail.com,
linux-mm@kvack.org
Subject: Re: [PATCH 1/3] mm/sparse: Clean up the obsolete code comment
Date: Wed, 20 Mar 2019 05:58:43 -0700 [thread overview]
Message-ID: <20190320125843.GY19508@bombadil.infradead.org> (raw)
In-Reply-To: <20190320123658.GF13626@rapoport-lnx>
On Wed, Mar 20, 2019 at 02:36:58PM +0200, Mike Rapoport wrote:
> There are more than a thousand -EEXIST in the kernel, I really doubt all of
> them mean "File exists" ;-)
And yet that's what the user will see if it's ever printed with perror()
or similar. We're pretty bad at choosing errnos; look how abused
ENOSPC is:
$ errno ENOSPC
ENOSPC 28 No space left on device
net/sunrpc/auth_gss/gss_rpc_xdr.c: return -ENOSPC;
... that's an authentication failure, not "I've run out of disc space".
next prev parent reply other threads:[~2019-03-20 12:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 7:35 [PATCH 1/3] mm/sparse: Clean up the obsolete code comment Baoquan He
2019-03-20 7:35 ` [PATCH 2/3] mm/sparse: Optimize sparse_add_one_section() Baoquan He
2019-03-20 7:56 ` Mike Rapoport
2019-03-20 8:03 ` Baoquan He
2019-03-20 10:13 ` Baoquan He
2019-03-20 11:22 ` Matthew Wilcox
2019-03-20 11:27 ` Mike Rapoport
2019-03-20 7:35 ` [PATCH 3/3] mm/sparse: Rename function related to section memmap allocation/free Baoquan He
2019-03-20 7:50 ` [PATCH 1/3] mm/sparse: Clean up the obsolete code comment Mike Rapoport
2019-03-20 8:00 ` Baoquan He
2019-03-20 11:19 ` Matthew Wilcox
2019-03-20 11:53 ` Baoquan He
2019-03-20 12:20 ` Oscar Salvador
2019-03-20 12:22 ` Matthew Wilcox
2019-03-20 12:36 ` Mike Rapoport
2019-03-20 12:58 ` Matthew Wilcox [this message]
2019-03-21 6:40 ` Baoquan He
2019-03-21 9:21 ` Baoquan He
2019-03-21 10:24 ` William Kucharski
2019-03-21 10:35 ` Michal Hocko
2019-03-21 11:19 ` William Kucharski
2019-03-21 14:19 ` Baoquan He
2019-03-20 12:37 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320125843.GY19508@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@oracle.com \
--cc=richard.weiyang@gmail.com \
--cc=rppt@linux.ibm.com \
--cc=rppt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).