* [hnaz-linux-mm:master 60/194] include/linux/pgtable.h:74:27: error: redefinition of 'pte_offset_kernel'
@ 2020-06-09 16:12 kernel test robot
2020-06-09 22:26 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2020-06-09 16:12 UTC (permalink / raw)
To: Mike Rapoport
Cc: kbuild-all, Johannes Weiner, Andrew Morton, Linux Memory Management List
[-- Attachment #1: Type: text/plain, Size: 2239 bytes --]
tree: https://github.com/hnaz/linux-mm master
head: a017b085735719105714da692a82a6eeb8830718
commit: f48b9eb10f8c3f378ea4552fee58db3dea980e62 [60/194] mm: consolidate pte_index() and pte_offset_*() definitions
config: sparc-defconfig (attached as .config)
compiler: sparc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout f48b9eb10f8c3f378ea4552fee58db3dea980e62
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from include/linux/mm.h:31,
from include/linux/memblock.h:13,
from arch/sparc/mm/srmmu.c:14:
>> include/linux/pgtable.h:74:27: error: redefinition of 'pte_offset_kernel'
74 | #define pte_offset_kernel pte_offset_kernel
| ^~~~~~~~~~~~~~~~~
>> arch/sparc/mm/srmmu.c:144:8: note: in expansion of macro 'pte_offset_kernel'
144 | pte_t *pte_offset_kernel(pmd_t *dir, unsigned long address)
| ^~~~~~~~~~~~~~~~~
include/linux/pgtable.h:70:22: note: previous definition of 'pte_offset_kernel' was here
70 | static inline pte_t *pte_offset_kernel(pmd_t *pmd, unsigned long address)
| ^~~~~~~~~~~~~~~~~
arch/sparc/mm/srmmu.c: In function 'poke_hypersparc':
arch/sparc/mm/srmmu.c:1093:25: error: variable 'clear' set but not used [-Werror=unused-but-set-variable]
1093 | volatile unsigned long clear;
| ^~~~~
cc1: all warnings being treated as errors
vim +/pte_offset_kernel +74 include/linux/pgtable.h
68
69 #ifndef pte_offset_kernel
70 static inline pte_t *pte_offset_kernel(pmd_t *pmd, unsigned long address)
71 {
72 return (pte_t *)pmd_page_vaddr(*pmd) + pte_index(address);
73 }
> 74 #define pte_offset_kernel pte_offset_kernel
75 #endif
76
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 13148 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [hnaz-linux-mm:master 60/194] include/linux/pgtable.h:74:27: error: redefinition of 'pte_offset_kernel'
2020-06-09 16:12 [hnaz-linux-mm:master 60/194] include/linux/pgtable.h:74:27: error: redefinition of 'pte_offset_kernel' kernel test robot
@ 2020-06-09 22:26 ` Andrew Morton
2020-06-10 4:27 ` Mike Rapoport
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2020-06-09 22:26 UTC (permalink / raw)
To: kernel test robot
Cc: Mike Rapoport, kbuild-all, Johannes Weiner, Linux Memory Management List
On Wed, 10 Jun 2020 00:12:12 +0800 kernel test robot <lkp@intel.com> wrote:
> tree: https://github.com/hnaz/linux-mm master
> head: a017b085735719105714da692a82a6eeb8830718
> commit: f48b9eb10f8c3f378ea4552fee58db3dea980e62 [60/194] mm: consolidate pte_index() and pte_offset_*() definitions
> config: sparc-defconfig (attached as .config)
> compiler: sparc-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout f48b9eb10f8c3f378ea4552fee58db3dea980e62
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All error/warnings (new ones prefixed by >>, old ones prefixed by <<):
>
> In file included from include/linux/mm.h:31,
> from include/linux/memblock.h:13,
> from arch/sparc/mm/srmmu.c:14:
> >> include/linux/pgtable.h:74:27: error: redefinition of 'pte_offset_kernel'
> 74 | #define pte_offset_kernel pte_offset_kernel
> | ^~~~~~~~~~~~~~~~~
> >> arch/sparc/mm/srmmu.c:144:8: note: in expansion of macro 'pte_offset_kernel'
> 144 | pte_t *pte_offset_kernel(pmd_t *dir, unsigned long address)
> | ^~~~~~~~~~~~~~~~~
> include/linux/pgtable.h:70:22: note: previous definition of 'pte_offset_kernel' was here
> 70 | static inline pte_t *pte_offset_kernel(pmd_t *pmd, unsigned long address)
> | ^~~~~~~~~~~~~~~~~
> arch/sparc/mm/srmmu.c: In function 'poke_hypersparc':
> arch/sparc/mm/srmmu.c:1093:25: error: variable 'clear' set but not used [-Werror=unused-but-set-variable]
> 1093 | volatile unsigned long clear;
Well dang. The function was supposed to have been removed but
obviously this was lost during all the merging messes.
Mike, can you please confirm that this is still good?
--- a/arch/sparc/mm/srmmu.c~a
+++ a/arch/sparc/mm/srmmu.c
@@ -140,16 +140,6 @@ void pmd_set(pmd_t *pmdp, pte_t *ptep)
set_pte((pte_t *)&pmd_val(*pmdp), __pte(SRMMU_ET_PTD | ptp));
}
-/* Find an entry in the third-level page table.. */
-pte_t *pte_offset_kernel(pmd_t *dir, unsigned long address)
-{
- void *pte;
-
- pte = __nocache_va((pmd_val(*dir) & SRMMU_PTD_PMASK) << 4);
- return (pte_t *) pte +
- ((address >> PAGE_SHIFT) & (PTRS_PER_PTE - 1));
-}
-
/*
* size: bytes to allocate in the nocache area.
* align: bytes, number to align at.
_
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [hnaz-linux-mm:master 60/194] include/linux/pgtable.h:74:27: error: redefinition of 'pte_offset_kernel'
2020-06-09 22:26 ` Andrew Morton
@ 2020-06-10 4:27 ` Mike Rapoport
0 siblings, 0 replies; 3+ messages in thread
From: Mike Rapoport @ 2020-06-10 4:27 UTC (permalink / raw)
To: Andrew Morton
Cc: kernel test robot, kbuild-all, Johannes Weiner,
Linux Memory Management List
On Tue, Jun 09, 2020 at 03:26:06PM -0700, Andrew Morton wrote:
> On Wed, 10 Jun 2020 00:12:12 +0800 kernel test robot <lkp@intel.com> wrote:
>
> > tree: https://github.com/hnaz/linux-mm master
> > head: a017b085735719105714da692a82a6eeb8830718
> > commit: f48b9eb10f8c3f378ea4552fee58db3dea980e62 [60/194] mm: consolidate pte_index() and pte_offset_*() definitions
> > config: sparc-defconfig (attached as .config)
> > compiler: sparc-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > git checkout f48b9eb10f8c3f378ea4552fee58db3dea980e62
> > # save the attached .config to linux build tree
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All error/warnings (new ones prefixed by >>, old ones prefixed by <<):
> >
> > In file included from include/linux/mm.h:31,
> > from include/linux/memblock.h:13,
> > from arch/sparc/mm/srmmu.c:14:
> > >> include/linux/pgtable.h:74:27: error: redefinition of 'pte_offset_kernel'
> > 74 | #define pte_offset_kernel pte_offset_kernel
> > | ^~~~~~~~~~~~~~~~~
> > >> arch/sparc/mm/srmmu.c:144:8: note: in expansion of macro 'pte_offset_kernel'
> > 144 | pte_t *pte_offset_kernel(pmd_t *dir, unsigned long address)
> > | ^~~~~~~~~~~~~~~~~
> > include/linux/pgtable.h:70:22: note: previous definition of 'pte_offset_kernel' was here
> > 70 | static inline pte_t *pte_offset_kernel(pmd_t *pmd, unsigned long address)
> > | ^~~~~~~~~~~~~~~~~
> > arch/sparc/mm/srmmu.c: In function 'poke_hypersparc':
> > arch/sparc/mm/srmmu.c:1093:25: error: variable 'clear' set but not used [-Werror=unused-but-set-variable]
> > 1093 | volatile unsigned long clear;
>
> Well dang. The function was supposed to have been removed but
> obviously this was lost during all the merging messes.
>
> Mike, can you please confirm that this is still good?
Yep, it is.
> --- a/arch/sparc/mm/srmmu.c~a
> +++ a/arch/sparc/mm/srmmu.c
> @@ -140,16 +140,6 @@ void pmd_set(pmd_t *pmdp, pte_t *ptep)
> set_pte((pte_t *)&pmd_val(*pmdp), __pte(SRMMU_ET_PTD | ptp));
> }
>
> -/* Find an entry in the third-level page table.. */
> -pte_t *pte_offset_kernel(pmd_t *dir, unsigned long address)
> -{
> - void *pte;
> -
> - pte = __nocache_va((pmd_val(*dir) & SRMMU_PTD_PMASK) << 4);
> - return (pte_t *) pte +
> - ((address >> PAGE_SHIFT) & (PTRS_PER_PTE - 1));
> -}
> -
> /*
> * size: bytes to allocate in the nocache area.
> * align: bytes, number to align at.
> _
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-10 4:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-09 16:12 [hnaz-linux-mm:master 60/194] include/linux/pgtable.h:74:27: error: redefinition of 'pte_offset_kernel' kernel test robot
2020-06-09 22:26 ` Andrew Morton
2020-06-10 4:27 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).