From: Mike Rapoport <rppt@kernel.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andi Kleen <ak@linux.intel.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()
Date: Fri, 24 Jul 2020 13:27:48 +0300 [thread overview]
Message-ID: <20200724102748.GD2831654@kernel.org> (raw)
In-Reply-To: <20200724050553.1724168-6-jarkko.sakkinen@linux.intel.com>
On Fri, Jul 24, 2020 at 08:05:52AM +0300, Jarkko Sakkinen wrote:
> Use text_alloc() and text_free() instead of module_alloc() and
> module_memfree() when an arch provides them.
>
> Cc: linux-mm@kvack.org
> Cc: Andi Kleen <ak@linux.intel.com>
> Cc: Masami Hiramatsu <mhiramat@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> ---
> kernel/kprobes.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index 4e46d96d4e16..611fcda9f6bf 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -40,6 +40,7 @@
> #include <asm/cacheflush.h>
> #include <asm/errno.h>
> #include <linux/uaccess.h>
> +#include <linux/vmalloc.h>
>
> #define KPROBE_HASH_BITS 6
> #define KPROBE_TABLE_SIZE (1 << KPROBE_HASH_BITS)
> @@ -111,12 +112,20 @@ enum kprobe_slot_state {
>
> void __weak *alloc_insn_page(void)
> {
> +#ifdef CONFIG_ARCH_HAS_TEXT_ALLOC
> + return text_alloc(PAGE_SIZE);
> +#else
> return module_alloc(PAGE_SIZE);
> +#endif
> }
>
> void __weak free_insn_page(void *page)
> {
> +#ifdef CONFIG_ARCH_HAS_TEXT_ALLOC
> + text_free(page);
> +#else
> module_memfree(page);
> +#endif
> }
Both alloc_insn_page() and free_insn_page() are __weak and can be simple
overriden in arch/x86 code.
> struct kprobe_insn_cache kprobe_insn_slots = {
> --
> 2.25.1
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2020-07-24 10:27 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 5:05 [PATCH v5 0/6] arch/x86: kprobes: Remove MODULES dependency Jarkko Sakkinen
2020-07-24 5:05 ` [PATCH v5 1/6] kprobes: Remove dependency to the module_mutex Jarkko Sakkinen
2020-07-24 9:13 ` Ingo Molnar
2020-07-25 2:36 ` Jarkko Sakkinen
2020-07-24 9:17 ` Ingo Molnar
2020-07-25 3:01 ` Jarkko Sakkinen
2020-07-25 10:21 ` Ingo Molnar
2020-07-28 7:34 ` Masami Hiramatsu
2020-08-17 21:22 ` Jarkko Sakkinen
2020-07-24 10:22 ` Mike Rapoport
2020-07-25 2:42 ` Jarkko Sakkinen
2020-07-24 14:46 ` Masami Hiramatsu
2020-07-25 2:48 ` Jarkko Sakkinen
2020-07-24 5:05 ` [PATCH v5 2/6] vmalloc: Add text_alloc() and text_free() Jarkko Sakkinen
2020-07-24 10:22 ` Mike Rapoport
2020-07-25 2:20 ` Jarkko Sakkinen
2020-07-24 5:05 ` [PATCH v5 3/6] arch/x86: Implement " Jarkko Sakkinen
2020-07-24 9:22 ` Ingo Molnar
2020-07-25 2:03 ` Jarkko Sakkinen
2020-07-24 5:05 ` [PATCH v5 4/6] arch/x86: kprobes: Use " Jarkko Sakkinen
2020-07-24 5:05 ` [PATCH v5 5/6] " Jarkko Sakkinen
2020-07-24 9:27 ` Ingo Molnar
2020-07-24 12:16 ` Ard Biesheuvel
2020-07-25 3:19 ` [PATCH v5 5/6] kprobes: Use text_alloc() and text_free()] Jarkko Sakkinen
2020-07-25 3:16 ` [PATCH v5 5/6] kprobes: Use text_alloc() and text_free() Jarkko Sakkinen
2020-07-26 8:14 ` Mike Rapoport
2020-07-26 16:06 ` Ard Biesheuvel
2020-07-28 8:17 ` Masami Hiramatsu
2020-07-28 10:56 ` Ard Biesheuvel
2020-07-28 13:35 ` Masami Hiramatsu
2020-07-28 17:51 ` Ard Biesheuvel
2020-07-29 1:50 ` Masami Hiramatsu
2020-07-29 6:13 ` Ard Biesheuvel
2020-07-30 1:09 ` Masami Hiramatsu
2020-08-18 5:30 ` Jarkko Sakkinen
2020-08-18 11:51 ` Mike Rapoport
2020-08-18 16:30 ` Jarkko Sakkinen
2020-08-19 6:47 ` Mike Rapoport
2020-08-19 21:07 ` Jarkko Sakkinen
2020-07-24 10:27 ` Mike Rapoport [this message]
2020-07-24 14:57 ` Masami Hiramatsu
2020-07-24 23:38 ` Jarkko Sakkinen
2020-07-24 5:05 ` [PATCH v5 6/6] kprobes: Remove CONFIG_MODULES dependency Jarkko Sakkinen
2020-07-24 7:01 ` [PATCH v5 0/6] arch/x86: kprobes: Remove MODULES dependency Jarkko Sakkinen
2020-07-24 10:26 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724102748.GD2831654@kernel.org \
--to=rppt@kernel.org \
--cc=ak@linux.intel.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhiramat@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).