From: Aili Yao <yaoaili@kingsoft.com>
To: David Hildenbrand <david@redhat.com>
Cc: <akpm@linux-foundation.org>, <naoya.horiguchi@nec.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<yangfeng1@kingsoft.com>, <sunhao2@kingsoft.com>,
Oscar Salvador <osalvador@suse.de>,
Mike Kravetz <mike.kravetz@oracle.com>, <yaoaili@kingsoft.com>
Subject: Re: [PATCH] mm/gup: check page posion status for coredump.
Date: Thu, 18 Mar 2021 11:15:46 +0800 [thread overview]
Message-ID: <20210318111546.4bda8c7a@alex-virtual-machine> (raw)
In-Reply-To: <20a0d078-f49d-54d6-9f04-f6b41dd51e5f@redhat.com>
On Wed, 17 Mar 2021 10:12:02 +0100
David Hildenbrand <david@redhat.com> wrote:
>
> I wonder if a simple
>
> if (PageHWPoison(compound_head(page)))
> ret = 0;
>
> won't suffice. But I guess the "issue" is compound pages that are not
> huge pages or transparent huge pages.
Yes, the simple case won't suffice, as we mark the hugetlb page poison in head, and
other cases in the specific single page struct.
> If not, we certainly want a wrapper for that magic, otherwise we have to
> replicate the same logic all over the place.
>
> > +
> > return (ret == 1) ? page : NULL;
> > }
> > #endif /* CONFIG_ELF_CORE */
> >
>
>
Yes, May other places meet the requirements as the coredump meets, it's better to make a
wrapper for this. But i am not familiar with the specific scenario, so this patch only cover
the coredump case.
I will post a v2 patch for this.
--
Thanks!
Aili Yao
next prev parent reply other threads:[~2021-03-18 3:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 8:37 [PATCH] mm/gup: check page posion status for coredump Aili Yao
2021-03-17 9:12 ` David Hildenbrand
2021-03-18 3:15 ` Aili Yao [this message]
2021-03-18 3:18 ` [PATCH v2] " Aili Yao
2021-03-18 4:46 ` [PATCH] " Matthew Wilcox
2021-03-18 5:34 ` Aili Yao
2021-03-19 2:44 ` [PATCH v3] " Aili Yao
2021-03-20 0:35 ` Matthew Wilcox
2021-03-22 3:40 ` Aili Yao
2021-03-22 11:33 ` [PATCH v5] mm/gup: check page hwposion " Aili Yao
2021-03-26 14:09 ` David Hildenbrand
2021-03-26 14:22 ` David Hildenbrand
2021-03-31 1:52 ` HORIGUCHI NAOYA(堀口 直也)
2021-03-31 2:43 ` Aili Yao
2021-03-31 4:32 ` HORIGUCHI NAOYA(堀口 直也)
2021-03-31 6:44 ` David Hildenbrand
2021-03-31 7:07 ` Aili Yao
2021-04-01 2:31 ` Aili Yao
2021-04-06 2:23 ` [PATCH v6] mm/gup: check page hwpoison status for memory recovery failures Aili Yao
2021-04-06 2:41 ` [PATCH v7] " Aili Yao
2021-04-07 1:54 ` HORIGUCHI NAOYA(堀口 直也)
2021-04-07 7:48 ` Aili Yao
2021-05-10 3:13 ` Aili Yao
2021-03-31 6:07 ` [PATCH v5] mm/gup: check page hwposion status for coredump Matthew Wilcox
2021-03-31 6:53 ` HORIGUCHI NAOYA(堀口 直也)
2021-03-31 7:05 ` David Hildenbrand
2021-03-18 8:14 ` [PATCH] mm/gup: check page posion " David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318111546.4bda8c7a@alex-virtual-machine \
--to=yaoaili@kingsoft.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
--cc=sunhao2@kingsoft.com \
--cc=yangfeng1@kingsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).